[meeting] Migrate Meeting 2022-09-15 1400Z
Hello all, it’s time for the weekly migration subsystem meeting. The meeting will take place in slack in various threads This meeting:➤ Is for core migrate maintainers and developers and anybody else...
View Articlehook_comment_unpublish is never invoked
As I was writing a module that wanted to hook into the hook_comment_unpublish (as documented in the comment api) I found out that this hook is never invoked. I fixed this by altering the comment_save...
View Articlehook_comment publish to be called only on the status change and not every time
Follow-up to #2554965: hook_comment_unpublish is never invokedProblem/Motivationhook_comment_publish is called every time the published comment is saved.Proposed resolutionIt should be called only when...
View ArticletrackLastImported YAML key to enable tracking the last import date of a row...
Problem/MotivationIn order to enable recording of the last imported date in a migration, the yaml key:trackLastImported: truemust be set in the migration yaml. This is the only configuration key...
View ArticleGet rid of hard-coded markup in hook_help() implementations
Updated: Comment #NProblem/MotivationThere are a couple of problems with how we are doing hook_help() implementations currently in Drupal 8 and all previous versions. Here is a typical...
View ArticleDefault values are not displayed for fields placed in Layout Builder
Problem/MotivationScenario: -Content type with field_image added. -Default image set for field on content type. -Core layout builder is used to define display layout. -Body field and image field are...
View ArticleMissing schema entry for type file_link link_to_entity when used in a view
Create a content type with file field. Create a view and link the title to the file and not the content type. Exported view .yml file contains title: id: title table: node_field_data field: title type:...
View ArticleAdd recursion protection to EntityReferenceItem normalizers
Problem/MotivationThe HAL module's EntityReferenceItemNormalizer identifies the target_id and invokes the serializer to embed the referenced object in the HAL structures _links and _embedded...
View ArticleLow-level file upload handling buggy when allowing all file extensions
Problem/MotivationThere are use cases where a managed file upload form element should allow files with any extension (or even without an extension). file_save_upload supports this use case, but it is...
View ArticleRemove @ckeditor/ckeditor5-dev-utils
Problem/MotivationI think we could simply remove our dependency on @ckeditor/ckeditor5-dev-utils since we are no longer running the DLL build for upstream packages on our end. The issue where that...
View ArticleEntityListBuilderTest: @coversDefaultClass is incorrect
While working on #2876274: Renderer: deprecate mergeBubbleableMetadata() and addCacheableDependency()I noticed this errorphpunit with the code coverage switch enabled is good at compiling and...
View ArticleNot possible to run Functional tests if bootstrap.inc file is not shared...
Problem/MotivationFor the last couple of hours, I've been struggling why Functional tests cannot run in dockerized, multi-container environment that only shares some volumes (sites/default/files,...
View ArticleFix test performance of Drupal\system\Tests\Menu\BreadcrumbTest
Problem/MotivationSpeed up testbot and simplify tests by using the testing profile instead of the standard profile.Steps to reproduceProposed resolutionConvert Drupal\node\Tests\NodeAccessBaseTableTest...
View ArticleHow to recover Admin host locked out, IP band, Admin account active
Problem/MotivationHello and thank you for any leads... I (Admin user 1) can't log into website. error message:"This host is not allowed to log in to In Low Gear 4x4 בהילוך נמוך . Please contact your...
View ArticleBook allows emptying node titles in admin/content/book/* (Notice: Trying to...
Problem/Motivationadmin/content/book/* page allows editors to update the book titles etc. On this page if node title is not set, it still allows to save the book pages form. Because of that, node title...
View ArticleAdd content in tests only when needed
Problem/MotivationThis a followup to #3087061: Move existing assertions of IdConflict page to new test files. The Upgrade tests adds content for testing the IdConflict form. There are now new tests...
View Articlepassword confirm does not appear on node edit form
Problem/MotivationPassword confirm field does not appear on node edit form.Steps to reproduceSet up entity_access_password module to protect individual entities. Set a password on a node. Then try to...
View ArticleMenus are not rendered when machine name starting with hyphen
Problem/MotivationI named my custom menus starting with a * to distinguish them from the system menus e.g:*Navigation Left *Navigation Middle *Navigation RightThe machine names are like...
View ArticleDeprecate EditorLinkDialog, EditorImageDialog and EditorMediaDialog in Drupal...
Problem/MotivationCKEditor 5 will not use the editor.module-andmedia.module provided link, image and media dialog...
View Article[meta] Convert remaining tests using Standard profile to use Testing profile...
Problem/MotivationThe start of these changes was in #1373142: Use the Testing profile. Speed up testbot by 50% and to reducing test time and cost. Use the testing profile instead of standard where...
View Article