MenuActiveTrail creates invalid cache tags when called without a menu name
We have a custom module that calls MenuActiveTrail::getActiveTrailIds(NULL); to get the active trail in any menu. But calling it with NULL causes MenuActiveTrail::resolveCacheMiss() to create a cache...
View ArticleDoc adjustments after "Entity forms skip validation of fields that are...
A couple adjustments after #2395831: Entity forms skip validation of fields that are not in the EntityFormDisplay, that got committed while I was reviewing it (well, I was very late to the party...
View ArticleClik here to view.
Uncaught TypeError: this.$pluginSelect.find(...)[0] is undefined
Problem/MotivationAfter upgrade Drupal core to 9.4.* I get a JS error when drag fields on "manage display" tab of any content type. When error is present I can't drop field after drag (mouse click and...
View ArticleIn views.api.php, entity_type is protected
In line 617 of views.api.php: $entity_type_id = $field->entity_type; The entity_type property is protected. Should it use $field->getTargetEntityTypeId()?Proposed solution: Use getTargetEntityTypeId
View ArticleRemove outdated todo in...
Problem/MotivationThere's TODO to remove code hunk in October 2020Steps to reproduce // If this parameter isn't explicitly set, modify the output to be fully // backward compatible to code before Views...
View ArticleBlock page visibility paths are not validated, using path a without leading...
Problem/MotivationBlock page visibility paths are not validated, using path a without leading forward slash does not work.Steps to ReproduceInstall using standard install profileNavigate to...
View ArticleUninstall form does not add drupal.tableresponsive library
Problem/MotivationModulesUninstallForm buildForm() does not add the 'core/drupal.tableresponsive' library, whereas the corresponding install form ModulesListForm does add this library. The missing...
View Articlecommit-code-check.sh gives unclear output when CSS is not properly rebuilt
Problem/MotivationDiscovered in #3206643-135: Project messaging channel in core (as experimental) . When there was a change to the CSS but it was not recompiled, the code quality checks failed without...
View ArticleClik here to view.
Add support for .FLAC, .OPUS and .AAC audio type of file with HTML 5 audio...
Is it reasonable to ask to add support for .FLAC and .AAC audio type of file with HTML 5 audio player? Is it scheduled? Does it ask a lot of dev?the problem i face is that i use mediaelement.js as...
View ArticleOlivero: Header menu should not close if menu item has focus
The header menu should not close if an item within the menu has focusSteps to reproduce:Tab into the primary menu and open a submenuScroll down the page. Note that the header menu will collapse.
View ArticleHook presave does not set original correctly when editing non-default...
Problem/Motivation\Drupal\Core\Entity\EntityStorageBase::doPreSave does not reload the 'original' node into $entity->original when workflows are enabled for the bundle and the entity being updated...
View ArticleAdd php-tuf/composer-stager to core dependencies — for experimental Automatic...
Problem/MotivationThe package_manager module that will be added to Drupal core for both https://www.drupal.org/project/automatic_updates and https://www.drupal.org/project/project_browser has one very...
View Article'Filter by block name' filter is not working correctly
Problem/MotivationWhen adding block through the Layout builder, the 'Filter by block name' filter doesn't seem to find any results. This is tested with Drupal core 9.4.5 on simplytest.meSee attached...
View ArticleAdd new hook DATABASEMODULE_views_data_DATABASEDRIVER_alter to the views module
Problem/MotivationThe database driver for MongoDB needs to change the views data after all calls to the hook_views_data_alter() have run. MongoDB stores all entity data for an entity instance in a...
View ArticleAllow the ChangedItem to skip updating the entity's "changed"...
Problem/MotivationEspecially for migrate it would be really useful to be able to copy the old changed time, for example from a note.After #2428795: Translatable entity 'changed' timestamps are not...
View ArticleAllow overriding the login button label in UiHelperTrait::drupalLogin
API page: https://api.drupal.org/api/drupal/core%21tests%21Drupal%21Tests%21Browse...If the label is changed in Drupal Login form, drupalLogin function in 21BrowserTestBase will fail because it always...
View ArticleImprove documentation of EntityStorageInterface create funtion
Problem/MotivationIn the documentation for EntityStorageBase::create it is written:array $values: (optional) An array of values to set, keyed by property name. If the entity type has bundles, the...
View ArticleBlockContentRevisionsTest should use admin account
$this->drupalGet('block/' . $loaded->id()); $this->assertNoText($loaded->body->value, 'Revision body text is not present on default version of block.'); assertNoText() doesn't make sense...
View ArticleAfter updating `FieldConfig` entities, the old configuration is still being...
Problem/MotivationWhile we were writing a test (a functional JS test, not an update path test: this is from \Drupal\Tests\media\FunctionalJavascript\CKEditorIntegrationTest::testDialogAccess()), we...
View ArticleComment Bulk Operation issue with pagination
I am doing bulk updates for comments list with pagination. I have a view to display list of unpublished comments with pagination. I am displaying 10 comments and operation is to publish the comments....
View Article