theme_menu_link isn't called on main menu and secondary menu.
When using a theme hook to alter menus, it works in blocks and other places menus may appear but not on the main menu and secondary links.Use this demonstration code in a template.php then test the...
View ArticleComplete configurations schema for Views
This is a sub-issue of #1910624: [META] Introduce and complete configuration schemas in all of core.Problem/motivation#1866610: Introduce Kwalify-inspired schema format for configuration introduced...
View Article[META] Introduce and complete configuration schemas in all of core
Problem/motivation#1866610: Introduce Kwalify-inspired schema format for configuration introduced some config schema coverage for views, contact module, image effects, etc. but it is/was not complete....
View ArticleImplement entity validation API for REST entity resources
If an entity representation (JSON-LD, XML etc.) is received and deserialized to an entity object we should make sure that the fields on the entity are valid. This has to be done on write operations...
View ArticleAreaPluginBase does not define "tokenize", but Text does.
In Text::defineOptions() the tokenize option is declared, though the form is in AreaPluginBase.Let's move the defineOptions() entry to AreaPluginBase
View ArticleRemove bootstrap_invoke_all() and related methods
bootstrap_invoke_all() is never called any more.watchdog() just uses module_implements() and relies on the bootstrap modules being loaded before it gets called, which is fragile at best given...
View ArticleChrome XSS triggered on adding iframe
In Chrome, embedded content using iframe or script fails silently on the first page view or preview after editing the page - occurs in Google Chrome 24.0.1312.57. A website editor may not see the...
View ArticleIn the status reports, add status that mod rewrite is not working properly
Not sure if this is a duplicate issue. I did a quick search and couldn't find anything.Problem/MotivationAs a administrator, the user should be notified of if mod_rewrite is not enabled. Otherwise,...
View ArticleConsolidate administrative tables into singular theme callback/component
In doing the Twig conversion, we are moving many concatenation-based theme functions into templates. Some of these are for administrative forms, which are based on tables.Most of these follow a similar...
View ArticleMore than ~4.3 billion items..
Hi,This may have been addressed already, and if it has I apologise, but I wasn't able to find a definite answer..In D7 the node ID is based around an integer field meaning it can hold a value between 0...
View ArticleDeprecate theme_item_list to use theme_ol and theme_ul
theme_item_list() came about from a developer's perspective: OL and UL markup is nearly structurally the same, so providing a single function with the type argument came about from a code efficiency...
View ArticleReplace menu node form additions with entity reference field
Now that #1801304: Add Entity reference field is in and #916388: Convert menu links into entities is Rtbc I think we should be giving consideration to using an entity reference field to replace the...
View ArticleRemove hook_exit()
We currently have 2 "end of process" integration points: hook_exit() and the kernel.terminate event.But really, we just have one. As of #1860026: Change notice: Remove hook_exit() for cached page...
View ArticleInvalid render array key in element_children() on aggregator sources page
See title, looks like we introduced that in the aggregator feed entity issue.
View ArticleTest that drupal_get_filename() has NULL return value when the file is not found
The issue Document that drupal_get_filename() has no return value if the file is not found promises expected behavior that is not verified by any test.
View Articledb_insert $options documentation.
API page: http://api.drupal.org/api/drupal/includes%21database%21database.inc/func...The docs page states:$options: An array of options to control how the query operates.How are we supposed to use this...
View ArticleMove PermissionAccessCheck to User.module
PermissionAccessCheck uses user_access() to grant access, which means it should be part of User.module, rather than core in general.
View ArticleCan not pass static method as finish callback in batch
Ex: $batch = array(); $batch['finished'] = 'HWLoader::batchFinish'; $batch['title'] = t('Loading content'); $batch['init_message'] = t('Batch Load Starting.'); $batch['error_message'] = t('Batch Load...
View Articlesearch_get_info() in search.module should include an _alter hook
For Drupal 7 and 8, search_get_info() defines the properties of each module, but there is no way to alter that.A use case for altering it is to add a conditions callback to node_search_info() when...
View ArticleRest module is limited by Request handler
The request handler does the following<?php// Invoke the operation on the resource plugin. try { $response = $resource->{$method}($id, $unserialized, $request); }?>This means that...
View Article