Deprecate Drupal\Core\Database\Connection::makeSequenceName(), make it...
Problem/MotivationThe method Drupal\Core\Database\Connection::makeSequenceName() is only used internally the PgSQL driver, but it's exposed as a public method for the entire Database API.Proposed...
View ArticleViews MysqlDateSql::getDateFormat() should translate PHP's 'o'...
Problem/MotivationWhile creating a views argument handler for year+week, I discovered that the generated SQL was not correctly converting the PHP date() format 'oW' to the proper '%x%v' MySQL...
View ArticleRemove cruft from LanguageNegotiationMethodManager
Problem/MotivationLanguageNegotiationMethodManager could call setCacheBackend() instead of initialising the properties itself. In fact it looks like the $cacheKeyPrefix is not even used so enabling...
View ArticleAllow uploading files to Media Library via Insert Link dialog
Problem/MotivationContent creators want their Drupal authoring experience to be intuitive and forgiving -- and linking to Media/files in CKEditor challenges this, because files have to be added to the...
View ArticleDuplicate declaration of $context in WidgetBase
Problem/MotivationOn WidgetBase.php (core/lib/Drupal/Core/Field), it seems there is a duplicated bloc of code:Lines 114-121 // Allow modules to alter the field multi-value widget form element. // This...
View ArticleAdd comments on why WaitTerminateTestTrait is used
Problem/MotivationIn #3375959: Add a way to delay executions in test runner until terminate event completed in the child site we introduced the Drupal\Tests\WaitTerminateTestTrait, which made waiting...
View ArticleUnused styles in Umami branding component
The Umami branding.css file does not contain any useful styles. Steps to reproduce:Remove contents of the branding.css file.Reload a page.The would be no any visual changes.All CSS rules in that file...
View Article[pp-upstream] Use PHPStan for deprecation checking
Problem/MotivationPHPstan can be used to automatically check if we use deprecated code, and avoids us to add new usages of that to core. It can also provide us with a baseline to check what deprecated...
View ArticleSupport rendering entities in page mode
We're duplicating code that could be generalized into one simple function:node_is_page($node)taxonomy_term_is_page($term)Could just be the following:/** * Returns whether the current page is the page...
View ArticleConfiguration not updating for content language after saving it
Problem/MotivationConfiguration for content language does not update even after saving it if the user adds any new element for translation and keeps the default settings for it.Steps to...
View ArticleCentralized module to control feeds and feed types
As it stands today Drupal has one type of feed; RSS feeds. If any other feeds need to be added they have to duplicate the functionality of what system.module does. You can see this in the...
View ArticleImproved the exception message in d6/FieldTypeDefaults
Problem/MotivationRunning the d6_field_formatter_settings migration, with multiples fields type (text, link, date), only date are "created". Other are "failed". The message logged is, for...
View ArticleRestrict access to empty top level administration pages
Problem/MotivationEven if a role has no Structure related permissions, the "Structure" menu item still appears in the admin toolbar. Selecting the menu takes the user to a page that simply states: "You...
View ArticleNeed to catch Peast exceptions
Problem/MotivationWe are having problems with Peast not being able to parse some of the JavaScripts generated by our theme build pipeline, causing aggregation to fail with a parsing exception (...and...
View ArticleFormatting lost when attempting to edit media within a list item in CKEditor 5
Problem/MotivationSites with Media Library and CKeditor 4 enabled that upgrade to CKeditor 5 will lose the formatting/placement of any media within an ordered or unordered list. The media becomes a...
View ArticleClik here to view.
Allow adding computed bundle fields in Views
Problem/MotivationSince #2852067: Add support for rendering computed fields to the "field" views field handler Views can render computed fields. However, this only works for computed base fields not...
View ArticleMove Direct File Upload access control to the routing layer
Problem/MotivationIn #3221796: [META] Modernise file upload logic we want to unify the file upload logic. Currently REST and JSON API do access checking directly in the controller.I think we should...
View ArticlePHP message: Error: Call to a member function getEntityTypeId() on null...
Problem/MotivationIf a default layout has a custom block placed and overridden layouts exist, deleting the custom block from the default can trigger Error: Call to a member function getEntityTypeId()...
View ArticleNodeCompleteNodeTranslationLookup should return NULL for non translated lookups
Problem/MotivationThe \Drupal\migrate_drupal\Plugin\migrate\process\NodeCompleteNodeTranslationLookup process plugin return valid values for a non translated node and it should not. This was discovered...
View ArticleClik here to view.
[policy] Evolving and documenting Drupal core's structure,...
As I talked about in the core announcement, Drupal has experienced phenomenal growth over the past 14+ years. I wanted to take an opportunity to reflect on our current governance structure and try to...
View Article