Remove entity dependency on plugins, promote EntityType to a domain object
This patch removes Entity type's dependency on Plugins among other things.I kept the annotation, but moved discovery of entity types to yaml files. It may seem like an unnecessary extra step, but the...
View ArticleConvert language_admin_overview_form to a Controller
Part of #1971384: [META] Convert page callbacks to controllersFor instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
View Article'#type' should be required in renderable arrays and should solely define the...
This is intended to be part of this meta issue #1843798: [meta] Refactor Render API.Problem/MotivationThe usage of drupal_render() is hard to understand and use, isn't used consistently throughout...
View ArticleURL Filter fails if there is an @ in the link
A url in the input that contains an @ sign is turned into a link that stops before the @.http://www.flickr.com/photos/95490987@N08/sets/72157633649215349...
View Articledrupal_container() is deprecated, don't use it in bootstrap.php
Problem/Motivationdrupal_container() is deprecated.Proposed resolutionUse the Drupal class instead.Remaining tasksIn the patch I replaced all calls to drupal_container()-get() with Drupal::service(),...
View Article[meta] Don't call theme() directly anywhere outside drupal_render()
There's a bunch of discussion around what we can do to make rendering and the theme system better.Currently there are ideas blocked simply because sometimes theme() is called inside drupal_render() and...
View ArticleAdd an EmbeddableFormInterface so that FormInterface can delegate to multiple...
Problem/MotivationThe text format configure form contains the forms of all of its filter plugins. The block entity form contains the form of its block plugin. The view entity contains the forms of its...
View ArticleFix more file permissions
Along the same lines as #1841896: Fix various file permissions, some more files have crept into the codebase with unnecessary executable bits (0755 perms). A patch to fix will follow. See also...
View ArticleRemove leftover 'module' annotation keys and plugin manager...
As said in #1780396-64: Namespaces of disabled modules are registered during test runs, removing Drupal\edit\Plugin\EditorManager::processDefinition() was forgotten in #1836008: Remove...
View ArticleRefactor Attribute classes and add drupal_pre_render_attributes
Problem/MotivationThe Attribute classes are over architected and the composition is slow for performance. Also need a way to let type's define attributes.Proposed resolutionMove logic from...
View ArticleRemove default/fallback entity form operation
Problem/MotivationWhen Entity Form Controllers were introduced, it came with the concept of a "default" form, where you could just call entity_get_form($entity), with no specified operation.This has...
View ArticleAdd hook_node_operations_alter()
hook_node_operations() is invoked from node_admin_nodes(), but there is no corresponding alter hook.
View ArticleSpeed up web tests
Tests are back at 1h-1h40, depending on the actual testbot. It used to be down to 45m-1h after the plugin discovery namespace issue was resolved.There's no obvious single big thing to point at, but I...
View ArticleStrengthen tests by not autoregistering non-test namespaces of disabled modules
During normal site operation, namespaces of disabled modules are not registered with the autoloader. This means if a module tries to instantiate a class provided by a disabled module, an error is...
View ArticleRemove dependency on datetime from node
#501428: Date and time field type in core added datetime as a hard dependency of node.module to improve the "Authored on" field.In addition to being unnecessarily tight coupling, since the testing...
View ArticleConvert filter_xss tests to unit tests
Now that filter_xss/filter_xss_admin is objectified we can start to convert these tests to PHPUnit.
View ArticleTour toggle not floating right
Looks like changes to the toolbar and this issue #1968430: Clean up css and markup for Tour module have caused the tour toggle to stop floating to the right.
View Articleduplicate in content list when nodes have translations
Follow up for #1498674: Change notice: Refactor node properties to multilingualProblem/Motivationduplicate in content list when nodes have translationsProposed resolutionupdate queries to have select...
View ArticleImplement hook_local_actions() for previously converted routes
#1908756: Change notice: Separate Action Links (MENU_LOCAL_ACTION) from hook_menu() added a new mechanism for declaring local actions. For the sake of brevity, it did not include all of the available...
View ArticleMake HISTORY_READ_LIMIT configurable
Is there a good reason HISTORY_READ_LIMIT is exactly 30 days ago? Shouldn't site administrators be able to configure this interval? I'm currently building a site where members are expected to visit...
View Article