DatabaseStorage, readMultiple throws error when receive empty array
Problem/MotivationSQLSTATE[42000]: Syntax error or access violation: 1064 is triggered when we pass empty array with name to readMultiple method, when trying to get information about setting.I hit a...
View ArticleAllow ChangedItem to skip updating the entity's "changed"...
Problem/MotivationEspecially for migrate it would be really useful to be able to copy the old changed time, for example from a note.After #2428795: Translatable entity 'changed' timestamps are not...
View ArticleThe site slogan doesn't show with Olivero
Problem/MotivationWith Olivero, if a slogan is set and the branding block is configured to show the slogan, the slogan should be displayed on the branding block. But it's not.Steps to reproduce1....
View ArticleThe position of the toolbar moves above the off-canvas top dialog if a modal...
Problem/MotivationWhile reviewing #2949991: Add workspace UI in top dialog I found a bug with the toolbar and the off-canvas dialog.The current patch updates the off_canvas_top to be able to...
View ArticleAdd input string to exception message thrown in createConnectionOptionsFromUrl()
Problem/Motivation> throw new \InvalidArgumentException('Minimum requirement: driver://host/database');This is unclear.Would be better as something like:> throw new \InvalidArgumentException("The...
View ArticleReplace DefaultTableMapping::setFieldNames() with ::add*() and ::remove*()
Problem/MotivationThis came up in #3310170: Use UUID as entity ID.DefaultTableMapping currently needs to combine a bunch of actual "business logic" which determines which field columns go in to which...
View Articlenumber_format(): Passing null to parameter #1 ($num) of type float is...
Problem/Motivation\Drupal\Core\Field\Plugin\Field\FieldFormatter\NumericFormatterBase::viewElements() calls:$this->numberFormat($item->value); Since the item may belong to a field that is not...
View ArticleGet rid of jQuery in displace event
Problem/MotivationThis is exact copy of https://www.drupal.org/project/drupal/issues/3390549 but for `drupalViewportOffsetChange` event. And utilises same deprecation logic. It also required in jquery...
View ArticleDateHelper::dayOfWeekName() returns untranslated name
Problem/MotivationComment for \Drupal\Core\Datetime\DateHelper::dayOfWeekName() says it returns translated string and it really make sense to return translation here. But in fact now it returns...
View ArticleLazy services (backed by proxy classes) lose their tags, e.g....
Problem/MotivationIf you want to override a service that advertises itself as backend_overridable, but that service happens to be lazy (with lazy: true in its definition, with a proxy class generated)...
View ArticleImprove documentation of AttachmentsInterface methods
Problem/MotivationDrupal\Core\Render\AttachmentsInterface is basically as bad as the legendary ContextInterface was "interface for context". It doesn't document what is in the $attachments array...
View ArticleAdd a '#selectall' option for checkboxes element
Problem/MotivationWith the Checkboxes element Drupal provides a super helpful form elment to show a list of checkboxes. For more complex cases, especially with several columns, there's...
View ArticleUser's image in comments overlaps with Layout Builder section
Problem/MotivationAfter posting a comments on a page, the profile image associated with the user is overlapping with Layout Builder section.Steps to reproduceMake Olivero the default theme in...
View ArticleMake translations directory configurable during install
Problem/MotivationThe translations directory locations is currently locked to $site_path . '/files/translation' during site installation (in install_check_translations()).Proposed resolutionThis...
View ArticleNavigation layout builder shows double status message
Problem/MotivationDouble messages are show to user when saving changes to Navigation Layoutnote: was first using Inline Form Error enabled. but seems like layout builders general ajax update will...
View ArticlegetProcessPlugins() should explain why it has a $process parameter and why...
Problem/MotivationgetProcessPlugins() is named, and documented, to say you call it to get process plugins.However, it has a $process parameter which is optional, but which isn't documented as being...
View Article[META] Migrate Navigation to SDC
Problem/MotivationSDC is part of core now, so we can migrate the existing code to take advantage of SDC.Proposed resolutionPlan and move all the components into their own SDCs.Remaining tasksThe plan...
View ArticleAdd Views EntityReference filter to be available for all entity reference...
Problem/Motivation#3347343: Continuation Add Views EntityReference filter to be available for all entity reference fields was getting overly complicated to get in in one issue. After discussion we...
View ArticleEmpty state is wrong for input when filled with whitespaces
Problem/MotivationThe states API check does not trim withespacesstate if input-text field is empty -> then disable submitSo empty behavior is different between PHP and States APISteps to reproduce-...
View ArticleLocate drupalisms that might create confusion among users
Problem/MotivationDrupal uses specific terminology that might not be an industry standard or might not use concepts that people can accommodate in their mental models, which confuses less experienced...
View Article