Move useful helper methods for working with entities from...
Problem/MotivationEntityKernelTestBase is a very useful test base class, as it provides a bunch of useful helper methods and does some work in setUp() which are not present in the parent class...
View ArticleImprove documentation for cookie domain in services.yml
Follow-up to #2522002: Do not strip www. from cookie domain by default because that leaks session cookies to subdomainsProblem/MotivationThese comments in he comments in default.services.yml are not...
View ArticleDrupal\file\IconMimeTypes doesn't handle NULL mimetypes
Problem/MotivationDrupal\file\IconMimeTypes cannot handle NULL value for mimetype well. Errors out pages with file references to file with NULL as the mimetype.Steps to reproduceAttempt to view or edit...
View ArticleAdd a PHPUnit assertion that an entity is valid
Problem/MotivationValidating an entity is non-trivial: $violations = $time_period->validate(); $this->assertEqual(count($violations), 0); If $violations is non-empty, you have to dump() them to...
View ArticlePHP 8.4 session.sid_length and session.sid_bits_per_character are deprecated
Problem/MotivationThe RFC https://wiki.php.net/rfc/deprecations_php_8_4#sessionsid_length_and_sess...Symfony https://github.com/symfony/symfony/pull/57805 In other words changing the default values...
View ArticleAllowed file extensions Widget Input/Display Length Problem
SummaryThere is an input/display interaction problem with the File widget edit form's "Allowed file extensions" input field.Current OperationThe "Allowed file extensions" field allows extensions to be...
View Article[META] Make Drupal 10/11 compatible with PHP 8.4
Problem/MotivationPHP 8.4 alpha1 released at July 6, 2024, feature freeze and first beta at Aug 15 2024, stable is expected November 21, 2024. Release schedule is https://wiki.php.net/todo/php84...
View ArticleLanguageManager does not check against altered language_switch_links
Problem/MotivationNULL results are being passed to array_filter function. Issue 3348686 allows for modules to provide translations for specific links using an implementation of...
View Article[dependency evaluation] Adopt vincentlanglet/twig-cs-fixer for Twig coding...
Problem/MotivationWe are using PHP_CodeSniffer for PHP coding standards, ESLint for JavaScript and Stylelint for CSS, but we have nothing for Twig templates.Steps to reproduceProposed resolutionAdopt...
View ArticleRestore documentation on variable arguments in...
Problem/MotivationIn #3029500: Drupal\Core\Database\Query\Select::hasAllTags() and hasAnyTag() will require a new "$tags" argument in the next major version of its parent class we are removing...
View Articletime_diff 'description' field not propagated to existing core...
Updated as of comment #20Problem/MotivationIn #2921810: Allow TimestampFormatter to show as a fully cacheable time difference with JS, a time diff formatting option is provided. Part of that...
View ArticlePass attributes to create_attribute in top-bar template
Problem/MotivationWhen I try to preprocess an attribute into the wrapper in top-bar.html.twig it doesn't show up.Steps to reproducefunction navigation_preprocess_top_bar(&$variables) {...
View ArticleRespect form display weights in form preview
Problem When creating a new form (through Contact Forms), the user can define the form display and view display. Both are working fine when viewing a form or a submission (using the Contact Messages...
View ArticleClik here to view.
Create contact form block
Problem/MotivationThe ability to select a contact category form is missing from the site wide contact form.To reproduce:Install standard profileAdd an additional contact categoryView /contactWhat the...
View ArticleEnabling migrate_drupal_ui via drush breaks core
Problem/MotivationEnabling migrate_drupal_ui via command lines breaks drupal.Steps to reproduce./vendor/drush/drush/drush en --yes migrate_drupal_uiLoad a random page e.g. /admin/appearance[php:notice]...
View ArticleView mode teaser for field_tags missing
Problem/MotivationI'm missing a CSS selector for field_tags in teaser mode..node--view-mode-teaser .field--tags { margin-block-start: var(--sp4); margin-block-end: var(--sp1); padding-block:...
View ArticleStop passing E_USER_ERROR to trigger_error() on PHP 8.4
Problem/MotivationRFC accepted https://wiki.php.net/rfc/deprecations_php_8_4#deprecate_passing_e_user_e...Steps to reproducecore$ git grep E_USER_ERROR core/includes/errors.inc:34: E_USER_ERROR =>...
View ArticleExecute hook_block_view_alter when placing blocks with layout builder
Problem/MotivationHook block alter does not execute for blocks that have been placed in Layout builder which means layout builder displays blocks incorrectly without their alters from contrib. Here's...
View ArticleUse one-time login link instead of user login form in BrowserTestBase tests
Problem/MotivationA test that creates a user and logs in will issue 3 HTTP requests:GET to the login formPOST to submit the login formGET to the user profile page$this->drupalLogin is called...
View ArticleAssetResolverTest should use ::willReturnMap() for mocking
Problem/Motivationphpunit/phpunit released 10.5.30. (https://github.com/sebastianbergmann/phpunit/releases/tag/10.5.30)In this release, there's a new check if willReturnOnConsecutiveCalls() has the...
View Article