Move the '✅️ PHPStan Tests' job to the lint section
Problem/MotivationFollow-up of #3464978: Make PHPStan rule testing use PHPUnit 10.it would make sense to move the '✅️ PHPStan Tests' job from the db-dependent tests into the lint section of...
View ArticleMenu link plugin for content menu links should pass entity metadata
Problem/MotivationConfigure a split content/interface language, observe menus being stuck in cache in the wrong language.Steps to reproduceProposed resolutionAdd the following to...
View ArticleAllow removing translations in pending revisions
Problem/MotivationIn #2940890: Don’t allow deleting revision translations in pending revisions we prevented users from deleting translations in pending revisions, otherwise we would not be able to...
View ArticleDocument high-level API concepts in an easier format
Problem/MotivationNot sure exactly which issue queue this should live in - seems like a core decision whether we want to do it or not, but to make it work, we'd need to figure out how things show up on...
View ArticleUncaught exception Error with message Call to a member function bundle() on...
Problem/MotivationI'm getting the error Uncaught exception 'Error' with message 'Call to a member function bundle() on string in /Drupal/Core/Entity/Plugin/Condition/EntityBundle.php:92'.I see that...
View Article[meta] Drupal modernization
Problem/MotivationDrupal has a lot of areas where we have added a new feature/API etc. which is capable of replacing something else, but that replacement has never happened, leading to two or more,...
View ArticleAdd service tag(s) for cache clearing
Problem/MotivationFollow-up from #3460598: Single directory component CSS asset library not picked up in admin theme immediately after module install without cache clear.ModuleInstaller::instal() and...
View ArticleThe theme must be passed as a query argument
Problem/MotivationAfter upgrading to 10.1.4 I see a lot of these in the log: Symfony\Component\HttpKernel\Exception\BadRequestHttpException: The theme must be passed as a query argument in...
View Article[meta] Add additional performance test coverage to core
Problem/MotivationNote: this issue was originally created for a performance testing workshop at DrupalCon Barcelona 2024.We have several performance tests in core, but some of them were added before...
View ArticleCreate a method for getting the MIME type for a file extension from a map
Problem/MotivationMimeTypeGuesser is a service for guessing the mime type of a file. It is a service collector that will chain through any services tagged with 'mime_type_guesser'.In core we only have...
View ArticleAssetControllerBase does not use file_url_generator when redirecting
Problem/MotivationWe host multiple Drupal sites from the same domain. We have a proxy that servers all assets from path /<project_name>-assets/..., and use hook_file_url_alter() to modify the...
View ArticleAggregated asset generation causes uncacheable assets
Problem/MotivationAggregated asset generation logic causes un-cacheable requests to css/jss assets. This is an issue for pages with cached html that may be linking to an old aggregated url causing lots...
View ArticleViews exposed form doesn't handle non-array values correctly, where an...
Problem/MotivationViews exposed filters allow multiple selections using the "Allow multiple selections" checkbox.This can for example be tested using a filter on a node content type, which then allows...
View ArticleAdd (more) bool return typehints to protected test helper methods
Problem/MotivationSee #3455549: Add return typehints to protected test helper methodsLooks like some bool returns were missed in #3456611: Add bool return typehints to protected test helper methods.The...
View ArticleAdd int return typehints to protected test helper methods
Problem/MotivationSee #3455549: Add return typehints to protected test helper methodsSteps to reproduceAdd this to phpcs.xml.dist<rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint">...
View ArticleThrow an understandable exception when there is an attempt to load config...
There is no validation of encoding on any of the configuration object types, which throws unhandled exception.Problem/MotivationConfiguration system handles look up of objects defined in Drupal....
View ArticleAdd assertions to OpenTelemetryNodePagePerformanceTest::testNodePageWarmCache()
Problem/MotivationNote: this issue was initially created for a performance testing workshop at DrupalCon Barcelona.OpenTelemetryNodePagePerformanceTest::testNodePageWarmCache() doesn't have assertions...
View ArticleValidate view_name in ajaxView()
Problem/MotivationSimilar to Validating String Encodings Before Insert, a malicious user tried to change an sql query by manipulating the url of an ajax call which resulted in the following...
View ArticleJSON:API assumes entity reference field's main property must be the...
Problem/MotivationThe core entity reference field does not document any requirement that the main property name on the field is the same as the value of the entity ID.However, the code in jsonapi...
View ArticleImprove links on /admin/people/roles
Problem/MotivationThis is a follow up to #393406: "Edit" links on roles admin page are confusing to users: "Edit permissions" should be the primary link. That issue has a commit and was set to 'Fixed'...
View Article
