Update EntityTypeInterface::getKeys() docs for string IDs
Problem/MotivationEntityTypeInterface::getKeys() documents that entity IDs must be numeric. This is not true, however, we explicitly support string IDs, see in particular the EntityTestStringId test...
View ArticleClik here to view.
Collapse many secondary tabs on mobile
Problem/MotivationAccording to the Claro style guide, only the primary tabs are collapsed on mobile. The secondary tabs are all displayed. However, this could become very overloaded if there are many...
View ArticleMake the nightwatch tests work with MongoDB
Problem/MotivationThe nightwatch test do not work in combination with MongoDB. The database url is a bit different compared to the existing datbase urls. MongoDB uses a replica set and the database url...
View ArticleBatch page progress bar triggers a HTTP protocol compliance failed in F5 WAF
Problem/MotivationWhen running a batch process on a Drupal site which is behind a F5 Web Application firewall, this triggers an "HTTP protocol compliance failed" violation.As stated on...
View ArticleAllow altering of the language fallback for path aliases
Problem/MotivationFollowing is the current language fallback logic used in the path.alias_repository service: // Always get the language-specific alias before the language-neutral one. // For example...
View ArticleConvert use of array() syntax in sentences
Problem/MotivationFollowup from #2874067: Fix Drupal.Commenting.DocCommentLongArraySyntax coding standard.This is to fix usages of array() in comments that are in sentences and should not be using an...
View ArticleClik here to view.
Inform users that the maintenance mode message is not displayed on cached pages
Problem/MotivationWhen site maintenance mode enabled while page cache module also enabled most visitors continue to get cached pages.Proposed resolutionAdd notice to site maintenance form when page...
View ArticleJS function Drupal.url() requires no leading slash which is inconsistent with...
Problem/MotivationStarting from Drupal 8, we started to use paths with a leading slash in Drupal, so something like this: $url = \Drupal\Core\Url::fromUserInput('some/internal-path'); will produce an...
View ArticleDeprecate comment_uri()
Problem/MotivationPart of #2010184: [meta] convert ‘uri_callback’ entities param to EntityInterface::uri() methodCurrent state: the functions is not used after #1970360-78: Entities should define URI...
View ArticleComment form should redirect to the current page when the form is in a block
Problem/MotivationComment form needs to override destination when comment form submitted on comment field attached to block content entity After submission visitor should stay on the same pageSteps to...
View ArticleRemove redirect to front page after submitting contact form
Problem/MotivationCurrently we are redirecting to <front> after a user submits the contact form. It seems like this was introduced in 744309f9 which is #2125253: Convert $form_state['redirect']...
View Article.ui-dialog-buttonpane missing on media select dialog
Problem/MotivationThe action bar at the bottom of the media insert panel has disappeared from display on my dev site, Ok on live. It's not hidden, it's just not generated. " 0 of 1 item selected...
View ArticleChange default escaping of str_getcsv() and fgetcsv() to empty string
Problem/MotivationFollow-up to #3477324-7: Fix usage of str_getcsv() and fgetcsv() for PHP 8.4Reading https://www.php.net/manual/en/function.fgetcsv.php Warning When escape is set to anything other...
View ArticlePutting / at end of domain results in error InvalidArgumentException: Source...
Problem/Motivation10.3+ sites generate error pages now if a double / is requested for example www.example.com/ works but www.example.com// generates an error. 10.2 and below the homepage would load...
View ArticleCannot delete file when using language negotiation domains
Problem/MotivationThe initial problem is that the File Listing page "Delete" link fails with "Oops, something went wrong. Check your browser's developer console for more details." when language...
View ArticleCheck term view access before trying to redirect after an update
Problem/MotivationWhen a user is editing a term, then saves the form, Drupal will send the user to the term view form.However Drupal doesn't know if the user has access to view the form. There may be...
View ArticleEnabling and prioritising interface text language detection of account...
Problem/Motivation After enabling the 'Account administration pages' setting at /admin/config/regional/language/detection, there are cases where \Drupal::routeMatch()/ return a NullRouteMatchSteps to...
View ArticleForm tokens are now rendered lazily, allow forms to opt in to be cacheable
Problem/Motivation#2559011: Ensure form tokens are marked max-age=0 made sure the form token (a CSRF token) was only set for authenticated users, and ensured it specified max-age=0.#2571995: GET forms...
View ArticleEnforce the BundleConstraint "bundle" option to be always an array
Problem/MotivationFollow up from #1845546-121: Implement validation for the TypedData APIMaybe also improve how we deal with multiple-bundle metadata here?Steps to reproduceN/AProposed resolutionSee...
View Articlestarterkit theme should use same fieldset template than stable9
Problem/Motivationstarterkit theme is using a different fieldset template than stable9 (its basetheme). Especially the fieldset template in starterkit is missing the description display before/after...
View Article