[PP-1] Move all system_update_N() methods next to each other
Problem/Motivation#3442009: OOP hooks using attributes and event dispatcher added system_update_11100() to the 11.x branch, but at a weird spot in system.install. Instead of putting it at the bottom of...
View Article[meta] Introduce PHPStan Strict Rules
Problem/MotivationThis issue resolves to discuss the introduction of PHPStan Strict Rules into Drupal.PHPStan Strict are a set of configuration chances and extra rules that encourage defensive...
View ArticlePrefer to replace some of typeof obj !== 'undefined' with optional...
Problem/MotivationSome of JavaScript checks object existence with typeof obj !== 'undefined' and checks property existence in the object. For example, it checks drupalTranslations and its property...
View ArticleResolve PHPStan-Strict errors: class.nameCase
Problem/MotivationFix a bunch of errors reported by PHPStan Strict with all rules disabled, i.e, the "miscellaneous" errors before we can consider introducing strict.Most of the things identified will...
View ArticleResolve PHPStan-Strict errors: staticMethod.nameCase
Problem/MotivationFix a bunch of errors reported by PHPStan Strict with all rules disabled, i.e, the "miscellaneous" errors before we can consider introducing strict.Most of the things identified will...
View ArticleThe 'download_translation' flag in install_state_defaults is not...
Problem/MotivationI need to disable downloading translations from the server to speed up the installation process.I use a script php ./scripts/test-site.php install --langcode de to install a minimum...
View ArticleAdjust Layout Builder permission checking for inline blocks once more...
Problem/MotivationWe currently have granular inline block permissions in Drupal, allowing to precisely set which custom block bundles can be created / edited by which user role. Unfortunately,...
View ArticleFix getExpectedUnauthorizedEntityAccessCacheability PHPStan-0 issues
Problem/MotivationPHPStan baseline is currently skipping multiple Call to an undefined method errors, #3291519: [Meta] Fix 'Call to an undefined method' PHPStan L0 errors.Proposed resolutionFix the...
View Article[meta] Resolve issues exposed by PHPStan Strict with all rules off (misc and...
Problem/MotivationIncluding PHPStan Strict as an evaluation dependency has exposed a few issues with code that deserve fixes.Rather than go through the process of including strict, lets resolve these...
View ArticleFix "call to undefined' PHPStan-0 issues in migration system
Problem/MotivationPHPStan baseline is currently skipping multiple Call to an undefined method errors in the migration systemProposed resolutionFix the errors in the...
View Article[meta] Fix return.missing PHPStan L0 errors
Problem/MotivationThere are currently 122 instances of // identifier: return.missing in the baseline.Steps to reproducegrep "// identifier: return.missing" core/.phpstan-baseline.phpProposed...
View Article[Meta] Fix method.notFound PHPStan L0 errors
Problem/MotivationPHPStan baseline is currently skipping multiple Call to an undefined method errors.Steps to reproducegrep "// identifier: method.notFound" core/.phpstan-baseline.phpProposed...
View ArticleResolve PHPStan-Strict errors: return.missing
Problem/MotivationFix a bunch of errors reported by PHPStan Strict with all rules disabled, i.e, the "miscellaneous" errors before we can consider introducing strict.Most of the things identified will...
View ArticleAjax error on views with aggregation
Problem/Motivationajax.js?v=9.5.3:448 Uncaught Drupal.AjaxError message :"\nAn AJAX HTTP error occurred.\nHTTP Result Code: 200\nDebugging information follows.\nPath:...
View ArticleResolve PHPStan-Strict errors: variable.undefined
Problem/MotivationFix a bunch of errors reported by PHPStan Strict with all rules disabled, i.e, the "miscellaneous" errors before we can consider introducing strict.Most of the things identified will...
View ArticleAdd void return type to all hook_cron implementations
Problem/MotivationSee #3483037: [META] Add return types to hook implementationsSteps to reproduceFind all occurrences in the baseline:grep "Method .*cron\\\\.* has no return type specified"...
View ArticleAllow attribute-based plugins to discover supplemental attributes from other...
Problem/MotivationCurrently, the set of properties for a particular plugin type is only defined in one place - previously the plugin type's annotation class, and now the plugin type's attribute...
View ArticleAdd void return type to all *_alter hook implementations
Problem/MotivationSee #3483037: [META] Add return types to hook implementationsSteps to reproduceFind all occurrences in the baseline:grep "Method .*\\:.*Alter\\\\.* has no return type specified"...
View ArticleAdd fallback format support to responsive images
Drupal 9.2 supports the webP image format (see change record: https://www.drupal.org/node/3171135).In order for browsers that do not support WebP (earlier versions of Safari & IE), the image needs...
View ArticleClean up MemoryCache and MemoryBackend naming issues
Problem/MotivationDrupal\Core\Cache\MemoryCache\MemoryCache is a viable cache backend that can be used as a static cache replacement on its own, or in combination with BackendChain. See #2412669:...
View Article