Fix PHPStan missingType.generics for FieldItemListInterface not specifying...
Problem/MotivationFix i$ignoreErrors[] = [ 'message' => '#^Method Drupal\\\\Core\\\\Entity\\\\ContentEntityBase\\:\\:getTranslatedField\\(\\) return type with generic interface...
View ArticleMove helpers in ajax_forms_test.module and delete it
Problem/Motivation.module files are only necessary when there are preprocess functions now that almost all hooks can be OOPSteps to reproduceOpen fileProposed resolutionMove functions from module to...
View ArticleReplace usage of dblog module at tests with alternative
Problem/MotivationThis is follow-up issue from #3496117: Remove unnecessary usage of dblog module at tests.Some tests use dblog module to check log messages, this requires database connection. In order...
View ArticleMove helpers in system_test.module and delete it
Problem/Motivation.module files are only necessary when there are preprocess functions now that almost all hooks can be OOPSteps to reproduceOpen fileProposed resolutionMove...
View ArticleIf computed view argument is empty the default value or action is not used
Problem/MotivationIf you pass an empty string as argument, the argument is applied to the view query while an argument with value NULL is not. Example: $arguments = [ 0 => '', // is processed in...
View ArticleFix Drupal.Commenting.FunctionComment.MissingReturnComment in non-tests
Problem/MotivationFix the sniff for non-tests in core, excluding core/lib/Drupal/Core/*.Steps to reproduceProposed resolutionThis adds a comment in most cases. There are a few like the following that...
View ArticleMenu Link Edit form is not saving Weight and Expanded values properly for...
Problem/MotivationClaro is adding new containers to improve the Menu Link Form user experience .These changes improves the UX and moves the form elements into different containers. However this new...
View ArticleAdd a path variant system
MotivationA requirement for experience builder outlined in #3484255: [PP-1] Support adding additional routes for view modes other than 'full' is to have alternative canonical routes, where the routes...
View ArticleFix 'Drupal.Semantics.ConstantName.ConstantStart' coding standard
Problem/MotivationPart of #2571965: [meta] Fix PHP coding standards in core.This sniff relates to Constants in the Coding Standards.Steps to reproduceProposed resolutionRemaining taskspostponed on...
View ArticleConfig translation needs to be validated on input for XSS (like other t...
Ingested t() strings are normally validated on input for XSS (as opposed to user input that's filtered on output)For example in D7:...
View ArticleClik here to view.
"To log in to this site, your browser must accept cookies from the...
Problem/MotivationThe message "To log in to this site, your browser must accept cookies from the domain" is displayed to the user when they use "Back" button and refresh the page. Steps to reproduce1....
View Articleadmin-toolbar-wrapper: Uncaught TypeError: doc.querySelector(...) is null
Problem/MotivationFor anonymous users, the javascript file admin-toolbar-wrapper.js gets loaded for some reason that I could figure out. That then issues the following error on the browser...
View ArticleError when trying to reset password of the account without email address
Problem/MotivationUsers without email address cannot use reset password when not logged in.If an anonymous user visits /user/password and enters a username of the account without email address, the...
View ArticleFormValidatorInterface::validateForm has wrong type for $form_id
Problem/MotivationFound an error in the type declaration of form_id in \Drupal\Core\Form\FormValidatorInterface::validateForm. The commit contains array but it should be string.Found this by a failing...
View ArticleProvide option to display contextual links on embedded entities
Problem/MotivationThe Media Embed filter plugin currently removes contextual links from embedded media. The code mentions:// - Contextual Links do not make sense for embedded entities; we only allow //...
View ArticleAdd array return to all *_info hook implementations
Problem/MotivationSee #3483037: [META] Add return types to hook implementationsAll info hooks should return array, except hook_config_translation_info which takes the $info param as a reference.Steps...
View ArticleAdd deprecations for update to behat/* dependencies
Problem/MotivationThis is a follow-up to add deprecations due to updating our behat/* dependencies. This was a tricky update because the dependencies introduced a lot of strict typehinting in a minor...
View ArticleFix Drupal.Commenting.FunctionComment.MissingParamType
This is a part of the attempt to fix #2572645: [Meta] Fix 'Drupal.Commenting.FunctionComment' coding standardStep 0: ReadingRead xjm's comment on the fixing type hints.This issue is created to work on...
View ArticleTry to multiple load path aliases without the preload cache
Problem/MotivationInspired by @berdir in #3340999: The path-alias preloading is not used if the "Enforce clean and canonical URLs" option is enabled.Depends on #3394423: Adopt the Revolt event loop for...
View ArticleCSRF token generation incompatible with optional route parameters
Problem/MotivationRouteProcessorCsrf::processOutbound() does not take into account optional parameters when calculating a CSRF token, leading on-request validation to fail on a generated route in which...
View Article
