Add assertions to OpenTelemetryNodePagePerformanceTest::testNodePageCoolCache()
Problem/MotivationNote: this issue was initially created for a performance testing workshop at DrupalCon Barcelona.OpenTelemetryNodePagePerformanceTest::testNodePageCoolCache() doesn't have assertions...
View ArticleDeprecate TestDiscovery test file scanning, use PHPUnit API instead
Problem/MotivationDrupal is using its own code to discover tests to be executed, which along time lead to discrepancies in the tests executed betwen PHPUnit CLI and run-tests.sh.PHPUnit 10 introduced...
View ArticleExtend PhpUnitTestDiscoveryTest to test also PHPUnit API
Problem/MotivationIn #3477634: Ensure run-tests.sh and PHPUnit CLI run with the same list of tests to be executed, we introduced a test checking equality between PHPUnit and TestDiscovery test...
View ArticleTestDiscovery expects @group annotations, fails with #[Group()] attributes
Problem/MotivationPHPUnit 10 (Feb 2023) introduced attributes to replace the annotations that were previously used to indicate test configuration to PHPUnit. PHPUnit 11 is triggering unsilenceable...
View Article[random test failure] DownloadTest::doPrivateFileTransferTest
Problem/Motivation Download (Drupal\Tests\file\Functional\Download) ✔ Public file transfer ✘ Private file transfer without page cache ┐ ├ Correctly denied access to a file when file_test sets the...
View ArticleAvoid warning from imagecreatefrompng when loading png with obscure iCCP...
Problem/MotivationWhen a PNG (and some other rarely used formats) image contains iCCP chunk with sRGB IEC61966-2.1 color profile, libpng triggers warning:Warning: imagecreatefrompng(): gd-png: libpng...
View Article[Plan] Allow for / implement simplified content workflow with workspaces
Problem/MotivationWorkspaces is built for staging and publishing changes to multiple entities at once. This concept of editing multiple entities is somewhat baked into the workspaces UI - e.g. each set...
View ArticleClik here to view.
Plural Formula gets ignored for Singular Case for languages where Singular...
Problem/MotivationPlural formula handling in PluralTranslatableMarkup::render() function ignores the Plural Formula Rule and hardcode the case for $count == 1 to use first...
View ArticleRun CSpell on all files when CSpell-related files change
Problem/MotivationAs proposed by @quietone in #3337327: CSpell dictionary is out of sync, we want to do a CSpell on all files when CSpell related files change.The place to make this happen would be in...
View ArticleAggregate 'only ancestor' libraries in their own groups
Problem/MotivationFollow-up from #734080: Set preprocess: false for jquery.min.js.One possible way to make the jquery.min.js handling generic.the core/jquery library doesn't depend on anything, but...
View ArticleSet preprocess: false for jquery.min.js
Problem/MotivationFollow up to #721400: Order JS files according to weight, don't change filenames for aggregated JS/CSS - depends on that patch. See reasoning there.Core's aggregation often results in...
View ArticleFix 'Drupal.Commenting.DocComment.ParamNotFirst' coding standard
Problem/MotivationThe sniff "Drupal.Commenting.DocComment.ParamNotFirst" is not enabled.Steps to reproduceProposed resolutionEnable the run "Drupal.Commenting.DocComment.ParamNotFirst" in...
View ArticleRemoved unused class property $translationFilesDirectory
Problem/MotivationThe property $translationFilesDirectory is defined in two test files and set in \Drupal\Core\Test\FunctionalTestSetupTrait::prepareEnvironment but it is not...
View ArticleRemove unused UnitTestCase::getConfigStorageStub()
Problem/MotivationUnitTestCase::getConfigStorageStub() sets up a stub config storage for tests, but is never used; last usage was in 2014.Steps to reproduceProposed resolutionRemove it.Remaining...
View ArticleRemove KernelTestBase::$backupStaticAttributes
Problem/Motivation /** * {@inheritdoc} * * Back up and restore static class properties that may be changed by tests. * * @see self::runTestInSeparateProcess */ protected $backupStaticAttributes = TRUE;...
View ArticleNew twig variable deprecation check should use a service and not the direct...
Problem/MotivationWhen the TwigExtension service is overridden, #3270148: Provide a mechanism for deprecation of variables used in twig templates uses the wrong class and throws an exception:The...
View ArticleAllow recipe input values in array keys
Problem/MotivationRecipe input values cannot be used in array keys. For example, something like this won't work:config: actions: node.type.${content_type}: setLabel: 'Whatever' In the name of not...
View ArticleCore interfaces can go over max_input_vars
Problem/MotivationCore interfaces can easily exceed common configurations for max_input_vars e.g. editing a menu with a lot of linksthe permissions pageSteps to reproduceSet max_input_vars to a low...
View Articleexample recipe.yml has invalid comment above "actions" section
The path to the file: web/core/recipes/example/recipe.ymlBelow is a code snippet, with the invalid comment highlighted in bold:# Configuration actions may be defined. The structure here should be #...
View ArticleImporting blocks with module settings inside a recipe (via ddev recipe-apply)...
Problem/MotivationWhen trying to import a block containing Social Media Links settings, applying the recipe (via ddev recipe-apply) failed:In RecipeConfigInstaller.php line 70: There were validation...
View Article