Replace drupal_container() with Drupal::service() in the locale module
drupal_container() is deprecated, and all calls in the locale module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced...
View ArticleReplace drupal_container() with Drupal::service() in the menu & menu_link...
drupal_container() is deprecated, and all calls in the menu & menu_link modules module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which...
View ArticleReplace drupal_container() with Drupal::service() in the overlay module
drupal_container() is deprecated, and all calls in the overlay module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced...
View ArticleReplace drupal_container() with Drupal::service() in the path module
drupal_container() is deprecated, and all calls in the path module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with...
View ArticleReplace drupal_container() with Drupal::service() in the rest module
drupal_container() is deprecated, and all calls in the rest module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with...
View ArticleReplace drupal_container() with Drupal::service() in the search module
drupal_container() is deprecated, and all calls in the search module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced...
View Articletheme_disable() can disable the wrong theme
While writing an update function for a Drupal distribution I found that calling theme_disable() on a list of themes caused unexpected results.The update function should disable every theme except for...
View ArticleFix verb tense in update function summaries
Noticed in #1833022-165: Only display interface language detection options to customize more granularityProblem/Motivationhttps://drupal.org/node/1354Update functions (implementations of...
View ArticleAllow access methods on controllers to be used in routes
Currently, in (and in the conversion issues) new access checkers are being added for the purpose of one route, this seems OTT as it is registered an iterated over for EVERY ROUTE when the route info is...
View ArticleFix line indent in dashboard.js
I found a little coding standard bug in dashboard.js: the line indent is wrong in:/** * Implements Drupal.behaviors for the Dashboard module. */Drupal.behaviors.dashboard = {Â Â Â attach: function...
View ArticleSQLite doesn't support RIGHT JOINs
Even the latest versions of SQLite do not support RIGHT JOIN (changelog), so the query needs to be folded to a RIGHT JOIN. Otherwise we had to remove RIGHT JOIN support from our generic DB driver....
View Articlemarkup for page.html.twig + maintanence-page.html.twig
The markup we have right now for page.html.twig is not optimal (<footer id="footer">... just to pick one ) I have cleaned page & maintainence page up a bit but it do indeed raise som concerns...
View ArticleUser notification system breaks on a simple & reasonable form_alter
This is a minor issue but it boggled my mind for a bit.I noticed on my site that when users registered at /user/register they got the email intended for users created by an administrator. This was...
View ArticlePages load really slow
After upgrading from 7.21 my edit tabs, or any page takes really long to load.
View ArticleTaxonomy vocabulary interface test assumes auto-increment increment of 1
The TaxonomyVocabularyFunctionalTest class assumes that the auto-increment increment will be 1 and tests fail when it is not.
View ArticleTrigger content (node) actions test assumes auto-increment increment of 1
The Trigger content (node) actions test fails when the auto-increment increment is any value other than 1 or when the auto-increment offset is not 0.
View ArticleChange structure of REST config
bshaffer hit a DX issue when testing REST. He tested it without custom config, and JSON worked. Then he added hal_json: TRUE and the JSON stopped working. This is by design, but it does seem like a DX...
View ArticleTitles are often double-escaped
In various places, titles are double-escaped, such as with check_plain(). For example, if the title is "Liam's Test", it gets escaped to Liam's Test (which is what should happen before...
View ArticleRaw::get_argument() calls dead drupal_get_path_alias()
https://api.drupal.org/api/drupal/core%21modules%21views%21lib%21Drupal%...
View ArticleUndefined index: view modes in field_view_mode_settings()
When I save the module admin page I get this: Notice: Undefined index: view modes in field_view_mode_settings() (line 627 of /home/www2/drupal-7.16/modules/field/field.module). Warning: Invalid...
View Article