Rewrite the node preview functionality on top of workspaces
Problem/MotivationThe node preview system in Drupal 8 was written as a stop-gap solution with known deficiencies and hope that some day a more robust solution will eventually take its place.Proposed...
View ArticleConvert experimental_module_requirements_test_requirements to new Class
Problem/MotivationThere was a failure when converting install time hooks so I moved converting that to this issue.Steps to reproduceConvert experimental_module_requirements_test_requirements to...
View ArticleClean up getViewsData() in NodeViewsData
Problem/MotivationThe file NodeViewsData.php, which implements a single function, getViewsData() should be a model of good organization and well documented.This function returns an array with the...
View ArticleClean up todo in InlineBlockEntityOperations::handleEntityDelete() and use...
Problem/Motivationfunction foo_entity_delete(EntityInterface $entity) { $context = EntityContext::fromEntity($entity); } This will fail.Introduced in #2791269: Allow saving pre-existing references to...
View ArticleClik here to view.
Move "Title field label" setting to "Manage Fields" tab
Where do you go to change the lablels on all the fields on your node form? Well, for every single field except one, you go to the "Manage fields" tab for your content type. I know title is special, but...
View ArticleDeprecate NodePreviewController::title
Problem/MotivationIn #2691675: Replace deprecated entityManager() in ControllerBase descendents, we noticed that NodePreviewController::title() is not called once in our tests, despite actually being...
View Article[PP-2] Allow edit of bundle plural labels in the node type form
This is a follow-up and is postponed on #2765065: [PP-1] Allow plurals on bundle labels.Problem/MotivationStarting with #2765065: [PP-1] Allow plurals on bundle labels, bundle config entities are able...
View ArticleClik here to view.
With Android, when the keyboard drawer is open the viewport causes the...
The widescreen media query used in the node.module.css for widescreens catches mobile Android when the keyboard drawer is open.This was with my Pixel 3 device. I don't have another device around to...
View ArticleNode access default grant behavior is not clear
Problem/MotivationFollowup from #2461049: Node module permissions are broken if hook_node_grants is implemented.The node grant/access record system has a behavior where if no hook_node_grant()...
View Articlemaintenance-page--offline.html.twig is not picked up when system is offline
Problem/MotivationIn system_theme_suggestions_maintenance_page(), a template suggestion is provided for maintenance-page--offline.html.twig:if ($offline) { $suggestions[] = 'maintenance_page__offline';...
View Article'edit/delete any content' permissions do not imply 'view...
In some situations, users granted the 'edit any content' and/or 'delete any content' permission(s) are not able to view the nodes they can edit or delete. This is most apparent when considering...
View ArticleReplace valid-jsdoc rule with eslint-plugin-jsdoc for eslint
Problem/MotivationDrupal's ESLint configuration, which contrib projects are also encouraged to use, uses the valid-jsdoc rule, which has been deprecated.The ESLint team recommends using...
View ArticleDocument the correct replacement for 'priority' from...
Now that we have hook_mode_access_records_alter(), the 'priority' element in http://api.drupal.org/api/function/hook_node_access_records/7 is just a dangerous remnant of the old API.Best to remove it...
View ArticleClik here to view.
Bring back overriding breadcrumb with contextual filter
In Drupal 7, it was possible to override breadcrumb by a contextual filter. That feature is missing in Drupal 8. Maybe in Drupal 9 too, but I am yet to try Drupal 9.Not sure any resolution happened...
View ArticleOptimize node_tag_new()
node_tag_new() currently does a merge query on every authenticated page view, to update the {history} table.afaik history is used for only three purposes:1. To determine if a node is 'new' for that...
View Article(Tests needed) Removal of Identification fieldset
The new standard in Drupal core is to avoid using field set if there is only one present or when it is the main interaction. Here the same applies because, there are vertical tabs but the actual...
View ArticleRename node_access_write_grants() to _node_access_write_grants() and...
http://api.drupal.org/api/function/node_access_write_grants says Modules which utilize node_access can use this function when doing mass updates due to widespread permission changes. So, apparently,...
View Articledocumentation in CronInterface is out of date and incomplete
Problem/MotivationDocs in CronInterface say: * Do not call this function from a test. Use $this->cronRun() instead. First, this is incomplete -- what is $this representing here? There is no...
View Article[random test failure]...
Problem/MotivationSee #3351494: Skip Drupal\Tests\media\FunctionalJavascript\MediaSourceFileTest we need to fix the test before it can be re-enabled.Steps to reproduceProposed resolutionRemaining...
View ArticleHardcoded usage of compact view mode in template_preprocess_node() and...
Problem/Motivationif (theme_get_setting('features.node_user_picture')) { // To change user picture settings (e.g. image style), edit the 'compact' // view mode on the User entity. Note that the...
View Article
