Using CacheableResponseInterface to better determine which responses should...
Problem/MotivationBlocked on #2463009: Introduce CacheableResponseInterface: consolidate ways of setting X-Drupal-Cache-Tags/Contexts headers.Quoting Fabianx in #2463009-12: Introduce...
View ArticleUnused use statements in \Drupal\block_content\BlockContentTypeForm
Problem/MotivationProposed resolutionRemaining tasksRemove use statementsComplete issue summaryAdd beta evalUser interface changesAPI changesData model changes
View ArticleEnable ENT_SUBSTITUTE in check_plain
PHP 5.4 introduces a new flag to htmlentities()"which makes htmlentities()/htmlspecialchars() replace the invalid multibyte sequences with U+FFFD (UTF-8) or � (other encodings).In a nutshell,...
View Article[meta] Remove or document every SafeMarkup::set() call
Follow-up to #1825952: Turn on twig autoescape by defaultProblem/MotivationSafeMarkup::set() is mostly for internal use only. For the most part, existing APIs like t(), String::checkPlain(),...
View ArticleRemove unnecessary SafeMarkup usage in tests and clear the static cache...
Follow-up to #2549943: [plan] Remove as much of the SafeMarkup class's methods as possibleProblem/MotivationSafeMarkup is a static that bleeds between PHPUnit tests we should reset it in...
View ArticleBurn entity_reference.module and scatter its ashes all over core
Problem/MotivationThe split between Drupal\Core\Field\Plugin\Field\FieldType\EntityReferenceItem and Drupal\entity_reference\ConfigurableEntityReferenceItem never made too much sense. Now even less so...
View ArticleAdd option to Url() to force the site base_url to be used
Problem/MotivationThere are a few situations in core where links are generated when the system is running outside of the primary front controller or from a special route. These...
View ArticleBlock position not saved when below the first block of another region
Problem/MotivationWhen moving a block to a new region and placing the block in any place other than directly below the region name, the block's position doesn't save. Repositioning the block within...
View ArticleDo not use SafeMarkup::format in exceptions, trigger_error, and debug (the...
Follow-up to #2514044: Do not use SafeMarkup::format in exceptionsProblem/MotivationWe are escaping exception messages when we are creating exceptions. If the exception message is never displayed or...
View ArticleReplace direct access to FieldConfigBase::default_value with methods
Follow-up to #2030637: Expand FieldConfig/BaseFieldOverride/FieldConfigBase with methodsPart of meta-issue #2016679: [Meta] Expand Entity Type interfaces to provide methods, protect the...
View ArticleInclude theme print stylesheets in Book printer friendly export
Problem/MotivationBook module renders export pages with custom page template that should contain "print.css" but this broken because asset hardcoded relatively to current page. Also there's no way to...
View ArticleMove system action-links.theme.css, breadcrumb.theme.css, and...
Problem/MotivationSee: #2489460: [Meta] Move module.theme.css files to ClassyProposed resolutionMove the CSS files to classy Rename the files to remove the .theme. extension Alter the system.base...
View ArticleZero value not shown in views table style
1. Create a content type with an integer field 2. Create a node of this type with field value 0 (zero) 3. Create a view for this content type, with fields "Title" and the integer field 4. Set the...
View ArticleAggregator feed overview misleading text
At admin/config/services/aggregator , the Next update is "Never" when it's not yet updated, but scheduled, which is misleading. Here's a patch with test.
View ArticlePATCH on user not working properly
PATCH on user to change the user name works fine. But to change password and email it requires to specify current_password. I tried to get help on how to pass this value but no response . So I read...
View Articleopenssl_random_pseudo_bytes() is broken on PHP < 5.6.12, 5.5.28, 5.4.44
Problem/MotivationDrupal prefers openssl_random_pseudo_bytes() if available in Cryp::randomBytes() in 8.0.x or drupal_random_bytes() in 7.x and 6.x.PHP used the wrong method in the openssl library now...
View ArticleMissing caption, if view (format table) is grouped by a field
I have tested the functionality of table grouping and found this bug (or missing feature ?)Create a view Format: table Add some fields Check "Exclude from Display" for one field (i.e. Field1) View...
View ArticleVertical tabs shifted in node type form
When I set up Bartik to be the administration theme the vertical tabs in the content type form appear shifted to the right. This seems to be a similar issue as #2003766: Vertical tabs styling is pushed...
View Articlehook_views_post_render fails in a theme
Problem/MotivationAccording to views.api documentation the use of hook_views_post_render is:function hook_views_post_render(ViewExecutable $view, &$output, CacheBackendInterface $cache) {In a...
View ArticleDebugging test child sites does not work anymore due to to using the request...
Problem/MotivationWebTestBase uses the cookies from the request object. But we create that from scratch in test setup, it never contains those cookies anymore.Proposed resolutionGo back to using using...
View Article