Use local tasks derivatives to provide local tasks for views
Instead of using hook_menu() views should use the local tasks plugins provided by #2004334: Separate Tabs (MENU_LOCAL_TASK) from hook_menu()
View ArticleLoad all routes for local tasks via getRoutesByNames()
Instead of loading each local task route object manually it would be possible to just load all of them parallel.
View ArticleRemove 'image' and 'link' plugins from bundled CKEditor build
#1879120: Use Drupal-specific image and link plugins — use core dialogs rather than CKEditor dialogs, containing alterable Drupal forms added custom, Drupal-optimized "image" and "link" plugins for...
View ArticleUpgrade of disabled modules broken - no way to use name-space discovery
Get this bug while working on upgrade path for #731724: Convert comment settings into a field to make them work with CMI and non-node entities see #1907960-304: Helper issue for "Comment field" test...
View ArticleLimit APIs to FieldDefinitionInterface when FieldInstance isn't needed
Follow up from #1950632: Needs change notice: Create a FieldDefinitionInterface and use it for formatters and widgets. If code isn't specifically working with configuring Field API fields and instances...
View ArticleWebTestBase::randomString returning a string containing a $ followed by a...
Follow-up of #2004408: Allow modules to alter the result of EntityListController::getOperations and #2020209: Random failures due to non uniqueness of randomString() and randomName()There are still...
View ArticleFigure out how to deal with 'title/title callback'
Problem/MotivationAs seen on #1974408: Convert aggregator_page_source() to a Controller, routes defined via the route system does not have yet the concept of titles. Titles are not only needed for menu...
View ArticleClean up API docs for core/includes
Part of meta-issue #1310084: [meta] API documentation cleanup sprintI assume that we are now in code cleanup phase. I use PhpStorm to find possible bugs and problems in the Drupal 8 core. Normally I...
View ArticleRequest account is not available during web tests
#1890878: Add modular authentication system, including Http Basic; deprecate global $user replaced global $user by \Drupal::request()->attributes->get('account'). However, this attribute is not...
View ArticleDraggable rows in RTL language
Draggable rows nesting (dragging right to inset, left to outset) does not work in the opposite way in RTL languages. It should switch to dragging left to inset, right to outset.
View ArticleClear menu_router code out of function menu_local_tasks() when all actions...
follow-up to #2004334: Separate Tabs (MENU_LOCAL_TASK) from hook_menu()function menu_local_tasks() should be reduced to interacting with the plugin managers and invoking a couple hooks.+Â Â Â // @todo...
View ArticleAdd ConfigStorageController::mapFromStorageRecord()
Problem/MotivationConfigStorageController feeds config data directly into entities without mapping them first.Proposed resolutionAdd ConfigStorageController::mapFromStorageRecord().API changesNo BC...
View ArticleReplace calls to theme('item_list') with calls to theme('links') for links,...
Problem/MotivationWe have two very similar functions in Durpal theme_links and theme_item_list. Both of these functions loop through a set of items, and create a HTML list. This creates twice as much...
View ArticleTesting suddenly doesn't work anymore
While developing a test, I re-ran it a number of times on a clean D8 installation. Whenever a PHP error was raised, I reloaded the page in the browser, and sometimes had to reenable the specific test...
View ArticleRemove views_view_summary.html.twig, call use item-list.html.twig instead
Problem/MotivationWe have two identical templates in core, views_view_summary.html.twig and item_list.html.twig. There's no reason for two. More code to maintain, and less consistent markup.Proposed...
View ArticlePreserve taxonomy_forums field when uninstalling forum module
Problem/MotivationCurrently forum module trying to delete taxonomy_forums field in forum_uninstall() but this field could be used in other entities. Also forum node type is not deleted when forum...
View ArticleCatch exceptions thrown by ArchiveTar when importing configuration
The following steps end up in an error page:1. Open admin/config/development/import 2. Choose a file that is not a *.tar file. 3. Hit upload.The following error is thrown:Exception: Invalid checksum...
View ArticleCreate a TextWidgetBase
#1758622: Provide the options list of an entity field adds some more redundancies in TextareaWidget and TextfieldWidget, therefore the creation of a TextWidgetBase was proposed.There is also quite some...
View ArticleClik here to view.
Use Libricons (icon font) in Seven, consider using it more broadly in core
Problem/MotivationThe Seven Style Guide used a commercial icon font as a placeholder in its design. There seem to be no GPL-compatible icon fonts out there. So I made one:...
View ArticleStack depth limit exceeded in search_update_totals() during cron run
I have made custom module to generate hundreds or thousands of nodes (using Batch API) to test various loads.After deleting 10000 nodes (again with custom Batch) I have noticed some errors in watchdog...
View Article