theme_tableselect() #options iteration
API page: https://api.drupal.org/api/drupal/includes%21form.inc/function/theme_tab...Enter a descriptive title (above) relating to function theme_tableselect, then describe the problem you have...
View ArticleClarify library_id vs module name confusion in hook_library_info_build code...
Problem/MotivationWhen trying to implement hook_library_info_build I uncovered some confusion caused partly by the documentation provided in hook_library_info_build. It seems that libraries are...
View ArticleClik here to view.
Many places use $v = &$form_state->getValue(…), but also many use $v =...
Problem/MotivationIt seems that there are several places where we have $v = &$form_state->getValue(…); but also many use $v = $form_state->getValue(…);Proposed resolutionWe need to determine...
View ArticleRemove leftover isset() in ViewExecutable
in #2409209: Replace all _url() calls beside the one in _l() the parameters of ViewExecutable::getUrl() changed to no longer include $path, there is however still a check on isset($path), which will...
View ArticleSimple decimals fail to pass validation
Problem/Motivation- Create decimal field, set precision to 10 (minimum in the UI and scale to 4 - Saving new node with value 19999.0000 succeeds (precision is 5+4 = 9). - Saving new node with value...
View Articleedit-form, delete-form etc. <link> tags added on /node/{node} are...
Problem/MotivationNodeViewController adds all uri relationships it can find as <link>. But according to http://validator.w3.org/, that is not actually valid.Also, those links are printed for all...
View ArticleMax dimensions do not apply to Editor Inline image
In core/modules/editor/src/Form/EditorImageDialog.php,The setting of maximum dimension of inline-image do not obtain correctly.When set the dimension limit of inline-image to be 400x300 for basic html...
View ArticleStaging directory should not have to be writeable.
Problem/MotivationOne common way of using config will be:Site Builder A: Export files to a directoryServer: Import the exported files from that directoryAs we see, the webserver never needs the staging...
View ArticleNode revision queries tagged for node access cause "no node table"...
Note: I don't have time at the moment to isolate all the variables in this report, but I want to get something out there and throw a patch at the testbot. In the meantime, here's what (I think) I...
View ArticleMove roles and permissions under admin/structure
Problem/MotivationI'm opening this because it confuses me, I don't yet have evidence that it confuses anyone else.admin/content has a list of node content, then tabs with lists of comments and files...
View ArticleRegister the new entity revision param enhancer/converter as services
See #2666798-25: Add a entity revision parameter converter & route enhancer. Classic unit test fail and nobody spotted it, including myself.
View ArticleAdd a libraries folder with a README.txt in it to DRUPAL_ROOT
The addition of a /libraries folder (like /modules and /themes) for the purpose of contrib. and project specific custom modules to place shareable javascript or css libraries that should not be...
View Articlehook_element_info_alter() does not always get invoked in themes
Problem/Motivationdrupal_alter() gets invoked in themes regardless of the hook. Thus themes can implement such as hook_element_info_alter(). The popular Omega theme uses that to provide a scripts...
View Articlemodule_implements() cache can be polluted by module_invoke_all() being called...
Problem/Motivationthere seem to be several cases where the module_implements() cache is polluted with incomplete info:any hook being invoked from within a hook_boot() -- as described by Jose Reyero in...
View ArticleDiscuss implications for broken builds/packaging if packagist/github has issues
Problem/MotivationThis was brought up on the original /vendor issue early on, but didn't really get much discussion as it got closer to commit. I was reminded of it by...
View ArticleBlock demo page shows the wrong theme to unprivileged users
Problem/MotivationOn a fresh installation of Drupal 8, go to admin/structure/block/demo/seven as an unprivileged/anonymous user. The "access denied" page you get to is shown in the Seven theme, rather...
View ArticleClik here to view.
Select form element looks un-styled on Firefox
Previously discovered in https://www.drupal.org/node/2524284 - the select list form element on Firefox looks un-styled or ugly / dated.To see it in action in Bartik:Create a new content e.g. basic...
View ArticleAjax doesn't work with Tableselect with checkboxes
I have been finding out many users who are having trouble with running #ajax with tableselect, and it seems the problem is specifically when one uses checkboxes.When a tableselect is created with...
View ArticleCSS for draggable icons needs tweaking
I'm only seeing the upper left quadrant of the 4-arrow drag icon.I made the following changes to the CSS to fix it:.draggable a.tabledrag-handle { width: 2.5em; }a.tabledrag-handle .handle { height:...
View Article