NodeController::revisionOverview() shows no revisions if node has no...
Problem/MotivationThere were a lot of optimizations for node revisions and translations shortly before 8.0. However, they caused a regression when trying to view revisions of a node that is not...
View ArticleInstead of mocking TypedDataManager, use TypedDataManagerInterface in tests
Problem/MotivationBefore #2488568: Add a TypedDataManagerInterface and use it for typed parameters, it was not possible to create a test class that implements the interface but instead creation of a...
View ArticleImprove entity bundle info return value docs and consolidate them in one place
EntityBundleInfo->bundleInfo does not document the internal structure of the bundle info array. After #2712367: Extend EntityTypeBundleInfoInterface's docblocks and make them more explicit has been...
View ArticleAdd assert helper functions for Drupal messages to WebTestBase.
That might be implemented as follows:assertStatusMessage($text); assertWarningMessage($text); assertErrorMessage($text); assertNoErrorMessages();
View ArticleUnify PHP visibility for all test methods
At the moment most of the test methods are public.#!/usr/bin/env bash echo -n 'Public methods: ' grep -r '^ *public function test[A-Z]' . | wc -l echo -n 'Public methods (PHP4 style): ' grep -r '^...
View ArticleWarning: touch(): Utime failed
Warning: touch(): Utime failed: Operation not permitted in Drupal\Component\PhpStorage\MTimeProtectedFastFileStorage->save() (line 98 of...
View ArticleFix 'Drupal.Commenting.FunctionComment' coding standard - Issues...
This is a part of the attempt to fix #2572645: [plan] Fix 'Drupal.Commenting.FunctionComment' coding standard. This issue is created to tackle issues related to @see referencesThe following sub-sniffs...
View ArticleCan't find views default_argument 'date'
I'm marking this a support request because I can't believe its a bug which hasn't been reported. Nonetheless: In Drupal\views\Plugin\views\argument\Date: public function defaultArgumentForm(&$form,...
View Article[plan] Fix 'Drupal.Commenting.FunctionComment' coding standard
Part of #2571965: [meta] Fix coding standards in core.ApproachWe are testing coding standards with PHP CodeSniffer, using the Drupal coding standards from the Coder module. Both of these packages are...
View ArticleImplement ContainerAwareEventDispatcher::getListenerPriority()
When we updated to Symfony 2.8 in #2611816: Update to symfony 2.8 we didn't implement the getListenerPriority() method on ContainerAwareEventDispatcher, probably because it was not required on the...
View ArticleClik here to view.
"Update Notifications" #title repeated for drupal 8 installation in...
Problem/MotivationI tried to find out any issue in drupal installation, I got "Update Notifications" repeated in "Configure site" for the following section (image attached)Proposed resolutionI am not...
View ArticleBad dates in Select List widget throw an exception
When the Select List widget is used for date fields, it's possible to enter a value like February 31. This causes DateTimePlus to throw an exception in the datetime value callback, even before...
View ArticlePath Alias test fails on php-fpm
The Path Alias Functionality test fails with php-fpm. I see 2 fails running with run-tests.sh and just one running using the web UI. "Value NULL is TRUE."There aren't any easy clues to what's going on...
View ArticlePart 2: Fix several errors in the 'Drupal.Commenting.DocComment'...
Follow-up to #2707371: Fix several errors in the 'Drupal.Commenting.DocComment' coding standardProblem/MotivationLet's fix drupal/coder's sniffs in core.This issue continues fixing...
View ArticleSyntax errors (un-quoted or mis-quoted strings) in various code examples in docs
API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Rend...The examples given for the method described in that page are the following. // Secure (with quotes):...
View ArticleNeed for a hook_image_path_flush
Problem/MotivationModules like adaptive_image have no way of reacting to image_path_flush();Proposed resolutionI propose adding an extra hook at the end of image_path_flush(), like this:...
View ArticleCannot deploy book nodes - book metatdata not serialized
Problem/MotivationThe serialized representation of a book node doesn't contain the book metadata. This means on deserializing the book information is lost.Proposed resolutionAdd a normlizer for book...
View Articlemore detail needed for hook_theme() 'variables' property
API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...Currently says:variables: Only used for #theme in render array: an array of variables, where the array keys are the...
View ArticleFix 'Drupal.Semantics.ConstantName.ConstantStart' coding standard
Part of #2571965: [meta] Fix coding standards in core.ApproachWe are testing coding standards with PHP CodeSniffer, using the Drupal coding standards from the Coder module. Both of these packages are...
View ArticleUpdate search module's PREG_CLASS_NUMBERS, PREG_CLASS_PUNCTUATION,...
Problem/MotivationFollow-up to #2714815: Fix 'Drupal.Semantics.ConstantName.ConstantStart' coding standardChild of #2571965: [meta] Fix coding standards in...
View Article