Fix 'Drupal.Commenting.InlineComment.InvalidEndChar' coding standard
Follow-up to #2572659: Fix 'Drupal.Commenting.InlineComment.SpacingAfter' coding standardPart of #2571965: [meta] Fix coding standards in core.ApproachWe are testing coding standards with PHP...
View ArticleBlockInterface::BLOCK_REGION_NONE is integer, Block::$region is string
Problem/MotivationBlockInterface::BLOCK_REGION_NONE is an integer, while Block::$region is a string.One problem this causes is when checking whether a block's region is BLOCK_REGION_NONE, as happens...
View ArticleClik here to view.
contextual-toolbar-tab
Editor seems to use the class 'contextual-toolbar-tab' on it's 'toolbar-tab' in-order assign float:right. Work on #2724819: Create experimental module for place block on any page feature also tried to...
View ArticleNewline character in HtmlTag causes unwanted whitespace
A '\n' (newline) character is included at the end of every tag output by theme_html_tag(). This causes extra whitespace that may not always be desired. One specific example is for use with sprite icons...
View ArticleClik here to view.
Remove user.icons.theme from core CSS
Problem/MotivationSee: #2489460: [Meta] Move user.icons.theme to ClassyProposed resolutionMove the CSS file to Seven. Create a library for the CSS file. Add the library in the seven twig...
View ArticleClik here to view.
Single on/off checkboxes should "Use field label" by default
Beta phase evaluationReference: https://www.drupal.org/core/beta-changesIssue categoryFeature requestIssue priorityNormalPrioritized changesUsability and sites builder experience...
View ArticleBoolean default values are not saved
Views is not remembering default values for exposed filters. Steps to reproduce:1. Create a view to list nodes. 2. Create an exposed filter on the Published field, make it non required and select a...
View ArticleClik here to view.
A valid one-time login link may be leaked by the referer header to 3rd parties
Problem/MotivationWhen accessing a one-time login link the referrer header for any third party assets will leak the link and if the user does not click the log in link it will be valid for the next 24...
View ArticleInvalid passwords after D7 to D8 migration
Problem/MotivationAfter running the user migration from D7 to D8 all user passwords seems invalid, e.g. It's impossible to login in D8. I noticed this today because of #2560637: Improve handling of uid...
View ArticleClik here to view.
Create experimental module for place block on any page feature
Problem/MotivationAs a site builder, I would like to be able to place a block from any page and intuitively see where it will display Proposed resolutionCreate an experimental module that adds a...
View ArticleImplement ContainerAwareEventDispatcher::getListenerPriority()
When we updated to Symfony 2.8 in #2611816: Update to symfony 2.8 we didn't implement the getListenerPriority() method on ContainerAwareEventDispatcher, probably because it was not required on the...
View ArticleParameters to ModuleHandler::invoke() are incorrect
API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Extension...> ...: Arguments to pass to the hook implementation.That's a relic of D7.This now takes a single $args parameter,...
View ArticleUpgrade path between revisionable / non-revisionable entities.
Problem/MotivationIn #2705389: All content entities should extend RevisionableContentEntityBase we want to enable revisions everywhere. But in order for this to be committed in 8.x we need a data...
View ArticleClik here to view.
Seven theme: style CKEditor, legend tag has absolute position
Needs to be set to relative or removed. After adding Find and Replace plugin for ckEdityor, 'Find Options' covers the search options in dialog box. In the form.css position is set to absolute.
View Articleadd a method to ContentEntityBase for getting its Bundle entity
Given an entity such as a $node, I have to do this to get the bundle entity: $node_type = entity_load($node->getEntityType()->getBundleEntityType(), $node->bundle()); Could we add a method to...
View ArticleSerialize file content (base64) to support REST GET/POST/PATCH on file entity
Problem/MotivationFile entities and file/image fields do not currently work with the new REST GET/POST/PATCH/PUT operations.Proposed resolutionThe plan is to include file contents in base64-encoded...
View ArticleAllow for peaceful requeueing
Problem/MotivationI have a long running queue worker and the current system doesn't have a way for queue workers to signal "I am not done yet".Proposed resolutionAllow non-error releaseing an...
View ArticleCaches / Configuration translations not rebuilt properly when rebuilt is not...
Configuration translations are lost, it looks like caches are not rebuilt properly when triggering the "Clear all caches" process from an admin page that is not in the default language. Steps to...
View ArticleEditorImageDialog: allow the list of allowed file extensions to be configured
In the EditorImageDialog, buildFom(), list of valid file extensions are hardcoded and limited to: gif, png, jpg, and jpeg.'file_validate_extensions' => array('gif png jpg jpeg'), Just like 'Maximum...
View Article