Add new tests for testing themes and subthemes engine inheritance
Hi,As requested by Fabianx on IRC and on the related issue #1545964: [PP-2] Do not copy over the owner and engine of a theme if the child theme uses a different engine than the base theme, here's a...
View ArticleThe name query parameter to UserPasswordForm can result in lots of cache entries
In https://security.drupal.org/node/161566, which was released in https://www.drupal.org/SA-CORE-2016-005, a cache context was added to the "name" query parameter on the password reset form. @catch...
View ArticleAllow opt-out of password hashing during user migrate
During users migration, password re-hashing slows down the process with a factor of multitudes. That's just how it is. For sites with less users, this might not be a big problem, But in my use case,...
View ArticleNot every entity has canonical path
I was testing D8.2.2 REST API with Commerce 2-beta3.When I simply GET a Commerce Order, I receive an error in the Drupal log:Symfony\Component\Routing\Exception\RouteNotFoundException: Route...
View ArticleAdd hook_requirements() for PECL YAML parser
#1920902: Add a Drupal Yaml wrapper so we can default to PECL Yaml component if it is available.Need to:1. Tell people what's installed.2. Potentially suggest the PECL parser if it's not...
View ArticleUpdate Symfony components to ~3.1
Problem/MotivationSymfony 3 is here, we decided to adopt it for Drupal 8 in #2395443: [policy, no patch] Follow symfony 2.7 or 3.0., this is the question.Proposed resolutionPrepare Drupal core to use...
View ArticleImageItem normalizer should expose all public image style URLs
Problem/MotivationThis is a sister issue of #2517030: Add a URL formatter for the image field and #2825487: Add FileNormalizer: the File entity should expose the file URL. The former issue solved it...
View ArticleSymfony YAML parser fails on some strings when running PHP 7
Since PHP 7 the preg engine uses a just in time compiler. This one can cause strange issues:https://bugs.php.net/bug.php?id=70110When a YAML file contains a value that consists of a lot of newlines,...
View ArticleOPTIONS request for CORS get cached
Problem/MotivationI was working with REST on D8 and enabled cors.config in services.yml (see configuration below). What i noticed that the Options request get cached with the result of the GET request...
View ArticleCreate a KTB for migrate's process plugins
Problem/MotivationBased on numerous reasons, but more recently motivated by #2767643: [PP-2] Scalar to array migration returns NULL , we need more solid test coverage for process plugins. Let's do that...
View ArticleDuplicate Label field (on form) when adding field
As I was adding a field to a content type, I ended up with two Label field text inputs on the form (see screenshot). It took me a while to figure out the steps to reproduce it, but finally hit on...
View ArticleAdd configuration sync validation
Problem/Motivation@yched brought up the following point in #1266748: Changing cardinality lower than highest existing delta causes data loss upon save just wanted to remind a comment made earlier, that...
View ArticleUuidItem should implement generateSampleValue
Problem/MotivationCalling generateSampleValue() on a UUID field does not return a proper UUID.Proposed resolutionImplement generateSampleValue() in UuidItem. Use \Drupal::service('uuid') to fetch the...
View ArticleClik here to view.
Drag and drop UX for Quick Editing small images is difficult
Follow up of: #2421427: Improve the UX of Quick Editing single-valued image fieldsI noticed while testing Quick Edit for single image fields, that the dropzone can be tiny for small images. If you use...
View ArticleReplace @expectedException @expectedExceptionMessage with...
Problem/MotivationUsing @expectedException is not considered good testing practice because you cannot specify where exactly in the test method the exception should be triggered. Background info:...
View ArticleAny AJAX call disregards machine name verification when AJAX is used and...
Problem/MotivationWhen the machine name is the same as an existing one and ajax is used a fatal error happens.Drupal\Core\Entity\EntityStorageException: 'filter_format' entity with ID 'basic_html'...
View ArticleRandom fail in CopyFileTest
Problem/MotivationJust noticed this on https://www.drupal.org/pift-ci-job/518115Migrate.Drupal\Tests\migrate\Kernel\process\CopyFileTest ✗ rupal\Tests\migrate\Kernel\process\CopyFileTe exception:...
View ArticleChecking for available modules fails for most of the modules
I am seeing this error next to most of the modules when I check for available updates.Failed to fetch available update datawarningIt happens all the time, but not always with the same modules. I'm not...
View ArticleUse a modal for entity delete operation links
Update entity delete operation links to use a modal by default, as delete forms are simple confirm forms in 99.99% of all cases (that 0.01% is just so nobody can tell me I forgot anyone :-P )
View ArticleClik here to view.
Add a CSS animation to expanding of details elements
The transition between the collapsed and open state of details is very sudden. From a visual perspective, this makes the interface feel very blunt rather than smooth. I suggest that we add a very small...
View Article