Unify PHP visibility for all test methods
At the moment most of the test methods are public.#!/usr/bin/env bash echo -n 'Public methods: ' grep -r '^ *public function test[A-Z]' . | wc -l echo -n 'Public methods (PHP4 style): ' grep -r '^...
View ArticleFix Squiz.Scope.MethodScope.Missing - all methods should have scopes
Problem/MotivationAll methods should have a scope.Proposed resolutionAdd the Squiz.Scope.MethodScope.Missing rule Make all methods missing scope public as this is the default.I ran the following...
View Articlehook_menu cache clear fails
API page: https://api.drupal.org/api/drupal/modules%21system%21system.api.php/func...I am writing a hook_menu after implementation when i change menu link title it shows old title also link menu not...
View ArticleCan't login in chrome
I installed Drupal on AWS ec2 server (using httpd) I can't seem to login when using chrome, but when using firefox the site works normallySteps to reproduce: Did a fresh install of Drupal 7.54 on my...
View ArticleTaxonomy Index for unpublished entities
Is there a reason hook_field_update doesn't update the taxonomy index for unpublished entities? I have a use case where editors can manipulate the taxonomy terms of unpublished nodes but these updates...
View ArticleRequest exceeded the limit of 10 internal redirects due to probable...
Drupal 7 running on VPS at GreenGeeksI'm seeing repeated Request exceeded the limit of 10 internal redirects due to probable configuration error. in my Apache Error log.I have 6 Drupal websites running...
View ArticleImprove Stark's help text
Stable and Stark at this point are quite similar. However, Stark is using core templates, which may well change over time, potentially breaking subthemes. Stable has duplicated the core templates which...
View Article#size for Select field documentation is wrong
API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...#size is currently representing the vertical number of lines.The following is false:#size: The size of the input...
View ArticleStark's helptext link redirects to D7 theme guide
Stark's help text on /admin/appearance links to drupal.org/theme-guide which redirects to drupal.org/docs/7/theming. I propose we link directly to drupal.org/docs/8/theming.
View ArticleAllow SystemMenuBlock tree manipulators to be altered
Problem/MotivationAt the moment every contrib module that needs to add/alter tree manipulators require to override Drupal\system\Plugin\Block\SystemMenuBlock (or implement their own).Proposed...
View ArticleAdd access modifier and correction to the comment for class...
This is a small patch which adds access modifier to the __construct() method and adds a correction to the comment for the method onTerminate(). This issue is valid for all version of Drupal 8. Patch...
View ArticleExplore using an IFrame to sandbox CSS for the Off Canvas tray
Problem/Motivation#2853208: [META] Determine best method ensure consistent theming of Off Canvas Tray explains the need to have the Off Canvas dialog look consistent when used in "admin" modeIt is very...
View ArticleRename EditEntityFieldAccessCheck now that the module is named Quick Edit
Problem/MotivationEditEntityFieldAccessCheck has a somewhat confusing name, especially now that the module has been renamed.Proposed resolutionRename EditEntityFieldAccessCheck to...
View ArticleExtract a common DataContainerInterface for lists and complex data
Motivation- Typed has the concept of lists and complex data, however there is general notion of general "data containers". That makes navigating in a tree of typed data unnecessarily complex as there...
View ArticleClik here to view.
New visual style for Seven
Problem/MotivationIn Proposal: A Style Guide for Seven, we set out to overhaul the visual style of Seven. This was met with a lot of great feedback, which we have largely incorporated. However much of...
View ArticleReferences to d.o/cron, which is documentation for Drupal 7
There are a couple of references in Drupal core to https://www.drupal.org/cron. This is a redirect however to the Drupal 7 documentation on cron with url...
View ArticleRebuild multiple forms on a page via AJAX
We have a page that contains multiple forms (for filtering elements on the rest of the page). The forms are defined with individual classes and store filtering IDs in the session.The issue we're...
View ArticleImprove Datetime and Daterange Widget accessibility
Problem/MotivationThe datetime and daterange widgets aren't as accessible as they can be. The improper use of the datetime-wrapper compounds the problem with the datarange widget.Most setting...
View Articledblog is SQL bound
Problem/Motivationlogger.dblog is backend overrideable but it's pointless to override it because the module is littered with database queries.Proposed resolutionExtend Psr\Log\LoggerInterface and add a...
View ArticleBlock View dated content never updates (to remove old events)
Block view of content with a date field with filter Date > now never updates block for anon users. Thought it was an issue with site so went back to basics > fresh D813 site > added date field...
View Article