Clik here to view.
Settings tray conceptually incompatible with configuration overrides such as...
Problem/MotivationWhen on a translated page, hit edit for a block. You'll get to edit the original text, not the translated text. The same applies also to any other kinds of configuration override,...
View ArticleMissing context on UserLoginBlock causes render-cache poisoning of the...
The user login block does not currently have a url.query _args context, and if a destination query is present, will append it to the form action.As a consequence, if the block is generated for the...
View ArticleUpdate Javascript based tests to test against all core themes
Current \Drupal\Tests\outside_in\FunctionalJavascript\OutsideInBlockFormTest only test against the Bartik theme. It should test against Stark also like OffCanvasTest StepsCreate...
View ArticleLog::findCaller fails to report the correct caller function with non-core...
Problem/MotivationContrib/custom database drivers are not in the Drupal\Core\Database namespace, and in this case Log::findCaller will not report the caller correctly, but just the first...
View Articletheme_table refactoring
Hey, guys!I found out that variable $i doesn't use anywhere in theme_table() on line 2034 in /includes/theme.inc file and also, I saw some other not logical things in this function (for example...
View ArticlePageCache should not use $request->getUri()
Problem/Motivation\Drupal\page_cache\StackMiddleware\PageCache::getCacheId() uses $request->getUri() for cache ID generation.\Symfony\Component\HttpFoundation\Request::getUri() doc saysGenerates a...
View ArticleStandard profile: make "Home" menu link to <front>...
The Standard installation profile creates a useful "Home" menu link, but it is hard-coded. When a user wants to edit it, the following message is displayed:This link is provided by the Standard module....
View ArticleBackwards variables in Install profile validation error message
Steps to reproduce I experienced this error when trying to import a config export that was broken, the 'profile' key was missing. So while it's not advisable to do this under normal circumstances, the...
View ArticleDatabase::startLog() cause a notice in Shortcut::sort()
Problem/MotivationDatabase::startLog() calls Log::findCaller() that calls debug_backtrace() that broke uasort() with Warning: uasort(): Array was modified by the user comparison function in...
View ArticleFile field formatters for rich media display with <video> and...
In a nutshell, this will introduce rich media display within Drupal core using the <video> and <audio> HTML5 elements. Initial development will occur at...
View ArticleUse of Symfony Expression Language "Expression" in...
Follow-up to #2747083: drupal/core-dependency-injection wrongly requires symfony/expression-languageProblem/MotivationIf you install the Expression Language library from symfony the test suite...
View ArticleChange #action in UserLoginBlock to a #lazy_builder to avoid the route cache...
LoginFormBlock currently adds the route cache context because it adds the #action explicitly including destination.But if we don't set the #action at all, then it is a placeholder that gets that...
View ArticleAdd a possibility to disable inline form errors for a complete form
This is a follow up of #2828092: Inline Form Errors not compatible with Quick Edit .In certain cases (like what Quick Edit does with forms) we want modules to have the possibility to disable Inline...
View ArticleAllow development modules to opt out of config-export
Problem/MotivationEveryone is having problems with modules being exported where they don't want it to be. The canonical example is the devel module.Proposed resolutionAdd a key to a module's info.yml...
View Article[PP-1] Displaying the same entity twice on one page, but in different view...
Problem/MotivationWhen displaying the same entity twice on the same page but in different view modes (e.g. full + teaser), then the contextual links of neither entity work.Proposed...
View ArticleConvert web tests of views
See #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)Proposed followups:\Drupal\views\Tests\FieldApiDataTest needs FieldTestBase so omitting from this...
View ArticleResourceResponse(Subscriber) + Dynamic Page Cache: making authenticated...
Problem/MotivationAfter #2807501: ResourceResponse::$responseData is serialized, but is never used: unserializing it on every Page Cache hit is a huge performance penalty was committed - which hugely...
View ArticleContext system +...
\Drupal\block\BlockAccessControlHandler::mergeCacheabilityFromConditions() causes the current user's cache tag to be associated with the access result.Even though there should not be such a cache tag,...
View ArticleParsing an URL with another URL in the query arguments throws undefined...
When UrlHelper::parse() is parsing an internal URI which contains a URL in the query arguments then it throws the following notice: Notice: Undefined offset: 1 in...
View ArticleD6 text area formatting settings not respected when migrating to D8
Problem/MotivationDrupal 6 text area text processing settings are not respected when migrating D6 fields to D8. Steps to reproduce:D6 Field type: textD6 Widget type: Text area (multiple rows)D6 Global...
View Article