Do we need a div around a more link?
Current more link markup:<div class="more-link"><a href="http://whatever" title="some title">More</a></div>Proposed markup:<a href="http://whatever" class="more" title="some...
View ArticlePicture module uses config keys with a dot
Updated: Comment #NProblem/MotivationThe picture module saves configuration files with keys with a dot in them. For example:id: mapping_oneuuid: 2638a632-9d17-4aa3-b204-4f81e8976db8label: 'Mapping...
View ArticleRemove theme_more_link() and replace with #type 'more_link'
Here is the current code for theme_more_link():<?phpfunction theme_more_link($variables) { return '<div class="more-link">'. l(t('More'), $variables['url'], array('attributes'=>...
View ArticleLinks should not be indicated by color only
Updated: Comment #77Problem/MotivationIn Bartik theme links are styled by applying a color, but no other distinguation like underlining, bold, or similar to differentiate the link text from normal...
View Article".active" from linkGenerator(), l() and theme_links() forces an upper limit...
Updated: Comment #118Problem/MotivationHTML links generated by either l(), theme_links() or linkGenerator() all dynamically check whether they are currently "active" by comparing the current URL's...
View ArticleSupport multi-column field types in base tables
Currently the mapFromStorageRecords() / mapToStorageRecord() methods only allow direct mapping of db column names to field names. This works because, on load, new $entity_class(array('field_name' =>...
View ArticleSVGZ isn't served with correct encoding
https://en.wikipedia.org/wiki/Scalable_Vector_Graphics#CompressionSVG images, being XML, contain many repeated fragments of text, so they are well suited for lossless data compression algorithms. When...
View ArticleOptimize performance of class based field definitions
Follow-up from #2047229: Change notice: Make use of classes for entity field and data definitions . Also note the benchmark results of comment #117
View ArticleImprove typed data definitions of lists
Currently lists are defined like that:<?php$definition = array( 'type'=> 'item_type', 'constraints'=> array('item constraints'), 'list'=> TRUE,);?>That's a bit confusing as it's not...
View ArticleBreakpointGroup::loadAllBreakpoints() is expensive
This loops through each breakpoint, and runs entity_load() on it. We have entity_load_multiple() for a reason.
View Articlenode_access breaks any query that has node table appearing twice with a left...
Updated: Comment #143Problem/MotivationWhen two node tables are left joined then access checks prevent access to the node when nothing is matched in the table on the right-hand side of the join. Access...
View ArticleRemove "Field" prefix from FieldDefinitionInterface methods
As agreed in Prague (https://docs.google.com/document/d/1pgDY-RaTbajNqXm-oj8GdzPD_fPvLb2jhnrt...) FieldDefinitionInterface is intended to be the "primary" interface for classes that implement it. We...
View ArticleAdd per entity type managers to improve DX
ProblemAt the Drupalcamp Vienna code sprints I've seen people doing stuff like /** * @var \Drupal\node\NodeInterface $node */such that they are able to auto-complete on the methods and...
View ArticleAdd file_exists() to _locale_parse_js_file() to prevent PHP warning
Problem/MotivationSome times a theme or module may attempt to add a JavaScript file that does not actually exist. When this happens, _locale_parse_js_file() causes a PHP warning whenever the cache is...
View ArticleClik here to view.
Change notice: Use jQuery UI Autocomplete
Let's get rid of our bad, old, custom JS and replace it with something that will be more supported, easier on the bus factor, and more flexible for...
View ArticledrupalSettings.pathPrefix does not bear language identifier
Should we expect that in drupalSettings.pathPrefix we will have the language code, in case we have a multilingual installation with URL language detection enabled, and we are on a page with a language...
View ArticleRegression: Revision dates are wrong when saving a node as a new revision
Noticed this in #1939994: Complete conversion of nodes to the new Entity Field API .We have no test coverage for this, I only had a related error that distracted me because I tought I've broken it but...
View ArticleAdd changed time tracking to menu links
Problem/MotivationMenu links don't have changed time tracking. See various reasons why this is a problem at #2074191: [META] Add changed timestamp tracking to content entities .Proposed resolutionAdd...
View ArticleUnified repository of field definitions (cache + API)
Right now, with two field info systems: The one for entity fields maintained by the EntityManager and the one for configurable fields. Ideally, we've only one and avoid duplicated field definitions in...
View Article