Users with just create content permission don't know publishing status
Problem/MotivationIn #2068063: Change "Save and keep un-/published" buttons to a "Published" checkbox and an included "Save" button we replaced the drop button with a "published" checkbox, however if a...
View ArticleReview and improve the media creation form
This issue is spun off from #2831936-129: Add "File" MediaSource plugin, specifically this point of review:The media creation form is a hodge-podge of information. The revision information is above /...
View Articlerevision_translation_affected is not re-calculated when re-saving a revision
Problem/MotivationOn the storage level revisions are not created just for a single translation of an entity, but for all translations. Because in the UI the field values are only edited for a single...
View ArticleContentEntityBase::setNewRevision(FALSE) is broken if ::setNewRevision(TRUE)...
Problem/MotivationCreate an entity and save it. Now call setNewRevision(TRUE) on the entity and before saving call setNewRevision(FALSE). The first call to setNewRevision removes the revision_id so...
View ArticleFor Drupal migration, identify the source module
Problem/MotivationThe migrate_upgrade UI is now providing a confirmation page, showing the administrator performing the upgrade what modules are being upgraded from their legacy sites (and what modules...
View ArticleEntityResource::patch() makes an incorrect assumption about entity keys,...
Problem/MotivationDiscovered by Berdir at #2789315-52: Create EntityPublishedInterface and use for Node and Comment and subsequent comments.Where/when was this bug introduced?#2631774: Impossible to...
View ArticleDrupal\Core\Database\IntegrityConstraintViolationException: SQLSTATE[23000]
I found my Drupal8 website broken with no appearent reason, i.e., no code nor structure modifications since it was working last time.I discovered that the error was initially raised after a Rest...
View ArticleDatabase cache bins allow unlimited growth: cache DB tables of gigabytes!
Problem/MotivationAll our render cache entries like page, entities, blocks, views and so on are by default cached forever.That's great. Except when you have a lot of data + a lot of variations and a...
View ArticleD7 Plain text fields incorrectly migrated to D8 as Text (formatted)
Problem/MotivationDrupal 8 has separate field storage types Text (plain) and Text (formatted). There's also Text (plain, long) and Text (formatted, long). The important part here is that this selection...
View ArticleAuto-fix ESLint errors and warnings
Run eslint --fix on the codebase. Before: 7088 issues After: 1288 issuesWhile there are a lot of changes in the es6 files, it doesn't impact the compiled js files too much. Major since it "Cause a...
View ArticleTest failures when db driver is set to not support transactions
I get some test failures if the db driver is set to avoid transaction management. Not sure if these are purely related to test code, or if there are real bugs.
View Articleoptions / checkbox (onoff) does not respect default value for existing...
Problem/MotivationCreating a checkbox field ( boolean ) in a content type and giving it a default value only works for new content, thats also mentioned in the field default value description ( see...
View ArticleAllow non-intrinsic (implementation-dependent) cache context services to...
Quoting @effulgentsia in #2428703: Add a 'user.permissions' cache context (was: "Should cache contexts be able to associate a cache tag?"):How about this to address #74: we embed the hierarchy in the...
View ArticleAllow hook_entity_field_access() to grant field-level access to User fields:...
Background In D8 the default access settings are simple: there is a single 'administer users' permission that controls editing other users.More complex schemes are possible using contrib modules to...
View ArticleMigration fails with missing i18n_variable table
Migrating a Drupal 6.x (6.38) without any translations fails when trying to migrate i18n variables with the following output:Migration failed with source plugin exception: SQLSTATE[42S02]: Base table...
View ArticleEntityStorageException thrown when trying to re-save translatable draft...
Problem/MotivationContent editors are unable to re-save existing, translatable draft content as draft again. After hitting "Save and Create New Draft", an EntityStorageException is...
View ArticleFinalize the behavior for triggering view/edit/build modes from the toolbar...
Problem/MotivationThe overall goal is to make more site edit/build functionality available directly on the frontend of your site (“turning Drupal outside in”). A current example of this is the "Edit"...
View ArticlePath alias changes for draft revisions immediately leak into live site
Problem/MotivationSteps to reproduce: 1. Enable content moderation module and enable default workflow for article content type (at admin/config/workflow/workflows/manage/editorial) 1. Create article...
View ArticleRename plugin variable in AddRoleUserTest class
$remove_role_plugin = new AddRoleUser($config, 'user_add_role_action', ['type' => 'user'], $this->userRoleEntityType); $remove_role_plugin->execute($this->account); I guess it was borrowed...
View Article