Banned IP addresses can still access cached pages
Steps to reproduce: 1. Enable page caching. 2. Visit the front page as an anonymous user to get it into the page cache. 3. Use the Ban module to ban that user's IP address. 4. Visit the front page as...
View ArticleCreate admin interface for managing Entities
Has this been thought about? Does anything exist out there for this? If not, is there a reason this doesn't exist?I think it would be great to have one, singular place to manage Entity fields /...
View ArticleDecide how to handle POST/PATCH when using HAL
Problem/MotivationIt's unclear whether we want to support operations like PUT using HAL, or whether we should just expect application/json. Related discussions on the HAL mailing list:granularity of...
View ArticleModuleHandler::setModuleList() should call resetImplementations() in order to...
There have been edge cases (for example when running the installer) on which the hookInfo in the module handler was outdated, but the moduleList was updated.One possible call route is install_finished...
View ArticleLayouts do not render regions appropriately.
Layouts currently don't render region wrappers around the various regions. This will be problematic as we move to migrating existing theme page templates to layout plugins. Layouts are also treating...
View ArticleAdd a bartik based layout plugin to the bartik theme
We need to start converting the bartik page.tpl.php into a valid layout plugin. This will likely include the addition of a few new regions for areas like breadcrumbs that were hardcoded into a section...
View ArticleRename #type =>"actions" / EntityFormController::actions to "buttons" or similar
While reviewing #1920686-1: Deleting a menu gives fatal error + the delete button is shown on system menu's. I was confused by protected function actions() was for. The PHPDoc on...
View ArticleClik here to view.
Merge the two messages in the "Extend" ("Modules") page when both core and...
Here's a screenshot that shows the waste of vertical space (especially in smaller screen widths):These two messages are almost identical and could be merged into a single one when there exist updates...
View ArticleFatal error on install when database is already created
Attempted to install a clean version of D8 today, and I'm getting a fatal error on the 2nd step of the install (right after selecting an install profile). Here are the fatal errors...SQLSTATE[42S02]:...
View Article[site:url] is inconsistent depending on whether a language prefix is present
[site:url] may be used by itself in order to show a link to the site, or it may be concatenated with a string to produce a link to some resource like[site:url]foo/bar.png This usually results in...
View ArticleMissing docs for hook_schema_0()
Apparently #1018602: Move entity system to a module sneaked in this hook but we don't have docs to explain what it does.This is actually critical, but I'll split the difference at major for now in the...
View ArticlePDOException loses its message when querying with invalid UTF-8 due to...
I am dealing with a module (CMIS) that is trying to insert content into the database with the wrong charset. I was getting the following two errors: Warning: htmlspecialchars(): Invalid multibyte...
View ArticleConsider to inject a class into the Core annotated discovery implementation...
Follow-up to #1836008: Remove drupal_classloader() use in Drupal\Core\AnnotatedClassDiscoveryQuick Idea: Add a new interface that just defines a single method, getNamespaces() or something like that....
View ArticleAdd methods for testing protected class methods and properties in...
I have thought about this for a while, and also used similar things before to test protected properties and method on classes. The only other way to really do this is to create a wrapper class that...
View Article"Add new comment" link only available when there is at least 1 comment...
I'm using blog and comment module.Guests are allowed to comment blog posts. But the "New comment" link only appears if there is at least 1 comment. When there is no comment the link will not be shown.I...
View ArticleHook_node_access: question
Maybe I'm missing something obvious, but, the following function does not do what I want:<?phpfunction faq_accesscontrol_node_access($node, $op, $account){ if ($node->type == 'faq'){...
View ArticleUpdate integer/boolean values with quotes in configuration files.
Problem/motivationSome of the yml files having integer/boolean values without quotes.Proposed solutionFor consistency, Update integer/boolean values on quotes in yml files. Found in:...
View ArticleConvert aggregator processors and parsers to plugins
Fetchers got converted on #1497366: Introduce Plugin System to Core lets do the same for processors and parsers
View ArticleNot all html attributes should go through check_plain
Problem/MotivationThe class Attribute is used in drupal to collect and render html attributes. It applies 'htmlspecialchars'(inside check_plain) to everything. It appears the assumption is that any...
View ArticlePath Rewrite Malfunction | index.php must be in URL
I am currently testing D8 in Windows8 and it begins to fail after install. I am posting here because I think it is related. Let me know if I should create a new issue.Basically once Drupal8 is...
View Article