Properly deprecate ThemeHandlerInterface::uninstall() and remove usage
Problem/MotivationIn #2465887: Extract the install/uninstall functionality to a ThemeInstaller responsibility of [un]install of themes moved to theme_installer service but no CR filed and deprecated...
View ArticleMake sure TestSitePath exist before creating .htkey
After building a custom install profile (example), I attempted to create a test for the profile, similar to StandardTest.The test failed due to Drupal's inability to write the file to the desired...
View ArticleOptimize CEB::hasTranslationChanges by caching its result and serving...
Problem/MotivationContentEntityBase::hasTranslationChanges is being called in core two times during the saving process. 1. ChangedItem::preSave 2....
View Articlehook_user_format_name_alter() should document that it's invoked for both...
API page: https://api.drupal.org/api/drupal/core%21modules%21user%21user.api.php/f...> \Drupal\Core\Session\AccountInterface $account: The user object on which the operation is being...
View Articlereturn value for hook_entity_bundle_info() doesn't mark...
API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...The 'uri_callback' property in the return is optional as can be seen from the implementation in tests:...
View ArticleAllow a single SectionStorage plugin to be returned for a set of available...
Problem/MotivationIn order to solve #2976148: Layout-based entity rendering should delegate to the correct section storage instead of hardcoding to either defaults or overrides, there must be a...
View ArticleDeprecate ThemeHandlerInterface::getBaseThemes and remove usages from core
Follow-up from #2659940: Extension System, Part III: ThemeExtensionList and ThemeEngineExtensionList
View ArticleAdd an in-memory config storage.
Problem/MotivationFor #2991683: Add configuration transformer API we need a MemoryStorage to work with configuration without persisting it.But it is also useful in a more general circumstance. A couple...
View ArticleDeprecate drupal_get_path() and replace with ExtensionList::getPath()
Postponed on #2208429: Extension System, Part III: ExtensionList, ModuleExtensionList and ProfileExtensionList and #1308152: Add stream wrappers to access extension filesProblem/MotivationAfter the...
View Article[META] Deprecate the legacy include files
Drupal 8 has a bunch of the legacy include files. As Drupal 9 planned to be released in 2020, it would be great to deprecate content of the legacy files as much as possible before release.This is the...
View ArticleUse generators by default in source plugins
Problem/MotivationCurrently, Migrate source plugins use iterators to return the data to be migrated. In sources which need to perform special processing and/or filtering on each data row, doing that...
View ArticleAdd Module, Theme, Profile, and Extension value objects
Parent issue#2024083: [META] Improve the extension system (modules, profiles, themes)Problem/MotivationThe DX of ModuleHandler or any other place that reads or works with module/theme/profile data is...
View Articledrush cr error
Hello all,Everytime I use drush cr I get an error, here it is:PHP Fatal error: Class 'Drupal\entity\Routing\AdminHtmlRouteProvider' not found in...
View ArticleLosing custom block library in sql database when clearing cache
Hello,I was on drupal 8.4.4 and I then updated to 8.6.3 hoping it was going to solve my problem but no success. The problem is; When ever I clear the cache of the website, that is using the ui...
View ArticleDeprecate module_load_include() for removal before Drupal 9.0.x
Problem/MotivationThe module_load_include() function provides little or no advantage over calling simpler functions directly. In #599122, several calls to require(DRUPAL_ROOT . 'file') were changed to...
View ArticleAllow the seven sidebar for the node form to be used on other entity forms as...
Based on #2803875: Node form meta information should not come from a theme and #2882801: Review and improve the media creation form, I had the idea that we could let entity forms/modules opt-in to the...
View ArticleMissing argument 5 for _drupal_error_handler() in Drupal 7
Problem/MotivationIt happens when using external libraries that at some point, run the error handler manually (in my case it happens with Symfony, but it could happen with any library playing a bit...
View ArticleBrowser language detection broken
Browser language detection is skipped, if a browser/robot without Accept-Language header calls the page and the default language node is put into cache. Afterwards, the default language node is always...
View ArticleDeprecate ThemeHandlerInterface::rebuildThemeData() and use...
Problem/MotivationIn #2659940: Extension System, Part III: ThemeExtensionList and ThemeEngineExtensionList, the responsibility of managing the list of themes and theme data is moved to...
View ArticleRefactor out theme hook suggestion building from ThemeManager::render() into...
I am proposing a straightforward refactoring.Currently, theme hook suggestions are collected within ThemeManager::render(). I propose to split this out into a separate function.Let's start with a...
View Article