Non interactive install not in English with configuration overrides is broken
Problem/MotivationSteps to reproduce:Install standard in GermanEnable config_translationAdd the english languageEdit the standard profile to not have an standard_install() and add keep_english: true to...
View ArticleProgrammatically created translatable content type returns SQL error on...
Problem/MotivationA created translatable content type added to the install config of a module or an install profile results in SQL error "Unknown column 'content_translation_source' in 'field list'"...
View ArticleBreadcrumbBuilder::applies() mismatch with cacheability metadata
Problem/MotivationI am noticing the following problem with breadcrumbs, when I have my (sandbox) Configurable Help module installed, which has a custom breadcrumb class/service. This appeared recently...
View ArticleConditionally change the query operator in between exposed filter when empty...
Problem/MotivationWhen exposing between filters, if a user only enters one value (min or max), the query that is run always returns odd results (most likely db-backend-dependent. For instance, on an...
View ArticleControllerResolver::getArguments() is removed in Symfony 4 and...
Problem/MotivationControllerResolver::getArguments() has been removed in Symfony 4, leading to test failures when 8.x is updated.Proposed resolutionRe-implement it in our subclass, mark it as internal...
View Articledrupal_parse_url() overwrites URL path with query string
ProblemWhen you pass a link into drupal_parse_url(), you're given a nice array of a URL path, any query strings, and any fragments. However, when drupal_parse_url() encounters a query string with a q...
View ArticleRevisions should reflect active menu trail
When visiting the node/%node/latest route, the active menu trail does not reflect the published revision. Is that on purpose? Elsewhere, we prevented changes from being made to the menu item on draft...
View Article"Filtered HTML" text format does not support manual teaser break...
Placing the following line inside a story node's body (I guess it also works for other content types) adds a manual teaser break:<!--break-->This works fine when the story uses the "Full HTML"...
View ArticleInvestigate problems with Symfony 4 now
Problem/MotivationDrupal 9 will release with either Symfony 4 or Symfony 5.In order to be able to do that, we should make Drupal 8 as compatible with Symfony 4 as possible:1. Remove all use of...
View Article[META] Symfony 4.0 compatibility
Problem/MotivationThe Symfony 3.4 LTS will be EOL in 2021: http://symfony.com/doc/current/contributing/community/releases.html#sche...This means we need to be ready to move to Symfony 4 before...
View ArticleMail HTML to TXT causes DKIM failure
DKIM fails because the mail body has been altered.What happens:– In the conversion of HTML to plain text (drupal_html_to_text), h3 and h4 tags are prefixed by ".... " and ".. " resp.– SMTP uses...
View ArticleMigrateDrupalTestBase::migrateContent(['translations') does not...
Working on #2754493: D6 synchronized field settings aren't migrated properly uncovered that MigrateDrupalTestBase::migrateContent(['translations') does not migrate translations. It is simple...
View ArticleGender neutral language
Problem/MotivationUse of he, she, his and her is largely unnecessary in code comments and test text.Proposed resolutionFound by by grepping the codebase for (^|\W)(he|she|him|his|her|hers)($|\W) and...
View ArticleAdd "Edit blocks" permissions
Problem/MotivationThis issue follows up on the discussion in #1975064: Add more granular block permissionsCustom blocks can be created as structural page elements and content editors might need to edit...
View Articlehtaccess functions should be a service
Problem/MotivationAs part of the general clean-up of the File API, file_save_htaccess() and file_ensure_htaccess() need to be deprecated and moved into services.Proposed ResolutionMove this...
View ArticleAdd trigger_error to deprecated functions in file.inc in convert them
From #2244513: Replace old managed and unmanaged file APIs with testable services (file.inc) The level of nesting that's going on in those file system calls is pretty mindblowing and "fun" to debug as...
View ArticleDeprecate upload-related functions file.inc and move to a file upload service
From #2244513: Replace old managed and unmanaged file APIs with testable services (file.inc)file_munge_filename() is a pretty weird one, maybe we should have something like a file upload service, with...
View ArticleMove file status constant to FileInterface
From #2244513: Replace old managed and unmanaged file APIs with testable services (file.inc) * the file status constant, that should be a separate issue to move it to FileInterface.
View ArticleConvert $source object to a TranslatableProject class
Locale module uses an array to store data of translatable projects and available translations during its translation update batch processes. Also different (helper) function are used to process the...
View Article