Make the output of final exception subscriber developer firendly
The exception response has been turned into text/plain last year for the purpose of security (SA-CORE-2016-004). For this reason HTML entities are now shown unprocessed. I propose we strip out HTML...
View ArticleAssertLegacyTrait methods are invoked with too many arguments
Most of the assert methods to not support optional $message parameter. However, their consumers expect they do.
View ArticleClik here to view.
Migrate comment type language settings
Problem/MotivationIn #2981392: Comment migration corrupts data with multilingual sites we found out that the comment type language settings are not migrated sensibly when the source content type has...
View ArticleControllerResolver::getArguments() is removed in Symfony 4 and...
Problem/MotivationControllerResolver::getArguments() has been removed in Symfony 4, leading to test failures when 8.x is updated.Proposed resolutionRe-implement it in our subclass, mark it as internal...
View ArticlePage cache test fails with Symfony 4
Problem/MotivationSpin-off from #2976394: Investigate problems with Symfony 4 now which includes both Symfony4 and cors/stack updates.It looks like the http middleware for page cache is either not...
View ArticleComplete the deprecation of format_date()
Problem/MotivationAs part of #2999721: [META] Deprecate the legacy include files , deprecate format_date()Proposed resolutionReplace with calls to DateFormatterInterface::format().In tests, replace all...
View ArticleClik here to view.
system_post_update_add_expand_all_items_key_in_system_menu_block fails if...
Problem/MotivationSee #2594425-137: Add the option in system menu block to "Expand all items in this tree"This issue broke the upgrade test for DER 1.x to 2.x...
View ArticleEnhance pager in-code documentation
In pager.html.twig documentation it just says that attributes should be 'A keyed list of HTML attributes for the item.' Though it should be an instance of core/lib/Drupal/Core/Template/Attribute.php. A...
View ArticleAdd @trigger_error() to deprecated url/link EntityInterface methods
Problem/MotivationPart of #2856744: [META] Add trigger_error(..., E_USER_DEPRECATED) to deprecated codeExplicitly mark methods like ::url(), ::link() and so on as deprecated, fix remaining...
View ArticleDeprecate entity_render_cache_clear function in entity.inc file
Problem/MotivationFollowup #2999721: [META] Deprecate the legacy include files Proposed resolutionMove function logic into the entity type manager service.Remaining tasksmove logic into appropriate...
View ArticleOptimize getCommentedEntity()
Click on the right hand side of https://www.dropbox.com/s/dqc7duebdzzr88d/result-node1-no-page-cache-fla... in the bar called Drupal\comment\CommentLazyBuilders::renderLinks. There you will see a wide...
View ArticleDrupal crashes with error Cannot unset string offsets when module install...
What are the steps required to reproduce the bug?https://www.drupal.org/project/custom_node_write/issues/3022249 Modify an existing install file and add a description in the field: Before:$schema...
View ArticleMigrate D7 i18n fields label and description
Problem/MotivationD7 field labels and field options can be translated with Field Translation and String translation modules (both are part of the i18n suite).We need to migrate the translated field...
View ArticleClik here to view.
PhpUnit make test results more developer friendly
One thing I am always missing when running tests through command line is finding HTML output file by URL of HTTP request logged in it. I propose adding a meaningful label above each reference on HTML...
View ArticleUse drupalci.yml for composer dependency min/max testing
Problem/MotivationEventually, DrupalCI will give us a way to tie different build processes to different needs, using the idea of 'triggers.'One such build trigger will likely be a dependency min/max...
View Article[PostgresSQL] Variable to config: search_active_modules
Problem/MotivationThis introduced PostgreSQL failure: - https://www.drupal.org/pift-ci-job/1147872 -...
View ArticleProperly deprecate drupal_move_uploaded_file()
Replace deprecated drupal_move_uploaded_file() function calls with moveUploadedFile() method of the file_system service.
View Article[META] Properly replace deprecated function from file.inc in core
file.inc contains functions that are not properly replaced from the core as they are deprecated.drupal_unlink() - #3021434: Properly deprecate drupal_unlink()drupal_chmod() - #3021459: Properly...
View ArticleMove entity_get_(form_)display() to the entity display repository
This summary is adapted from #2818227: Undeprecate entity_get_(form_)display() or offer a real replacement for accuracy.Problem/Motivation#2474151: Mark procedural wrappers in entity.inc as deprecated...
View ArticleRemove remaining usages of entity_view_multiple from core
The entity_view_multiple function has been deprecated for some time now and only used in 8 places. Let's go the home stretch, remove the final usages from core and trigger a deprecation warning when...
View Article
