Allow content entity storages to define forbidden keys when generating sample...
When generating sample entity values and there are is existing data \Drupal\Core\Entity\ContentEntityStorageBase::createWithSampleValues can go into a nested mess if entities have back references to...
View Article[Symfony 4] Sub class \Symfony\Component\Validator\ConstraintViolation and...
Problem/MotivationSymfony 4 uses strict types in the Constraint system, typecasting translateable markup to strings. This causes the twig system to make the string html safe, escaping the html we...
View ArticleEntity type and bundle information cannot be (easily) retrieved from section...
Problem/MotivationContext: working on product display page integrations with Layout Builder: #2952529: Support for Layout Builder module.We have embedded entities: variations are embedded in their...
View ArticleLanguage detection based on session doesn't work with URL aliases
Problem/Motivation- Path module doesn't take into consideration the language when using session for detection, when using url prefix it works. - Translation switch links in node's view doesn't output...
View ArticleLocal tasks should honor selected admin interface language (if set)
Problem/MotivationLocal task labels are always displayed using the content language, ignoring that users can set their admin language preference (if the site has an admin language preference option set...
View ArticleBook navigation block doesn't appear on unpublished book outline pages
To me this is unexpected behaviour and will be even more pronounced if #26552: Allow users with access to unpublished nodes to create unpublished books gets in.
View ArticleAdmin toolbar should always be rendered in the admin language (if set)
Problem/MotivationIf the site has an admin language preference option set in negotiation, users can set their admin language preference. However, even if that is set, only admin pages are affected. The...
View Article[PP-1] Fix NOT NULL handling in the entity storage and 'primary...
Problem/MotivationCurrently, only a few entity keys are automatically marked as NOT NULL, which is a problem because it gives the impression that entity keys are somehow special and leads to bugs like...
View ArticleThe editor module assumes that a fieldable entity is also revisionable
The editor_entity_update() function gets an EntityInterface, and checks if it is a FieldableEntityInterface. After that it tries to call getRevisionId(), which will succeed in case of the content...
View ArticleBackport D8 html_tag element changes
Hello,One year ago, the Drupal 8 html_tag has been updated and it's now able to render nested tags, see the CR here #2887146.I backported the functionnality to Drupal 7 so no, we can render this render...
View ArticleAdd a new test type to do real update testing
Problem/MotivationWe have hit problems with the security release of 8.6.7 and the bug fix release of 8.6.8. See:#3026386: Drush fatal error after upgrading to 8.6.6, 8.5.9, or 7.62: PHP Fatal error:...
View ArticleDrupalKernelTest results in ERROR HANDLER CHANGED!
Problem/MotivationWorking on #3031379: Add a new test type to do real update testing we end up running tests from PHPUnit a lot.PHPUnit shows us an error like this: $ ./vendor/bin/phpunit -c core...
View ArticleImprove accessibility of Umami's responsive main menu
Problem/MotivationThe responsive menu in Umami has some accessibility problems:The button only does something when JS is enabled. When JS is off, the button is there in markup, but does nothing.Menu...
View ArticleSplit up simpletest into simpletest and testing_ui to enable easier decisions...
Problem/MotivationThere are two potential removals possible in Drupal 9 in the context of simpletest:Mark simpletest as deprecated in 8.8/8.9 and remove it in Drupal 9 potentially:...
View ArticleAllow fields on a layout builder enabled content type to be locked and...
I would like to use Layout Builder to allow site editors to add additional block content to a node, but have other fields on the content type locked from being moved, deleted, configured, etc. These...
View ArticleMake 'Use AJAX' work for Bulk update and similar form elements
Problem/MotivationThe 'Use AJAX' option of views does not work for 'Bulk update' form elements. By applying the bulk update the page refresh is still initiated. The same problem occurs when using this...
View Article[Layout Initiative meeting] 2019/5/14
Agenda:?Previous agenda: #3050243: [Layout Initiative meeting] 2019/4/30
View ArticleThemeHandlerTest and friends break isolation for constants
Problem/MotivationAfter we apply the fix from #3054649: DrupalKernelTest results in ERROR HANDLER CHANGED! and then run unit tests from PHPUnit we see this:$ ./vendor/bin/phpunit -c core/ --testsuite...
View ArticleFile module has dependency on user
I believe the file module has a dependency on the user module that it's not specifying. Although I also think I'm missing something tricky about the base Drupal modules (user, system, etc.) and where...
View ArticleMigration Lookup plugin does not return multiple values when matched and uses...
The Migration Lookup plugin relies on deprecated method MigrateIdMapInterface::lookupDestinationId(), which passes control over to MigrateIdMapInterface::lookupDestinationIds(), then filters out all...
View Article