Use request stack in form builder
Instead of injecting request service, rather use the Symfony 2.4 request_stack in FormBuilder.
View Article_theme micro-optimization
There isn't a significant benefit from this, but it's definitely an improvement and I'm tired of seeing it in profiling results.
View ArticleCacheable "Syndicate" block
We're working to make all blocks cacheable. This block can trivially be made cacheable. Let's just get it done.
View Articledeclare a maximum length for entity and bundle machine names
Because neither entity names nor bundle machine names are in a database table, there is no official maximum length.Some entity modules store their bundles in the DB, eg node stores node type with a...
View ArticleProtect .git, .hg and .bzr directories in .htaccess
.htaccess prevents access to various files that are not supposed to be downloaded by users, including CVS's control files in the CVS directory: Entries, Root and Repository. In #28776: Protect svn...
View ArticleAccountInterface::hasPermission implementations should be as fast as possible.
Every call to hasPermission does $roles = \Drupal::entityManager()->getStorageController('user_role')->loadMultiple($this->getRoles()); for both logged in users and anonymous users.I don't...
View ArticleClik here to view.
Slightly ugly error message if a module is incompatible with the version of...
This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from...
View ArticleRegression: Entity definitions miss a language entity key
While working on #1966436: Default *content* entity languages are not set for entities created with the API we figured that Drupal 8 misses the 'language' entity key, as it got introduced for Drupal 7...
View ArticleCheck for use of DatabaseConnection objects during SimpleTest shutdown
Problem/MotivationRunning the SimpleTest Unit Tests in HHVM-nightly caused problems with regards to warnings complaining about "Too many arguments being passed to PDOStatement::execute". I initially...
View ArticleAllow multiple vocabularies in term reference fields
i find simple way to do just look this1. Go to Manage fields and >>Edit filed >>>>Collection field settingsThese settings apply to the Collection field everywhere it is used. Because...
View ArticleMarkup for: comment.html.twig
Proposed markup for comment template:<article{{ attributes }}> {{ title.prefix }} {% if new %} <mark class="new">{{ new }}</mark> {% endif %} <h3{{ title.attributes }}>{{...
View Articletemplate_preprocess_page() performs ~20 DB queries
While working on making the breadcrumbs block cacheable, I noticed that they are also being rendered in template_preprocess_page().So I put a strategic "early return" statement in...
View ArticleMove all path alias SQL queries to a single storage controller
Updated: Comment #0Problem/MotivationWe already moved most of DB queries to Path CRUD service (#2136503: Make \Drupal\Core\Path\AliasManager storage independent), but there are still some SQL queries...
View Article[META] remove drupal_set_title() and drupal_get_title()
Problem/MotivationTo be able to cache a site you not only need the css/js attached but also the page.Proposed resolutionPut the title to #attached and remove drupal_set_title completely.Remaining...
View ArticleEnable static caching for config entities
#1779026-155: Convert Text Formats to Configuration SystemThe code is copied literally from DatabaseStorageController.
View Articlestep 1: Re-architect WebTestBase on top of Mink
Updated: Comment #NProblem/MotivationOver in #2232271: [Meta] Use Behat we're proposing adding Behat to enable JavaScript testing. But we don't need Behat to utilise the Selenium/Sahi/Zombie drivers,...
View ArticleImprove ContentEntityBase::id() for better DX
Updated: Comment #0Problem/MotivationCurrently the most of cotent entities should implement id() method when their primary key is not IDProposed resolutionLet ContentEntityBase::id() to get id name...
View Article[Meta] Use Behat
Problem/MotivationNo test coverage for the frontend.Proposed resolutionUse Behat.Discussed this with Jesse Beach, nod_ and Alex Pott yesterday at Dev Days (Szeged) and we strongly feel we should use...
View Articlequoting of default database columns and indexes and fields in postgres
Discovered in https://drupal.org/node/710940 that default values weren't quoted.
View ArticleIncorrect usage of attributes in twig templates resulting in possible...
Follow-up from #2108771: Remove special $variables keys for Attribute object creation in the name of DX.Some templates snuck in with things like <tag class="test"{{ attributes }}> but if you use...
View Article
