ConditionManager::execute() implementation doesn't conform to the interface
This is a sister issue of #2996431: Fix docs for ConditionPluginBase and together they make very hard to read / follow the condition plugin system. When the execute() method of a condition plugin is...
View ArticleFix docs for ConditionPluginBase
Follow-up #2385429: setExecutableManager() is implemented on the wrong class\Drupal\Core\Condition\ConditionPluginBase::setExecutableManager() accepts \Drupal\Core\Executable\ExecutableManagerInterface...
View ArticlePager incompatible with exposed filter on changed field
I am filing this under views, since this is where I observed it, the actual bug may be elsewhere.1) create a content view with a page and a full pager.2) add a filter on node.created, expose the...
View ArticleLet the hook cache store arbitrary callbacks instead of module names
Currently the hook cache is an array of the format $module_name => $group.We also know that the hook system is fragile. sun suggested to allow an alternative format with Drupal\$module\Hook::foo()...
View ArticleAdd a useful example to TranslatableInterface::addTranslation
_menu_ui_node_save() (and elsewhere) we see examples of a translation can be created with a copy of the original. This is quite useful -- perhaps there should even be code for it? but for now, a simple...
View ArticleAdd an entity iterator to load entities in chunks
Problem/MotivationIf you need to load a lot of entities and iterate over them (pretty common), your memory usage could easily go through the roof.For example, consider updating all nodes for some...
View ArticleViewPageController::handle() return doxygen is incorrect
As the title says, really simple.
View ArticleMissing typehint in EntityBase::getTypedData
There is a dynamic static method call, I feel it could use a typehint.
View ArticleDenormalization of empty string date throws UnexpectedValueException
When an incoming object to be unserialized contains an empty string (instead of null) for a date property it is considered invalid by the DateTimeNormalizer. Generating the error The specified date ""...
View ArticleDocument translation form metadata on field.api.php
When altering widgets, I found I needed the language of the translation form worked on and ContentTranslationController puts that some more really useful information in $form_state but it's added via...
View ArticleDocument translations vs getEntity()
I have been burned, repeatedly, by presuming something about the langcode of getEntity both from above and from below. Documenting this is easy and the recommended method calls cheap.
View ArticleMake deleting revisions DX a bit better
When deleting revisions en masse, I ran into three problems:While entities are deleted via $entity->delete(), revisions are deleted via $storage->deleteRevision(). Following the...
View ArticleEmpty AJAX replies die with a mysterious exception
Oh this was a fun one! CommandWithAttachedAssetsTrait::getRenderedContent calls AttachedAssets::createFromRenderArray which dies with The render array has not yet been rendered, hence not all...
View ArticleThe "from state" used for calculating available transitions is...
Problem/MotivationThe workflow transitions are not working properly when using preview mode , prior to saving content.When clicking to preview and returning to edit mode, the content moderation current...
View ArticleAdd more developer docs for Help Topics
As part of getting Help Topics stable, we should add some developer docs.Currently the process of creating help topics for a module/theme/profile developer is documented in a Help Topic, and in the...
View ArticleHelp Topics module roadmap: the path to beta and stable
Problem/MotivationOnce #2920309: Add experimental module for Help Topics has landed this issue will track the necessary work to get the module to beta and then a stable state (at which point it should...
View Articlehook update no longer sees whether a new revision was saved
#2544790: ContentEntityBase::setNewRevision(FALSE) is broken if ::setNewRevision(TRUE) was called previously added $this->newRevision = FALSE; to ContentEntityBase::postSave. Now,...
View ArticleRace condition in ImageStyle::createDerivative()
Problem/MotivationIt is possible that the directory creation/file_prepare_directory() call in ImageStyle::createDerivative() can result in a race condition, especially when you have multiple servers.In...
View ArticleInject renderer service into ThemeManager, disuse drupal_render()
Problem/MotivationWe have drupal_render() calls in ThemeManager.Proposed resolutionInject the Renderer.Remaining tasksDo itUser interface changesNoneAPI changesTBDData model changesNone
View Article
