Update core service definitions to use class names, adding aliases for BC
Problem/MotivationSymfony 4 will drop support for magic autowiring, expecting services to be aliased - see their docs and @weaverryan's Drupalcon session.Proposed resolutionReplace service IDs with...
View ArticleRace condition in file_save_upload causes data loss
First discovered in the ClamAV module: #2864506: Long ajax process causing files to disappear.A slow implementation of hook_file_validate() can cause inappropriate entries in the file_managed table,...
View ArticleBoolean field filtering does not work when no values are set
Posthumously we have been required to add a boolean "hide from front end" field to our article content type as a number of articles need to be hidden from view yet still available to search engines. We...
View ArticleConstrain the width of embedded media to a max of 75% of the text...
Problem/MotivationThis from feedback from @effulgentsia here #2801307-54: [META] Support WYSIWYG embedding of media entities:[...] add CSS along the lines of max-width: 75% on media that's aligned left...
View Article[META] Support WYSIWYG embedding of media entities
Problem/MotivationCore currently provides support for embedding of images. It is currently impossible to embed a video or a document. Also, when #2801277: [META] Support remote media assets as...
View ArticleAllow media embed width constraint to be configurable
Problem/MotivationThis is a follow-up to #3078287: Constrain the width of embedded media to a max of 75% of the text editor's viewport Media Embeds should have some width constraint to allow left-align...
View ArticleWhen theme registry is overwritten, $info['includes'] is lost.
Bug description: When theme registry is overwritten, the latter $info['includes'] is lost.Suppose someA module defines the following hook_theme() function:function someA_theme() {...
View ArticleClik here to view.
Cron executed from another location
I am using hook_cron to send an emails from my site. Within the email there is a link *created with $base_root*<p>Your TEST has finished Processing. Visit ".$base_root."/?q=test/".$id. " to view...
View ArticleMedia Library error when trying to "Insert Selected" from the the...
When using the layout builder module and having an add media widget as a field in an inline-block type the selected media, when picked from the media library, does not attach to the field.I can upload...
View ArticledrupalPostForm lacks headers
Problem/Motivationhttps://www.drupal.org/project/seckit/issues/3074080 is porting to the new BrowserTestBase. The old method was protected function drupalPostForm($path, $edit, $submit, array $options...
View ArticleMove simpletest module to contrib
Problem/MotivationBased on conversation in #3057420: [meta] How to deprecate Simpletest with minimal disruption, it's likely that we'll move simpletest module out of core, to be a contrib module.This...
View ArticleDeprecate and remove block_place module in Drupal 9
Problem/Motivation#2739075: [plan] Make Place Blocks module functionality part of the Block module (etc.) wanted to move the module into block module originally, but now Layout Builder superseded it....
View ArticleConvert CommentActionsTest to kernel test
Problem/MotivationThis is a subissue of #2526060: Add tests for action plugins. We need automated tests for the Comment action plugins. Those plugins can be found in...
View ArticleEntity query needs to clarify what 'current revision' means
API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...It's not entirely clear what the 'current revision' means. Is it the published one, or is it the most recent?I think...
View ArticleHeight calculation error when used with Settings Tray and Bootstrap css
The admin toolbar applies a padding to the top of the body element that should be equal to its height.However in the following scenario the height calculation is incorrect.Settings Tray module adds a...
View Article[META] Requirements for opening the Drupal 9.0.x branch and 9.0.0-alpha1
Problem/MotivationOpening the Drupal 9 branch allows a few things to happen.We can upgrade Drupal's PHP requirements to require Symfony 4 or higher (and Twig etc.)Contrib modules can test against the...
View Article[PP-1] Non-8.x Drupal install profiles can be installed on Drupal 8
Problem/MotivationI changed mininal.info.yml to use core: 9.x and it installed fine.found this in #2313917: Core version key in module's .info.yml doesn't respect core semantic versioning where we...
View ArticleReplace jQuery UI autocomplete with awesomplete
Before going any further, know this: Much of the work on this task took place here: #2346973: Improve usability and accessibility of long select lists. It eventually became apparent that this needed...
View ArticleClik here to view.
Add change records to all @deprecated code
Problem/MotivationDrupal 8 has adopted a new deprecation policy to make it easier for developers to update outdated code: https://www.drupal.org/core/deprecationOne new part of this policy is that...
View ArticleImplement batch api as a service
The batch API should be a pluggable service so it could be swapped out or mocked for testing.The following will need to be completed:#2959723: Create an interface and initial class for the batch...
View Article