WebDriver HTTP error 400 Bad Content-Length errors
Problem/Motivation#2942900: Convert JavascriptTestBase Tests to use DrupalSelenium2Driver introduced \Drupal\FunctionalJavascriptTests\WebDriverCurlService.That extends \WebDriver\Service\CurlService,...
View ArticleAllow to prevent the deletion of a content entity in hooks
Problem/MotivationIn #2413769: Prevent the deletion of a bundle entity if there are existing content entities of that bundle, we are adding logic to ConfigEntityBundleBase so we can throw an exception...
View ArticleAdd gitignore(s) to composer-ready project templates
Problem/MotivationThe composer-ready project templates nearly shipped with a .gitignore that would have caused all the composer-managed files to be excluded from any git repository the owner of the new...
View ArticleEdit Media button within WYSIWYG should include media label for screen readers
Andrew Macpherson writes: The hidden text of the edit and remove buttons for an embedded media item should probably include the label of the item, to be more screen reader-friendly. See #2994702-53:...
View ArticleAccessibility problem with invisible buttons in AJAX dialogs
Problem/MotivationIn ajax dialogs, there is a accessibility issue with invisible duplicate buttons.When the dialog is created, the buttons are created in the dialog footer, which cause the original...
View ArticleMake Workspaces and Content Moderation work together
Problem/MotivationAt the moment, the Workspaces module can not be installed if Content Moderation is also installed, see #2971699: Content Moderation and Workspace don't work together.After #3027598:...
View ArticleTerminology wrong around "Request new password"
For several versions now we've kept the terminology "Request new password" for password recovery, whereas in fact we do a one-time login link. This discrepancy confuses the user and also tends to have...
View ArticleMedia library should not use js- prefixed CSS classes for styling
Problem/MotivationIn reviewing #3037668-17: Improve visual coherence of the media library, @lauriii had this to say:We shouldn't use js- prefixed classes for styling. Since this is just adding RTL...
View ArticleSupport PHPUnit 7 optionally in Drupal 8, while keeping support for ^6.5
Problem/MotivationThis issue is about allowing to optionally use PHPUnit ^7 to run tests in Drupal 8, while keeping support for PHPUnit ^6.5 .PHPUnit 6 is out of support since Feb 1, 2019. So we are...
View ArticleFunctionalJavaScript tests fail because newer versions of curl/selenium...
Problem/MotivationWith curl 7.66.0 instaclick/php-webdriver fail when testing with selenium/standalone-chrome with WebDriver\Exception\CurlExec: Webdriver http error: 400, payload :<h1>Bad...
View ArticleAdd a media library widget setting to only choose existing media
Problem/MotivationStory: A sitebuilder can configure the (gorgeous!) media reference widget so, that the user can a) only add media items b) only choose existing media items c) bothProposed...
View ArticleUnable to use layout builder - consumes all memory
For one of our node types http://test.genuki.uk/admin/structure/types/manage/genuki_church/display if I then click 'Manage layout' it spends a long time processing and then only produces a white...
View ArticleStop generating align-* classes for preview in DrupalMedia CKEditor plugin
Problem/MotivationSee #2994696-214: Render embedded media items in CKEditor, patch review point 2:🤔 In #25, this used to be more abstract: // Allow entity_embed.editor.css to respond to changes (for...
View Articleupdate from 8.6.15 to 8.7 fails due to menu_link_content
I get this error when i try to run the database update:Failed: Drupal\Core\Entity\EntityStorageException: The entity update process [error] failed while processing the entity type menu_link_content,...
View Article[PP-1] Constrain the width of aligned images, media, blockquotes etc to a max...
Problem/MotivationThis from feedback from @effulgentsia here #2801307-54: [META] Support WYSIWYG embedding of media entities:[...] add CSS along the lines of max-width: 75% on media that's aligned left...
View ArticleConvert media_library_update_8703() to a post-update hook
Problem/Motivationmedia_library_update_8703() was added in #3039829: Remove link to media item from media library view.. After commit, @catch said that it should have been a post-update hook.Proposed...
View ArticleConvey AJAX progress messages to assistive technology.
Problem/MotivationThe AJAX API has a feature to display a progress message, but it isn't conveyed to assisitive tech like screen readers.'#ajax' => array( 'callback' =>...
View ArticleAdd a Media library views template to Seven theme to change to order of the...
Problem/MotivationThis is a follow up of #2981044: Unify the grid/table views of the media library. From comment 45.2:The tabbing order of the view is messed up. The grid and table buttons come before...
View ArticleEditor::getFilterFormat() shouldn't cause fatal error before Editor saved
Problem/MotivationI keep finding myself writing code like this: if (!$editor->hasAssociatedFilterFormat()) { return; } $format = $editor->getFilterFormat(); if (empty($format)) { return; } I'd...
View ArticleMedia Library can delete user customizations to the media view and therefore...
Problem/MotivationFrom #2962110-119: Add the Media Library module to Drupal core:[media_library.install is] assuming the original media library view was never customized, but that's not safe. I moved...
View Article