Cannot swap tabledrag rows by dragging the lower over the upper row in tests
Problem/MotivationWhile working on #2757007: Convert all book web tests to BrowserTestBase, I discovered that, in a JavascriptTestBase test, it's impossible to swap 2 rows by dragging the lower over...
View ArticleLet GDToolkit support WEBP image format (for PHP 7.1+)
Problem/MotivationRelated to #2313075: Allow users to upload webp files in image fieldsSince webp is becoming popular, it would be nice if contrib could change the supportedTypes of GDToolkit without...
View ArticleAdd config page to Media Library's module info
Add the `config` key to the media library module info, so the settings page link appears in the description at admin/modules
View Article\Drupal\system\Entity\Action::setPlugin() is missing from...
Problem/Motivation\Drupal\system\Entity\Action::setPlugin() is not actually part of any interface, despite that its docblock uses {@inheritdoc}. /** * {@inheritdoc} */ public function...
View ArticleAdd sorting configuration to composer.json
Problem/MotivationWhen adding packages doesn't sort them in composer.json.Proposed resolutionAdd sort-packages:true in root composer.json and core/composer.jsonRemaining tasksAdd a patch.User interface...
View ArticleFix bug in \Drupal\rest\RequestHandler::createArgumentResolver and handle...
Problem/MotivationWe are skipping the deprecation. This is part of BC layer and it is hiding a bug in the \Drupal\rest\RequestHandler::createArgumentResolver(). If $unserialized is an array putting it...
View ArticleClik here to view.
TableDrag JS :first-of-type issues
In the docs for drupal_attach_tabledrag() it mentionsIn a more complex case where there are several groups in one column (such as the block regions on the admin/structure/block page), a separate...
View ArticleIntroduce a token to get site's base URL
Problem/MotivationWe currently have a token [site:url]. The URL of the site's front page. The language prefix is added if the page is multilingual (e.g. http://www.example.com/pl).In many cases a...
View ArticleSpelling mistake in views.api.php hook_views_query_alter
Small spelling mistake I noticed in hook_views_query_alter, the sentence: // If this is the part of the query filtering on title, chang theShould be change instead.
View ArticleConvert '_none' option to a constant and deprecate...
Problem/MotivationThe string '_none' is repeated throughout the module and tests, using a constant makes it easier to refactor.Proposed resolutionConvert _none to a constant.Move form_select_options()...
View ArticleRemove Migration::get()
Problem/Motivation\Drupal\migrate\Plugin\Migration::get() has been deprecated since Drupal 8.1. It is an artifact of the heady days when migrations were config entities, and was kept as a BC layer when...
View ArticleThe field schema incorrectly stores serial fields as int
Problem/MotivationThis was discovered in #2841291: Fix NOT NULL handling in the entity storage and 'primary key' changes when updating the storage definition of an identifier field. The field schema...
View ArticleLibraryDiscoveryParser overwrites theme CSS group ordering
My theme uses Bootstrap and I noticed I cannot change the library load order to appear before any module CSS libraries, no matter the group I specified (base, component, theme, etc.) - even if...
View ArticleAdd screen-reader assertions in FunctionalJavascript tests where beneficial
There is a @todo in \Drupal\Tests\media_library\FunctionalJavascript\MediaLibraryTestBase::pressInsertSelected to consider adding screen-reader assertions every time the method is called. That should...
View ArticleAdd a revision_parent field to revisionable entities
Problem/MotivationThis issue is part of the #2721129: Workflow Initiative. And #2786133: WI: Phase B: Extend the revision API with support for parents (the parent of this issue) is the first step...
View ArticleUse namespaced dependencies in .info.yml (field types modules)
Acc to https://www.drupal.org/node/2000204 .Dependencies should be namespaced in the format: {project}:{module} in .info.yml file.
View Article[IGNORE] Composer-friendly patches for filename sanitation while #2492171...
Problem/Motivation#2492171: [PP-1] Provide options to sanitize filenames (transliterate, lowercase, replace whitespace, etc) is blocked on #3032390: Add an event to sanitize filenames during upload...
View ArticleConvert views, views_ui module hook_help() to topic(s)
Problem/Motivation#3041924: [META] Convert hook_help() module overview text to topics for the views, views_ui module(s).Proposed resolutionTake the information that is currently in the hook_help module...
View ArticleClik here to view.
d7_node migration should have dependency on d7_node_title_label migration
Problem/MotivationIn HEAD, the d7_node_title_label migration runs much later than all d7_node:* migrations. While not wrong, this is … confusing.In HEAD, I first have to run d7_node_type, but then I...
View ArticleWhen importing configuration, enable modules' dependencies even if they...
Every once in awhile, a new dependency gets added to a module, for example #3084983: Move all the code related to path aliases to a new (required) "path_alias" module added path_alias as a dependency...
View Article