Throw an exception if the table doesn't exist in Schema::dropTable()
Problem/MotivationIf you see the first lines of the Schema::dropTable() method you will see that if there is not table no exception is thrown. if (!$this->tableExists($table)) { return FALSE; }...
View ArticleColor css files are not regenerated when deploying through configuration...
Problem/MotivationIf a theme's colour scheme is changed, a stylesheet (specifically colours.css and also logo.svg) is created in /sites/default/files/color/bartik-[hash]/ and a new directory with a...
View ArticleClik here to view.
Make views exposed filter operator labels configurable
Problem/MotivationCurrently, if you have a view with an exposed filter, and you expose the operator for it, the label is hard-coded to "Operator". The only way to change it is to implement a hook form...
View ArticleClik here to view.
Focus styling of WYSIWYG field inputs should be consistient with other intpus
Problem/MotivationStandard behavior for text-receiving inputs is a green text ring on focus. While focused, these inputs should still respond to hover in the same manner: a darker and slightly larger...
View ArticleBlock derivatives labels are always shown in the first language they are view...
Problem/MotivationIn Layout Builder, when you go to add a block to a section, and click "Create custom block", a list of links of the type of custom block content you want to add as a inline block...
View ArticleInvalid HTML for Field UI in Help Topics module
Typo - <me> instead of <em> - in field_ui.add_field.html.twig and field_ui.reference_field.html.twigThis causes three problems:The marked up text isn't set in italic - obviouslyWhen...
View Articleallow granular overriding of sql_mode options
It's possible to override the sql_mode options by doing this in your database definition in settings.php:$databases['drupal6_csp']['default'] = array ( 'database' => 'drupal8', 'username' =>...
View ArticleAdd timestamp to ban_ip table
Problem/MotivationBanning IP addresses permanently can have unintended consequences if an attacker uses a shared space, such as a coffee shop, to perform an attack. As such it would be helpful to...
View ArticleProperly deprecate SelectInterface::rightJoin
Problem/MotivationSelectInterface::rightJoin is deprecated since 8.1.xA proper deprecation message should be thrown in implementations, and deprecation test added.Proposed resolutionRemaining tasksUser...
View ArticleRequire Twig 3
Problem/MotivationSee also #3094493: Allow Drupal 9 to be installed with Twig 3.Proposed resolutionRemaining tasksKeep track of Twig 2 EOL date if/when it is announced.User interface changesAPI...
View Articleclass isn't set in FETCH_OBJECT when class_name isn't set
Hello,In StatementPrefetch if you are using fetchObject and pass in a class as the first parameter class_name does not get set and you get a ReflectionException.Attached is a patch to fix it. Let me...
View Article[meta] Requirements for tagging Drupal 10.0.0-beta1
Must-haves prior to tagging 10.0.0-beta1We can eventually file child metas for these, but a list is sufficient for now.Update or decouple/remove PHP (Composer) dependencies. Symfony: Make Drupal 9...
View ArticleFix hook_uninstall() example in core/lib/Drupal/Core/Extension/module.api.php
Problem/MotivationI first noticed this at #3039026-8: Deprecate file_directory_temp() and move to FileSystem serviceThe docs in core/lib/Drupal/Core/Extension/module.api.php are seriously weird for...
View ArticleIntroduce ENTITY_TYPE_list:BUNDLE cache tag and add it to single bundle listing
Problem/MotivationThere is ENTITY_TYPE_list cache tag and it is being invalidated very often. For example, if we have 20 different content types and created views page to display the list of content...
View ArticleHandle private import of files from subdirectories
I am migrating from a Drupal 7 site hosted on Pantheon to Drupal 8.8.4. I am using the migrate upgrade module and running the commands through drush.The public files all imported correctly, including...
View ArticleOption to have all php files outside of web root.
Traditional Drupal has an index.php at the root folder, and basically everything below that is web-accessible, only protected by .htaccess. Servers like lighttpd need separate configuration to achieve...
View ArticleAllow an install hook in profiles installing from configuration
Problem/MotivationIn #2788777: Allow a site-specific profile to be installed from existing config we excluded profiles from being installed that contain hook_install implementations.The reasons for...
View Article[Plan] Remove jQuery UI components used by Drupal core and replace with a set...
Problem/MotivationJQuery UI was added as a dependency for core 10 years ago to improve our UX. Since then majority of the frontend community has moved on to using other libraries. For that reason,...
View ArticleSupport enclosing reserved words with brackets.
Problem/MotivationDrupal 9 recently added the Connection::identifierQuote(). SQL Server does not use a single character to enclose reserved words. It uses square brackets. We need to be able to handle...
View ArticleEntity updates don't work for adding a bundle to an existing entity type
Problem/MotivationThe use case is very simple: you have an entity type which is not yet bundleable but was installed. In a subsequent effort, a bundle key and base field is added and the updates are...
View Article