Independent .status HTML class triggers message/icon styling
Follow-up to: #1838114: Change node form’s vertical tabs into details elementsProblemAny HTML element that has a .status class is styled with an icon (intended for status messages).
View ArticleHelper issue for "Field CMI"
Ignore this one for reviews, this is just to post new periodic patches for the conversion of field api to cmi, now starting with adding more properties to the config entity objects. Not for the faint...
View ArticleRequired alt tag missing on image alt tag input
Required * isn't present on required alt text. Probably same on the Title too.<div class="form-item form-type-textfield form-item-field-image2-fr-0-alt"><label...
View ArticleMatcherDumper::getFit() has an undefined variable
The current version of MatcherDumper::getFit() does not work though it seems to be that it's never called.MatcherDumper::dump() uses the implentation of RouteCompiler, so i'm wondering what to do.
View ArticleRouteProvider::getRouteByName() / RouteProvider::getRouteByNames() aren't...
If you have a look at RouteProvider::getRouteByNames() you can spot for example that $this->table is now $this->tableName.Other issues: array_intersect_key uses the wrong parameter,...
View ArticleMove Entity Reference Tests out of views folder
The tests for entity reference views plugins should be part of entity_reference.
View ArticleStop documenting methods with "Implements …"
Our current standard for documenting methods that implement part of an interface is noisy, prone to error, and does not provide any useful information to IDEs.It is a huge pain when you change a...
View ArticleDocument correction for field_ui_field_setting_form_submit()
Problem/MotivationThe inline documentation is miss leading. see attached patch.AttachmentSizeStatusTest resultOperationsfield_ui_field_setting_form_submit_correction.patch577 bytesIdleFAILED:...
View Articlefield_ui_settings_form_submit()doesn't exist
API page: http://api.drupal.org/api/drupal/core%21modules%21field_ui%21field_ui.ad...field_ui_settings_form_submit() doesn't exist, it should be field_ui_field_settings_form_submit() see #1906484:...
View ArticleTwig settings implementation: Show theme hook / template suggestions in HTML...
A follow-up to #1843034: Make Twig settings configurable, when debug is enabled, let's add our own custom debugging output as HTML comments wrapped around the template. The debugging output helps...
View ArticleModule's recommended branch not recognized by update manager
The update manager does not recognize the 2.x branch of Mollom as the recommended version. The maintainers of Mollom have checked that the 2.x. branch should be preferred over 1.x.See...
View ArticlePDOException: in statistics_exit() (line 93 of...
Not sure how serious is this or if I just need to ignore but thought worth reporting anyway.I'm getting PDOException: in statistics_exit() (line 93 of /modules/statistics/statistics.module) because of...
View ArticleString cleanup: remove similar but different strings
Hi,watchdog() and drupal_set_message() are using similar error messages for aggregator but with a small difference, and I'm proposing to use the same strings instead.All credits goes to Pomliane for...
View ArticleNewly created content types have broken field links in admin
Hi,The field management links (e.g. edit and delete operations, widget and field type links) and the redirects to field related pages (e.g. "Save and Add Fields" on content type creation) all seem to...
View ArticleMake locks objects that auto-release during garbage collection
Let's make the lock API more OO and more similar to the way database transactions are handled, like this: The return value from lock()->acquire() should be an object with $lock->renew() and...
View ArticleUsing a relationship in the UI fails completly
If you add a new relationship and then add a field using this relationship the views UI returns a PHP error and you are lost.
View Articledrupal Internal Zend error - Missing class information for condition has been...
I hadn't seen this error before so had to report it.PHP Fatal error: Internal Zend error - Missing class information for /**\n * Check whether a condition has been previously compiled.\n *\n *...
View ArticleUse TypedData for upcasting request arguments
PrerequisitesThis is a follow-up issue of #1798214: Upcast request arguments/attributes to full objects.Problem/MotivationIn #1798214: Upcast request arguments/attributes to full objects we started...
View ArticleToolbar should include links to 'flush all caches' and 'run cron'
the tool bar that comes shipped with drupal should include links to 'flush all caches' and 'run cron' - like admin_menu module does it,.
View Article