template_preprocess_links uses a non existent class JSON
This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from...
View Article[meta] Modernize forms to use FormBase
#2059245: Add a FormBase class containing useful methods provides an easier way to define forms. This issue is for going through existing forms and converting them.Callback nameIssueaction#2071485:...
View ArticleConvert $form_state to an object and provide methods like setError()
Updated: Comment #NProblem/MotivationLooking at validation function now, we have really unfortunate and confusing calls like:<?php if (!$url_is_valid) {...
View ArticleUse format_username() in node_feed()
Problem/MotivationUsernames printed by node_feed() can't be altered by other modules. In 7.x this is due to the omission of format_username().Proposed resolution8.x is being patched as part of #421586:...
View ArticleModernize contact.module forms
Follow-up from #2072251: [meta] Modernize forms to use FormBase.
View ArticlePHP notice when #attributes is not set with #theme_wrappers...
There's no real need for #attributes to be set for theme_container(), there's no harm in letting developers render a div without attributes.Errors like this just end up encouraging #prefix/#suffix...
View ArticleRemove comment_get_display_ordinal()
Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"
View ArticleRemove comment_get_display_page()
Meta issue: #2205673: [meta] Remove all @deprecated functions marked "remove before 8.0"
View ArticleRemove the array typehint from $form_state
Problem/MotivationThe array typehint on $form_state is completely useless. No one calls these directly so it doesn't help there, and since its an array typehint, it doesn't provide any further...
View Article[meta] Allow to use AJAX with GET requests
Problem summaryAJAX request size is very large. Out of the box in Drupal core it can be around 5k, on a reasonable site build using some contrib modules I have seen 15k+ HTTP requests. The size of the...
View ArticleExpand Category with methods
Part of meta-issue #2016679: [Meta] Expand Entity Type interfaces to provide methods.See the detailed explanations there and look at the issues that already have patches or were commited.Add get*, set*...
View ArticleClik here to view.
Undefined index: taxonomy_term in taxonomy_field_formatter_view()
Problem/Motivation1. Do a clean Drupal install. 2. Add a term to taxonomy "Tags". 3. Change content type Article, Manage Display, and set the Tags field to Hidden. 4. Go to create an Article node, set...
View Articlepointless assignment in EntityFieldQuery::finishQuery()
From https://api.drupal.org/api/drupal/includes!entity.inc/function/EntityFie... $this->ordered_results[] = $partial_entity;AFAICT this isn't used anywhere else, either in the class or in Drupal...
View ArticleDefine a standard mechaism for backend-aware service overrides
Suggested commit message:Issue #2302617 by dawehner | Crell: Define a standard mechaism for backend-aware service overrides.Problem/MotivationWe've poured thousands of hours of work into piecing apart...
View ArticleConvert language:weight into a protected property
#2226533: Changes to the Language class due to the LanguageInterface (followup) is proving troublesome to get to RTBC It has many small issues that when combined are proving difficult to get right, so...
View ArticleDatabaseSchemaObjectExistsException: Table already exists. in DatabaseSchema
Why do we have this exception? (and in general why does D7 have so much worse handling of things like this??)the error comes when a user tries to install a module which was previously installed and the...
View ArticleRemove support for function-based forms
Problem/MotivationWe've been slowly converting all forms to FormInterface. There aren't too many left, and once that is done we can remove the support for it once and for all.Proposed resolutionRemove...
View ArticleClik here to view.
Regression: checkbox to enable translation for users does not save
Enabling translation for users fails to save.Steps to reproduce: 1. install Drupal8. 2. enable language and content_translation modules. 3. navigate to Administration -> Configuration -> People....
View ArticleRename *.menu_links.yml to *.links.menu.yml files to improve DX
Problem/MotivationThis is the followup issue to #2291137: Rename various *links.yml files to improve DX.The change record.
View Article