Replace use of whitelist/blacklist in the path alias module
Problem/MotivationLets remove usage of "blacklist" and "whitelist" in the path alias module. They are:An historic bad labelling of peopleProvide no context: "what is listed in them"?Proposed...
View ArticleViews contextual filter's title override is invisible to TitleResolver
I'm not sure which component this relates to, so I just put other. Someone please feel free to update if you know the offending component.For the sake of a simple example, lets say we have a view...
View ArticleReplace use of whitelist/blacklist in \Drupal\Component\Utility\Xss and its...
Problem/MotivationReplace use of whitelist/blacklist in \Drupal\Component\Utility\Xss and its test and core/lib/Drupal/Core/Render/theme.api.phpThey are:An historic bad labelling of peopleProvide no...
View ArticleFind a proper way to manage including/excluding database-driver-specific tests
Problem/MotivationLastly discussed from #3098426-10: EntityQueryTest::testToString fails with non-core db drivers onwards, but really popped up several times already, + if...
View ArticleReplace use of whitelist/blacklist in file_munge_filename()
Problem/MotivationLets remove usage of "blacklist" and "whitelist" in file_munge_filename().They are:An historic bad labelling of peopleProvide no context: "what is listed in them"?Proposed...
View ArticleReplace use of whitelist/blacklist in \Drupal\Core\Extension classes and...
Problem/MotivationLets remove usage of "blacklist" and "whitelist" in \Drupal\Core\Extension classes and their testsThey are:An historic bad labelling of peopleProvide no context: "what is listed in...
View ArticleReplace use of whitelist/blacklist in \Drupal\Core\Security\RequestSanitizer...
Problem/MotivationLets remove usage of "blacklist" and "whitelist" in \Drupal\Core\Security\RequestSanitizer and its testThey are:An historic bad labelling of peopleProvide no context: "what is listed...
View ArticleReplace use of whitelist/blacklist in \Drupal\Core\Template classes and their...
Problem/MotivationLets remove usage of "blacklist" and "whitelist" in \Drupal\Core\Template classes and their tests.They are:An historic bad labelling of peopleProvide no context: "what is listed in...
View ArticleReplace use of whitelist/blacklist in \Drupal\Core\Utility\Error and its test
Problem/MotivationLets remove usage of "blacklist" and "whitelist" in \Drupal\Core\Utility\Error and its test.They are:An historic bad labelling of peopleProvide no context: "what is listed in...
View ArticleReplace use of whitelist/blacklist in \Drupal\Core\Utility\ProjectInfo and...
Problem/MotivationLets remove usage of "blacklist" and "whitelist" in \Drupal\Core\Utility\ProjectInfo and its testThey are:An historic bad labelling of peopleProvide no context: "what is listed in...
View ArticleReplace use of whitelist/blacklist in core/misc/autocomplete.es6.js and...
Problem/MotivationLets remove usage of "blacklist" and "whitelist" in core/misc/autocomplete.es6.js and core/modules/link/src/Plugin/Field/FieldWidget/LinkWidget.php. This is likely to need a...
View ArticleTrigger deprecation notifications for replaced Vendor classes
Problem/MotivationSometime we replace an implementation of a class in vendor with one in core, either because we've had to fork it from a dependency we're still planning to use, or because we've moved...
View ArticleDecouple from Symfony CMF
Problem/MotivationWe have Symfony CMF as a dependency, but we only really use four things from it:RouteEnhancerInterface RouteFilterInterfaceAlso the ROUTE_NAME and ROUTE_OBJECT constants from...
View ArticleFileSystemModuleDiscoveryDataProviderTrait needs to use DIRECTORY_SEPARATOR.
Any test that uses this trait fails on Windows.
View ArticleCreate a \Drupal\Component\Routing\ namespace and move Drupal-independent...
Problem/MotivationThe new route match is a concept which is not bound to drupal itself. On the other hand it is a great tool to decouple your code from needing the request in all kind of places.On the...
View ArticleWrite tests for: Users with passwords over 60 characters cannot log in via...
The issue was created to allow the use of passwords with length > 60. But that problem was fix somewhere in the development of D8 (see #9) and this issue changed to adding tests for that...
View ArticleClik here to view.
On Fifrefox 77 and Chrome 83 tabs are breaking in seven theme
Recently upgraded to Chrome V83 and the tabs are breaking when I use Seven as admin theme. ChromeVs SafariIt seems that this class is-horizontal is being removed from the nav tag Relevant twig is...
View ArticleInclude bootstrap.inc using composer
Problem/MotivationFunctions like t() are not bad and working around the availability for unit tests is a pain. We can include bootstrap.inc using composer and then tests etc will work without having to...
View ArticleClik here to view.
Text field with multiple values overflows on narrow screens
Problem/MotivationWhen adding a text field with multiple values, the text field will overflow over its designated area on narrow screens (the minimum width this happens is 780px).Proposed...
View ArticleRender API overview example of placeholders either incorrect or misleading
The Render API overview contains an example for how to use placeholders:https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...However, I think this example is incorrect on two...
View Article