Filtering multivalue reference fields to contain multiple specified values...
Hi. in jsonapi website write for multivalue field i can call this urlGET /comments?filter[post]=1,2 HTTP/1.1 i expect bellow query return only articles that have term 508 AND 511 but seems this query...
View ArticleExpose Layout Builder data to REST and JSON:API
Problem/MotivationWhen accessing Layout Builder overrides via REST (i.e. when accessing an overridden entity's layout field), the contents of sections appear empty.Proposed resolutionWe should add a...
View ArticleDuplicate template suggestions
Hello, I want to custom the output of users with twig suggestion, but I get the 2 times the suggestion "layout--onecol.html.twig" for the "One column" layout, so I can't use the...
View ArticleNotice: Undefined index: title in Drupal\update\ProjectSecurityRequirement
I suddenly got this weird error after adding a new text field to a taxonomy. I thought it had something to do with cache, but clearing cache didn't help. I also deleted the field I had created,...
View ArticleDuplicated joins in entity query
Entity query with condition and sorting by a field from the same table makes duplicated joins.My investigating: Class 'Drupal\Core\Entity\Query\Sql\Query' method getTables() always returns new...
View ArticleMigrate from Drupal 7 fails with mysql 8.0.3 or later: syntax error on select...
In mysql 8.0.3 "system" has become a reserved keyword.When you load a Drupal 7 database into mysql 8, the migrate module cannot access it. It tries to execute:select s.* from system;which fails with:...
View ArticleMake Drupal\Core\Database\Schema work with reserved keywords for naming
Problem/MotivationIn #2986452: Database reserved keywords need to be quoted as per the ANSI standard we fixed working with reserved keywords for queries. For the class Drupal\Core\Database\Schema there...
View ArticleException message when trying to print an object without __toString() in a...
@Berdir mentioned this issue to me today on IRC.Relevant code from twig.engine: if (is_object($arg)) { if (method_exists($arg, '__toString')) { return (string) $arg; } throw new Exception(t('Object of...
View ArticleViews permission not working for anonymous users
Hi all,Weird issue here.. I have Views Access Set to Permission | View Published Content.When an anonymous user views the content, nothing is shown. I verified anonymous users have the permission....
View Article[META] Replace all direct db calls to entity tables with Entity API
Problem/MotivationFollow-up to #2994904: Convert query('SELECT ... FROM {xxx}') to select('xxx')->... in tests Core should not use direct db calls to entity tables because they are managed by the...
View Article[meta] Replace assertions with more appropriate ones
See the overall status of the issues connected to this meta in the kanban board.Problem/MotivationWherever possible, use specific PHPUnit default assertions, that also provide standard messaging in...
View ArticleReplace assert*() involving equality comparison operators with...
Problem/MotivationAs titleProposed resolutionRegex for searching: >assert.*\(.*( == | === | != | !== )example:- $this->assertTrue($output == $expected, new FormattableMarkup('Token recognized in...
View ArticleReplace the database query with an entity query in UserInstallTest
Problem/MotivationThe test class in core\modules\user\tests\src\Kernel\UserInstallTest.php uses a regular database query instead of using an entity query.Proposed resolutionReplace the regular database...
View ArticleReplace usages of AssertLegacyTrait::assertResponse(), which is deprecated
Problem/MotivationAssertLegacyTrait::assertResponse() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->statusCodeEquals() instead. See...
View ArticleImprove exception messages when plugins cannot be found
Problem/MotivationCurrently, when a plugin cannot be found, we get this obtuse error message:Drupal\Component\Plugin\Exception\PluginException: The plugin (%plugin) did not specify an instance class in...
View ArticleClik here to view.
"Add more" field button rendered after form submit on modal layout...
Hi, I'm using Layout Builder Modal + Layout builder admin theme. When I use the default D8 administration theme (seven) everything works fine.If I enable "Claro" as admin theme I've a bug: I've created...
View ArticleConvert uasort to array_multisort in...
Problem/MotivationDue to a PHP bug (https://bugs.php.net/bug.php?id=50688), uasort is unsafe to use in many circumstancesSee #2762549: Drupal\field\Tests\Update\FieldUpdateTest,...
View ArticleFix grammar 'a' to 'an' when necessary
I see a lot of 'a' uses in comments instead of 'an'.Ex:a entitya alta authora image...Many modules and core files are concerned. I suggest to make all changes here instead of one issue per module since...
View ArticlegetDisplayLabel() on null in Drupal\profile\Entity\Profile->label()...
HI all,Normally I can find patches for these kind of "on null" errors, but I cannot find this one. And I am not confident enough to start changing things in the code yet. When I go to...
View ArticleAllow NULL default values in @Plugin annotations
Problem/MotivationRight now properties defined in annotations are discarding default values that are set to NULL. In other representations of data (PHP, YAML) we support NULLs. There's no reason not to...
View Article