Remove for PostgreSQL database driver the workaround for the Upsert class
Problem/MotivationThe minimum required version of PostgreSQL is 10. In the Connection class of the PostgreSQL driver we have the following code: public function upsert($table, array $options = []) { //...
View ArticleReplace usages of AssertLegacyTrait::assert(No)FieldByName, that is deprecated
Problem/MotivationAssertLegacyTrait::assertFieldByName() is deprecated in drupal:8.2.0 and is removed from drupal:10.0.0. Use $this->assertSession()->fieldExists() or...
View ArticleEntity reference fields can easily become stale (b/c of DataReferenceBase)
Entity reference fields internally use \Drupal\Core\Entity\Plugin\DataType\EntityReference, which extends \Drupal\Core\TypedData\DataReferenceBase. However, neither DataReferenceBase nor...
View ArticleFatal errors while loading/building orphaned comments
(Technically, this is not comment.module. I guess.)Problem/MotivationSuppose a comment is orphaned - e.g. its parent comment has somehow disappeared. Then the Drupal standard installation gives a...
View Article"Printer-friendly version" of unpublished book pages is blank
Steps to reproduce(description of the proposed solution, the rationale behind it, and workarounds for people who cannot use the patch)Enable book moduleCreate an unpublished book pageClick the...
View ArticleTranslations of nodes with comment settings field set to non-translatable...
Problem/MotivationIt is impossible to add a new translation in case the user wants to keep the same settings for comments across all translations of the node.Steps to reproduceInstall standardInstall...
View ArticleAccountForm should read pass-reset-token only from query string
Problem/MotivationWhile reviewed patch #2473875-75: Convert uses of $_SESSION to symfony session retrieved from the request\Drupal\user\AccountForm using pass-reset-token from request instead of query...
View ArticleVertical tabs summary is displayed only for browsers without HTML5 details...
Vertical tabs summary is displayed only for browsers without HTML5 details support (below the defined width breakpoint)Problem/MotivationThe summary of Vertical tabs items is not displayed below the...
View ArticleAccessibility bugs with vertical tabs
Problem/MotivationVertical tabs have the following accessibility issues:Drupal.verticalTab doesn't take care of the right aria attributes. Whatever happens, every details summary element (of a single...
View ArticleDerive path alias migrations per entity type (and bundle)
Problem/Motivation@todoProposed resolutionRemaining tasksUser interface changesAPI changesData model changesRelease notes snippet
View ArticleExpand LinkWidget test coverage
Problem/MotivationWhile triaging #2703713: core link field and token, @larowlan, @xjm, @pameeela and I agreed that we are missing some test coverage for the link field.For example cases...
View ArticleRemoving getFormObject call from UserAccountFormFieldsTest
Problem/Motivationprotected function buildAccountForm($operation) { // @see HtmlEntityFormController::getFormObject() $entity_type = 'user'; $fields = []; if ($operation != 'register') { $fields['uid']...
View ArticleAllow contributed modules (mostly database drivers) to override tests in core
Problem/MotivationLastly discussed from #3098426-10: EntityQueryTest::testToString fails with non-core db drivers onwards, but really popped up several times already, + if...
View ArticleFix grammar 'a' to 'an' when necessary
Problem/MotivationI see a lot of 'a' uses in comments instead of 'an'.Ex:a entitya alta authora image...Proposed resolutionMany modules and core files are concerned. I suggest to make all changes here...
View ArticleReplace use of whitelist/blacklist in \Drupal\Core\Template classes and their...
Problem/MotivationLets remove usage of "blacklist" and "whitelist" in \Drupal\Core\Template classes and their tests.They are:An historic bad labelling of peopleProvide no context: "what is listed in...
View ArticleReview updated Securing file permissions and ownership
Problem/MotivationThe page Securing files, and setting permissions (ORIGINAL) needs to be migrated to the new documentation system, so I have created a starting point for an updated version.Everything...
View ArticleDuplicated joins in entity query
Entity query with condition and sorting by a field from the same table makes duplicated joins.My investigating: Class 'Drupal\Core\Entity\Query\Sql\Query' method getTables() always returns new...
View ArticleReplace assert(Not)Equal() with assert(Not)Equals()
Problem/MotivationassertEqual() and assertNotEqual() is deprecated for removal in Drupal 10.0.0 as well.Proposed resolutionRemaining tasksUser interface changesAPI changesData model changesRelease...
View ArticleEntityResource tests assume no trailing slash in base URL
the SIMPLETEST_BASE_URL variable in phpunit.xml can be specified as http://localhost:8000 or http://localhost:8000/, with no difference in functionality in most tests.However, EntityResourceTestBase...
View ArticlePathAlias::preSave() trims the alias -- should it trim the path instead?
URL ending forward slash(‘/‘) breaks url alias(pretty url) paths.Admin area where users are able to make menu edit changes to menu links e.g. /admin/structure/menu/manage/main seem to break core...
View Article