Make TaggedHandlersPass compatible with PHP 8.0
See #3109885-11: [meta] Ensure compatibility of Drupal with PHP 8.0 (as it evolves) Fix PHP deprecationPHP Deprecated: Method ReflectionParameter::getClass() is deprecated in...
View ArticleUnexpectedValueException: External URLs do not have an internal route name....
Hi,Steps for reproduce this issue :-1. Create one node with url alias. 2. Create menu and put above node url alias in menu path. 3. Delete Path alias from url alias configuration. 4. Then go to fronted...
View ArticleReplace assertions involving calls to array_key_exists() with...
Problem/MotivationAs title.Proposed resolutionFor example: - $this->assertTrue(array_key_exists($route_name, $sample_routes)); + $this->assertArrayHasKey($route_name,$sample_routes);Remaining...
View ArticleUnused local variables from ConfigSchemaTest file
In core/tests/Drupal/KernelTests/Core/Config/ConfigSchemaTest.php file test method testSchemaMapping() found unused variable.I removed the following variable.$a =...
View ArticleChange static queries to dynamic queries in...
In core/tests/Drupal/KernelTests/Core/Database/UpdateLobTest.php file change static queries to dynamic queries in testUpdateOneBlob() and testUpdateMultipleBlob() methods.Problem/MotivationIn...
View ArticleReplace static queries with dynamic queries in InsertDefaultsTest.php file
In core/tests/Drupal/KernelTests/Core/Database/InsertDefaultsTest.php file change static queries to dynamic queries in testDefaultInsert(), testDefaultEmptyInsert() and testDefaultInsertWithFields()...
View ArticleDrupal\Core\Config\Entity\Query\Condition::notExists() does not work when...
Given the following code: $storage = $this->entityTypeManager->getStorage('group_type'); $group_type_ids = $storage->getQuery() ->notExists('third_party_settings.subgroup') ->execute();...
View ArticleShould Drupal 10 support migrating from Drupal 7?
Problem/MotivationSplit from #3118143: [meta] Release Drupal 10 in 2022.We released Drupal 8 without the migration path from Drupal 7 being finished, this was in November 2015.The Drupal 7 migration...
View Article\Drupal\Component\Datetime\DateTimePlus should pass correct parameter types...
Problem/MotivationIn \Drupal\Component\Datetime\DateTimePlus::checkArray() we do if (@checkdate($array['month'], $array['day'], $array['year'])) { $valid_date = TRUE; } The $array['month'],...
View ArticleChange static queries to dynamic queries in...
Problem/Motivation$result = $connection->query( 'SELECT name, value FROM {key_value_expire} WHERE collection = :collection', [ ':collection' => $collection, ])->fetchAll();Proposed...
View Article\Drupal\Component\Utility\Bytes::toInt() - ensure $size is a number type
Problem/Motivation\Drupal\Component\Utility\Bytes::toInt() passes a string value to round(). In PHP 8 this will trigger an error.Proposed resolutionCast the $size value to an integer or a float as...
View Article\Drupal\Core\Access\CsrfTokenGenerator::validate() - ensure $token is a...
Problem/MotivationIn \Drupal\Core\Access\CsrfTokenGenerator::validate() it's possible that $token returns something other than a string. In PHP 8 this causes a warning.Proposed resolutionEnsure that...
View Article\Drupal\Core\Database\StatementInterface::fetch() needs scalar typehints for...
Problem/MotivationUnder PHP 8 installing Drupal results in errors because \Drupal\Core\Database\StatementInterface::fetch() does not match \PDOStatement::fetch()Proposed resolutionIt seems that we can...
View Article\Drupal\Core\Render\Element\StatusReport::preRenderGroupRequirements() and...
Problem/Motivation\Drupal\Core\Render\Element\StatusReport::preRenderGroupRequirements() and \Drupal\user\PermissionHandler::sortPermissions() sorts return bools. As these a PHP user sort functions it...
View Article\Drupal\Core\Url ensure fragment is not an empty string
Problem/MotivationOn PHP 8 we need to ensure that the fragment is not set to an empty string. See the behaviour change https://3v4l.org/HsvX0Proposed resolutionGet the value before setting it.Remaining...
View ArticleChange \Drupal\error_test\Controller\ErrorTestController::generateWarnings()...
Problem/Motivation\Drupal\error_test\Controller\ErrorTestController::generateWarnings() does public function generateWarnings($collect_errors = FALSE) { // Tell Drupal error reporter to send errors to...
View ArticleResolve @todo: when https://www.drupal.org/project/drupal/issues/2999549 *...
Problem/MotivationThe @todo refers to the issue #2999549: Allow button tag in LinkGenerator for better accessibility. Its resolution was fixed:Proposed resolutionRemove the @todoRemaining tasksWrite a...
View ArticleAdd support for \GdImage objects
Problem/MotivationIn PHP 8.0 imagecreatefrom* functions no longer return a resource. They return a \GdImage object.Proposed resolutionChange \Drupal\system\Plugin\ImageToolkit\GDToolkit to support both...
View ArticleRemove uses of t() in clickViewsOperationLink(), helperButtonHasLabel() and...
Problem/MotivationThere is no need to use t() in tests, unless we're testing translations, however in core we do not follow this consistently, which does not set a good example for new contributions.In...
View ArticleUncaught PHP Exception...
Trying to set up a view in Drupal 8 I get always empty results. The logs say:Uncaught PHP Exception Symfony\\Component\\Routing\\Exception\\RouteNotFoundException: "Route "view.pages.feed_1" does not...
View Article
