Remove \Drupal\Core\Database\Connection::$statementClass
Problem/MotivationFollow-up for #3174662: Encapsulate \PDOStatement instead of extending from itSteps to reproduce\Drupal\Core\Database\Connection::$statementClass property is deprecated It should be...
View ArticleIntroduce HistoryRepository service
Problem/MotivationThe History service is sometimes slow and only works for the entity type node. All queries are hardcoded and cannot be replaced by contrib.Proposed resolutionIntroduce swappable...
View ArticleAccess to 'Reset to alphabetical' denied for users without...
Reset to alphabetical button is visible if users have access to edit all terms in a vocabulary, however reset route access is determined by whether the user has administer taxonomy. This means users...
View ArticleClik here to view.
Html::getId is outdated and has a few bugs as well
Problem/MotivationDrupal\Component\Utility\Html::getId cites the HTML4 standard but Drupal 8 is HTML 5 (yay!). HTML 5 is much more permissive https://mathiasbynens.be/notes/html5-id-class Even IE11 is...
View ArticleSet samesite cookie attribute for PHP sessions
Problem/MotivationDrupal 7 does not set the samesite attribute for PHP session cookies, unless on PHP 7.3 or higher. Up until recently, all major browsers treated cookies without this attribute as if...
View ArticleMake fallback date format editable rather than hard coding to US notation
Problem/MotivationDrupal has a "Fallback date format" which always uses the US notation: MM/DD/YYYY With Drupal being used a lot in non US projects this is actually a problem since the fallback format...
View ArticleIgnore 20 misspelled words used only in test fixtures
Problem/MotivationWe have added a spellcheck to Drupal core. The core and Media oEmbed test fixtures contain a number of words that are considered misspelled and only appear in these fixtures.Steps to...
View ArticleFix ~50 "shouldBeCamelCased" and relevant typos in core
Problem/MotivationDiscovered at #2972224: Add .cspell.json to automate spellchecking in Drupal core, and pointed by @xjm in https://www.drupal.org/project/drupal/issues/3122088#comment-13628724Becalled...
View Articlecomposer [Errorexception] mkdir(); Permission Denied
composer [Errorexception] mkdir(); Permission DeniedFresh install of everything, Ubuntu 20.04 PHP 7.4.3 Composer 1.10.8 Git 2.25.1Within the var/www/html directory, as per instructions on GITHUB, I run...
View ArticleRunning PHPUnit tests
Problem/MotivationI've followed the steps in this tutorial: https://mglaman.dev/blog/running-drupals-phpunit-test-suites-ddev but I'm finding my test always fails as the database connection used when...
View ArticleViewing uninstall page shouldn't fail if the entity table doesn't...
In ContentUninstallValidator we validate the state of each module to see if it has any data. To do so we query the table. However we don't first check that the table exists.This can mean that a bad...
View ArticleClik here to view.
Allow users to create a block content entity with a specific UUID if it is a...
#2756331: Custom blocks cannot be properly exported and imported is pretty nasty in therm of UX but apparently hard to fix.Basically, if you export a custom block configuration and import this...
View Article[meta] Ensure compatibility of Drupal 8/9 with PHP 8.0 (as it evolves)
Problem/MotivationMake sure Drupal keeps being compatible with PHP 8. Work with dependencies as needed. See #3086374: Make Drupal 8 & 9 compatible with PHP 7.4 for how we did it with PHP 7.4. PHP...
View Articlestream_open() needs to cope with a failure in...
Problem/MotivationPHP 8.0 is stricter about argument types and throws an error when fopen() is called with a $path === FALSE in \Drupal\Core\StreamWrapper\LocalStream::stream_open()Steps to...
View Article\Drupal\field\Entity\FieldStorageConfig::getCardinality() needs to be more...
Problem/Motivation\Drupal\field\Entity\FieldStorageConfig::getCardinality() does $enforced_cardinality < 1 without checking types. PHP 8.0 handles integer comparison a bit differently. This causes a...
View ArticleViews UI should offer a null/not null option on boolean field filtering to...
Problem/MotivationViews provides an option for filtering boolean fields on null/not null, but this is not exposed in the Views UI.Proposed resolutionExpose this code in the UI (from #2): if...
View Article\Drupal\views\Plugin\views\PluginBase::listLanguages() incorrectly uses...
Problem/MotivationRunning \Drupal\Tests\language\Kernel\Views\FilterLanguageTest() on PHP 8.0 fails because it does not return the ***LANGUAGE_language_content*** language.Steps to reproduceSee...
View ArticleMissing docblock for BookManagerInterface::getBookParents()
There is presently no docblock for method BookManagerInterface::getBookParents(). One will need to investigate exactly what is returned by classes that implement this interface and method. When...
View ArticleWarning: "continue" targeting switch is equivalent to...
full error messageWarning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in require_once() (line 341 of...
View ArticleViews are just showing content from Original Language but not Translation...
Hi,The "Link to Content" field on the view takes only the original language and all my views of the Multilingual sites broke. The links were functioning as expected till the update to 8.5 version . The...
View Article