node classes in the template not in the preprocess
Problem/MotivationGenerating css class in the preprocess makes it impossible to later change them. By moving them to the template a theme can define its own classes, that will make it easy to implement...
View Article[meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig...
Problem/MotivationFor phase 1 of the consensus banana, we need to move all classes from preprocess into the templates. This meta issue will serve as a place to list everything, discuss strategy, and...
View ArticleSimpletest fails to run PHPUnit on Windows and in extracted tarballs of Drupal
Follow-up to #2114823: Update PHPUnit to 4.xThe update to PHPUnit 4 moved the phpunit executable to a different location:/core/vendor/bin/phpunitHowever, the update was performed on a Linux platform,...
View ArticleRemove MigrateEntityDestinationFieldInterface
We thought it'll be needed for files. Turns out the process system is powerful enough. I am recommending removing it.
View ArticleReplace $form_state['input'] with FormState::getUserInput()
Problem/Motivation$form_state['input'] is very dangerous, it'd be good to have a method documented explaining that.Proposed resolutionRemaining tasksUser interface changesAPI changesCommit...
View ArticleRetain the destination url after preview
From #1510544: Allow to preview content in an actual live environment I did accidentally find one other bug in testing: if you're at admin/content, and select "Edit" next to a node in the list, then...
View ArticleLog completely unusable when an entry has corrupt serialized data
Notice: unserialize() [function.unserialize]: Error at offset 0 of 1634304 bytes in theme_dblog_message() (line 265 of xxxx/dblog.admin.inc).Recoverable fatal error: Argument 2 passed to t() must be an...
View ArticleClik here to view.
Allow to preview content in an actual live environment
ProblemNumerous tests from the Minnesota ones, to the Google one just recently discovered that people do not expect the preview to be shown within their administrative interface. In light of #1510532:...
View ArticleAdd a responsive preview bar to Drupal core
Problem/MotivationWhile previewing layouts at various screen and device dimension sizes is familiar to most front end developers and themers, the mechanics of this efforts may still be unknown or...
View ArticleInstaller broken on PostgreSQL (again)
Problem/MotivationMenuTreeStorage::doSave() wraps a transaction and throws an exception. The exception is not caught by the standard install and the batch process is broken.As well it is not guaranteed...
View ArticleUse container parameters instead of settings
ObjectiveGiven #2241633: Simplify site-specific service overrides, a services.yml file in the site directory is automatically picked up.Various services are environment-configurable via $settings in...
View ArticleHelper for #1805054
Helper for #1805054: [PP-2] Cache localized, access filtered, URL resolved, (and rendered?) menu trees.
View ArticleImprove (and shorten) documentation in default.services.yml
Follow-up to #2251113: Use container parameters instead of settingsProblemUnlike PHP comments in settings.php, excessively lengthy comments in services.yml do negatively affect the YAML parser...
View ArticleBetter help text for the "Alternative text" field in the Text...
Problem/MotivationFollow-up to #2307647-43: [Follow-up] Allow manual override of required image alt text in the Text Editor image dialog when appropriate to prevent it from getting derailed on...
View ArticlePHPUnit Tests namespace of modules is ambiguous with regular runtime...
Problem#2257769: Adding an Entity Reference field in the Field UI throws a PHP notice; fails to add field added this PHPUnit test to Path module:<?phpnamespace Drupal\path\Tests\Field;use...
View ArticleUse dynamic entity type upcasting for comment.reply
Problem/Motivation#1837388: Provide a ParamConverter than can upcast any entity. added the ability to upcast entities based on other route parameters.Proposed resolutionUse that for...
View ArticleProvide a ParamConverter than can upcast any entity.
This issue is a follow-up for #1798214: Upcast request arguments/attributes to full objects.The aforementioned issue provides a nice solution for upcasting single, isolated parameters in a route. In...
View ArticleRemove global DRUPAL_ROOT from phpUnit unit tests
#2252991: phpUnit tests for ModuleHandler adds DRUPAL_ROOT to the phpUnit bootstrap since it is so heavily used in our code base. As follow up, remove its use from other unit tests.
View ArticleUpdate to 7.28 -> 7.31 broke Drupal installation
Today I updated my Drupal installation from version 7.28 to version 7.31. I followed the same procedure I used for any other update. After I copied all the necessary files I visited my website to run...
View ArticleSeveral views still say they depend on block module but not anymore
Problem/MotivationAs found in #2309247: Views do not depend on modules providing their displays several views have block displays. The block displays were used to be provided by block module so a...
View Article