Replace hook_help() topic pages with config entities
Problem/MotivationCurrently, hook_help() has some funny logic in it. If your module's hook_help() responds to a $route_name set to "help.page.my_module_name", then it can provide a top-level topic,...
View ArticleTest that JS files added in hook_page_alter()/hook_page_build() are aggregated
If a module attaches JS files in hook_page_alter() the files are not aggregated.How to repro?1. Download latest Google Analytics 7.x 2. Enable JS aggregation 3. JS file...
View ArticleUpdate stale references to theme functions that have been converted to Twig
This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from...
View ArticlePort HTTP Host header DoS fix from SA-CORE-2014-003
See https://www.drupal.org/SA-CORE-2014-003The original patch against D7 is attached.Symfony\Component\HttpFoundation\Request::getHost() is safe to use in terms of a DOS, but it does not check hostname...
View ArticleWidgetFactory is not used anywhere so it should be removed
We need to be able to inject services from the container into the WidgetFactory. See #2017851: Move entity_reference_get_selection_handler() to a method on SelectionPluginManager for an example of where.
View ArticleResponsive Image Mappings :: throws a fatal exception if no image style is set
Steps to reproduce: * create a responsive image mapping * do NOT select an image style * view the node - it will throw an exception:Fatal error: Call to a member function buildUrl() on a non-object in...
View ArticleAdd a PHPunit test for not using Drupal\Core code in Drupal\Component
Child issue of #1929270: [meta] Drupal-agnostic components should not be calling Drupal functionsThe issue might be fixed, but adding an automated test is a nice way to avoid regressions
View ArticleHelper issue for #2164601 - stop auto-creating FieldItems
#2164601: Stop auto-creating FieldItems on mere reading of $entity->field[N]
View ArticleMove theme/render hooks from system.api.php to theme.api.php
On #2299715: [meta] Move core hooks from system.api.php to core.api.php an inventory was done of hooks in core/modules/system/system.api.php that are not related to the System module per se.The...
View ArticleClik here to view.
Improve views field rendering performance by caching entity display objects
While profiling a views table, berdir showed me that we actually create a new display object for every field. Since the only state required to build the object is bundle, field, and display options, it...
View ArticleSetting cache tags can be tricky: use strings instead of nested arrays to...
Problem/MotivationProblems with the current system:Any code does ['foo' => TRUE'], then any other code no longer can do ['foo' => [35 => 35]]. We've had core bugs because of that.If the $tags...
View ArticleREST views contains user password hash and other sensitive information
Problem/MotivationSerializer returns hashed user password when accessing user entity GET resource. This is because Password field is a string.Proposed resolutionMake the serializer drop the password...
View ArticleUndefined index _field_info_prepare_instance_widget
_field_info_prepare_instance_widget() was throwing errors in RC1 and continues to do so in RC1. If I clear the cache I get:Notice: Undefined index: module in _field_info_prepare_instance_widget() (line...
View ArticleAdd another responsive tables solution that doesn't hide content
Problem/MotivationIn #1276908: Administrative tables are too wide for smaller screens we added a method for resizing tables for smaller screens that hides columns. This works until you get to a point...
View ArticlePath alias validation should test for relative path, no trailing slash...
Problem/MotivationThe path alias field description says, "Use a relative path without a trailing slash" because doing the contrary of either of those things will result in a non-functional alias, but...
View ArticleField default markup - removing the divitis
Problem/MotivationThe markup that is produced for a field is having a serious case of divitis - Looking at the discussions and the principles we build the frontend on for twig, that is wrong(tm)The...
View ArticleImplement StackNegotiation
Proposed commit message:Issue #2331919 by dawehner, Crell, rpayanm, Fabianx | damiankloip: Implement StackNegotiation.Problem/MotivationOnce #2303673: Implement stackphp; cleanup handlePageCache() and...
View ArticleAdd PHPUnit tests for Config class
Problem/MotivationThere are no PHPUnit tests for the config classRemaining tasksCreate PHPUnit tests to check that the config class is working as expected
View ArticleAdd content dependency information to configuration entities
Problem/MotivationConfiguration can depend on content entities. For example:The default value of an entity reference fieldA views filterThe placement of a custom blockThe custom block example is...
View Article#states not supported for elements in formatter settings being displayed on...
If I have a formatter settings element that uses #states, the form element names that I set there that are standardized in field UI, are different from the form elements that are output when displayed...
View Article
