When a content entity type providing module is uninstalled, the entities are...
Problem/MotivationEntities with missing modules will result in fatal errors everywhere.Proposed resolutionAdd an uninstall validate method to the module_installer service added in #2324055: Split up...
View ArticleReplace fake mocks with actual OpenDialogCommand stubs in AjaxCommandsTest
Problem/MotivationThere are two fake mocks used in AjaxCommandsTest that can be completely removed if PHPUnit mocks are used instead.Proposed resolutionRemove the fake mock...
View ArticleFind hidden configuration schema issues
Problem/MotivationWe attempted to introduce configuration schema for all configuration in Drupal core (with exception of some test configuration). We maintained that configuration schemas are optional...
View ArticleClean-up Comment module Test members - ensure property definition and use of...
The comment module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be...
View ArticleRevise Bartik template indentation inline with best practices.
Problem/MotivationBartik theme templates are incorrectly indented making readability poor. The templates need to be structured to follow best coding practises.For eg.<div id="messages"><div...
View Articledocument queue worker callback
This is a fairly simple callback, but it does have the ability to throw exceptions. There's also a patch for 8.x to have it through different classes of exception, which will add complexity. Hence...
View Article#states are applied twice on same element
Problem/MotivationWhen using a CTools modals to create a custom form, the CTools call to Drupal.attachBehaviors()Â results in #states (Form API) being applied twice. Specifically, the original poster...
View Articlenode_help() broken for node add/edit form
Problem/Motivationnode_help() does this:<?php$type = $node->getType();return (!empty($type->help) ? Xss::filterAdmin($type->help) : '');?>$node->getType() returns the name of the node...
View ArticleReplace static SessionManager::$enabled property with...
Problem/MotivationThere is still the static SessionManager::$enabled property which does not need to be static anymore after #2272987: Do not persist session manager landed. Also there is an implicit...
View ArticleRegister symfony session components in the DIC and inject the session service...
Problem/MotivationIn #2205295: Objectify session handler and #2228341: Objectify session management functions + remove session.inc the procedural code from session.inc has been converted to...
View ArticleImageStyle to be accessible from ImageEffect plugins
Problem/MotivationAt the moment it is possible to set/getThirdPartySetting on the image style, but they are not visible to the effects.Proposed resolutionIntroduce an ImageStyleAwareInterface and trait...
View ArticleMake the class variables protected for Migration
Migration class variables should not be accessed directly. Functions should be use to access the variable. For instance use getDescription() and setDescription($description) for the protected class...
View ArticleUpdate stale references to theme functions that have been converted to Twig
This issue has novice tasks. If you are an experienced core developer and have multiple commit mentions, please review novices' work on these tasks rather than doing them yourself. Feedback from...
View ArticleBase entity fields using 'standard' plugin added via...
Problem/MotivationViews uses EntityViewsData and sub-classes to generate views data for entity base fields. The bulk of these use the 'standard' plugin which extends from HandlerBase....
View ArticleClik here to view.
The node preview bar is not usable without Bartik
Follow-up to #1510544: Allow to preview content in an actual live environmentProblem/MotivationThe 'theming' styling for the node preview bar is within Bartik's style.css. This includes the background...
View ArticleER's label formatter needs to take into account that...
I get "Drupal\Core\Entity\Exception\UndefinedLinkTemplateException" on adding an Entity Reference of type Action such as "Make content sticky", and then saving gives an Error.In a fresh install, in...
View ArticleClik here to view.
Tweak the design of the node preview bar to align with the Seven style guide...
Follow-up to #1510544: Allow to preview content in an actual live environmentProblem The current node preview bar looks like this:Proposed resolutionChange the styling of the button to match the Seven...
View ArticleAllow forms to set custom validation error messages on required fields
Updated: #175 From Bowersox on #171 Status Summary In comment 120, @webchick committed the D8 patch. This added the new API, which is good. Folks started working on the D7 backport. But...
View ArticleClean-up editor module test members - ensure property definition and use of...
The editor module uses Test class members with underscored names. Some examples are big_user, web_user and admin_user, but there could be others. According to our coding conventions, these should be...
View ArticleMove Drupal\Tests\Component\Image\ImageUtilityTest to...
the namespace and naming is not consistent with rest of the core
View Article