Config::$name not validated properly
In the Config class, Config::$name is supposed to be restricted in length and character set. But this is never checked until you try to save() the object, at which point it's too late to do anything...
View Articlehook_help(): Top of page help sections can't link to help pages without...
Updated: Comment #NProblem/MotivationWe currently have two kinds of in-Drupal help:a) Module-level help, which is displayed as topics at admin/help, one per module that defines it via hook_help().b)...
View ArticleMissing Page Number token
Tokens for Drupal 5 & 6 came with a token for the Page Number. This exposed the ?page=1 part of the URL (for pages with pagers on them) as a single numeric token which could be used with modules...
View ArticleA custom menu block is not shown for not logged users.
If create a custom menu and add a custom menu block to some region then the block will not shown for not logged users. But, embedded menu blocks are show correctly, for example a Footer menu.
View ArticleUse proper methods instead of directly calling $file->filename and...
Updated: Comment #NProblem/MotivationWhile reviewing #1815504: file_save_upload() should not alter the file URI string before validation, I found that file_save_upload() uses $file->filename and...
View ArticleDynamic local actions no more refreshed after router rebuild
Prior to D8-beta3, I implemented dynamic menu local actions using a deriver and callbacks in module.links.action.yml:# Dynamic local actions for entitygroup types with custom menus.entitygroup.dynamic:...
View ArticlePatch testing issue
THIS ISSUE IS NOT FOR REVIEW. This is a place holder to: 1. Test patches that are passing in local and not in d.o. 2. Demo d.o workflow, review patch, using d.o tools (like dreditor).Check This is...
View ArticleUpdate Module Twig Clean Up
Problem/MotivationRight now there is a single cell table in the update module code that doesn't need to be a table. There is no sorting/select/dragdrop on the this table and therefore doesn't need a...
View ArticleAdd path alias to user edit
Problem/MotivationProposed resolutionRemaining tasksUser interface changesAPI changesOriginal report by @catchIf you want to change the path alias for a user, you have to first find the user and their...
View Article[meta] Refactor and remove as many SafeMarkup::set() calls as possible
Follow-up to #1825952: Turn on twig autoescape by defaultProblem/MotivationSafeMarkup::set() is mostly for internal use only. For the most part, existing APIs like t(), String::checkPlain(),...
View ArticleContent translation access hooks not being fired
Problem/Motivationcontent_translation_add_access(), content_translation_edit_access() and content_translation_delete_access() are not being fired for me when adding, editing or deleting a...
View ArticleClean up deprecated usages of drupal_alter, module_invoke and module_invoke_all
Just some code tidy up to remove usage of the above in core
View ArticleClean up Minimal profile modules
Problem/MotivationThe cumulative result of #1806334-191: Replace the node listing at /node with a view doesn't make much sense.Proposed resolutionWe could 1) Add Views, or 2) Remove Node, or 3) Both,...
View ArticleAdding drupal_add_tabledrag() support for parents with depth 0
When the max depth is set to 2 or more levels, the tree renders all of the values irrespective of the depth, and when a value is clicked, the depth of that value is automatically adjusted to the set...
View ArticleMore info needed in hook_views_data docs/sample body
There is a bunch of information about how to do table joins in the Advanced Help for Views 7, topic "api-tables.html", which is not in hook_views_data() for Drupal 8.This is fairly essential...
View ArticleRemove Unused local variables from the Views module
Part of meta-issue #2002650: [meta] improve maintainability by removing unused local variablesFile /core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.phpLine 855: Unused local...
View ArticleMove LinkGenerator out of Drupal\Core\Utility
Problem/MotivationDrupal\Core\Utility is filled with classes that have all static methods, most of which have no external dependencies. LinkGenerator is a service.We've made a distinction Services and...
View ArticleMove interface out of plugin folders
Updated: Comment #1Problem/MotivationFrom #2151829-13: Doctrine annotation parsing takes an unacceptable amount of time/memory on install. There's no need to parse an interface for annotations.Here's a...
View ArticleShow DB Connection on Status Page
List the actual name(s) of the connected database(s) on the status page. Could be very handy when copying sites for testing purposes. Can prevent changing the wrong database!
View Article[policy, no patch] 8.0.0 release candidates, release, patch versions, 8.1.x
@todo: needs a diagram if possible, and some restructuring.Drupal 8 is currently in beta: https://www.drupal.org/node/2350615The next possible milestone is supporting a beta to beta upgrade path, see:...
View Article