Warning: strpos() expects parameter 1 to be string, array given in Drupal\jsonapi\Routing\Routes::isJsonApiRequest() (line 268 of core/modules/jsonapi/src/Routing/Routes.php).
Implement a route subscriber and provide a controller callable in array form (e.g., [MyClass::class, 'method'] or [$object, 'method`]).
Getting below error when adding/ editing menu link from group content menu after update from Drupal 10.1.7 to Drupal 10.2.0
Error: Call to a member function label() on null in Drupal\menu_link_content\Form\MenuLinkContentForm->form() (line 99 of /var/www/html/docroot/core/modules/menu_link_content/src/Form/MenuLinkContentForm.php).
1. Install group content menu.
2. Install group as well.
3. Then, Create menus type under the group content menu.
4. Now, Install the menu for the group type under the group content setting.
5. Try to add new link on group menu.
text_format_wrapper print `attributes` to the description what ends in uninterpretable aria attribute.text/drupal.text library) uses theme-provided classes for it's operations which may be broken in custom themes.Fix text_format_wrapper by printing attributes to the main wrapper and providing the missing attribute for the description.
Add js classes to the TextareaWithSummaryWidget for the text/drupal.text library (where text/drupal.text is attached).
Provide a patch with test.
Nothing.
None.
Nothing.
@Todo
vendor/bin/drush config:inspect --filter-keys=text.settings --detail --list-constraints
➜ 🤖 Analyzing…
Legend for Data:
✅❓ → Correct primitive type, detailed validation impossible.
✅✅ → Correct primitive type, passed all validation constraints.
------------------------------------------ --------- ------------- ------ ------------------------------------------
Key Status Validatable Data Validation constraints
------------------------------------------ --------- ------------- ------ ------------------------------------------
text.settings Correct 75% ✅❓ ValidKeys: '<infer>'
text.settings: Correct Validatable ✅✅ ValidKeys: '<infer>'
text.settings:_core Correct Validatable ✅✅ ValidKeys:
- default_config_hash
text.settings:_core.default_config_hash Correct Validatable ✅✅ NotNull: { }
Regex: '/^[a-zA-Z0-9\-_]+$/'
Length: 43
↣ PrimitiveType: { }
text.settings:default_summary_length Correct NOT ✅❓ ⚠️ @todo Add validation constraints here
------------------------------------------ --------- ------------- ------ ------------------------------------------
As image shown, the admin toolbar navigation menu arrow disappaers.
remove the background-color of is-active class.
.toolbar .toolbar-tray .menu-item--active-trail > .toolbar-box a,
.toolbar .toolbar-tray a.is-active {
color: #000;
background-color: #f5f5f5;
font-weight: bold;
}
vendor/bin/drush config:inspect --filter-keys=user.settings --detail --list-constraints
➜ 🤖 Analyzing…
Legend for Data:
✅❓ → Correct primitive type, detailed validation impossible.
✅✅ → Correct primitive type, passed all validation constraints.
----------------------------------------------------- --------- ------------- ------ ---------------------------------------------------------------------------------------------
Key Status Validatable Data Validation constraints
----------------------------------------------------- --------- ------------- ------ ---------------------------------------------------------------------------------------------
user.settings Correct 84% ✅❓ ValidKeys: '<infer>'
user.settings: Correct Validatable ✅✅ ValidKeys: '<infer>'
user.settings:_core Correct Validatable ✅✅ ValidKeys:
- default_config_hash
user.settings:_core.default_config_hash Correct Validatable ✅✅ NotNull: { }
Regex: '/^[a-zA-Z0-9\-_]+$/'
Length: 43
↣ PrimitiveType: { }
user.settings:anonymous Correct Validatable ✅✅ Regex:
pattern: '/([^\PC])/u'
match: false
message: 'Labels are not allowed to span multiple lines or contain control characters.'
NotBlank: { }
↣ PrimitiveType: { }
user.settings:cancel_method Correct NOT ✅❓ ⚠️ @todo Add validation constraints here
user.settings:langcode Correct Validatable ✅✅ NotNull: { }
Choice:
callback: 'Drupal\Core\TypedData\Plugin\DataType\LanguageReference::getAllValidLangcodes'↣ PrimitiveType: { }
user.settings:notify Correct Validatable ✅✅ ValidKeys: '<infer>'
user.settings:notify.cancel_confirm Correct Validatable ✅✅ ↣ PrimitiveType: { }
user.settings:notify.password_reset Correct Validatable ✅✅ ↣ PrimitiveType: { }
user.settings:notify.register_admin_created Correct Validatable ✅✅ ↣ PrimitiveType: { }
user.settings:notify.register_no_approval_required Correct Validatable ✅✅ ↣ PrimitiveType: { }
user.settings:notify.register_pending_approval Correct Validatable ✅✅ ↣ PrimitiveType: { }
user.settings:notify.status_activated Correct Validatable ✅✅ ↣ PrimitiveType: { }
user.settings:notify.status_blocked Correct Validatable ✅✅ ↣ PrimitiveType: { }
user.settings:notify.status_canceled Correct Validatable ✅✅ ↣ PrimitiveType: { }
user.settings:password_reset_timeout Correct NOT ✅❓ ⚠️ @todo Add validation constraints here
user.settings:password_strength Correct Validatable ✅✅ ↣ PrimitiveType: { }
user.settings:register Correct NOT ✅❓ ⚠️ @todo Add validation constraints here
user.settings:verify_mail Correct Validatable ✅✅ ↣ PrimitiveType: { }
----------------------------------------------------- --------- ------------- ------ ---------------------------------------------------------------------------------------------
I have an entity query_alter that was adding a cacheable metadata to a jsonapi response and before it was working and now I get: `LogicException: The controller result claims to be providing relevant cache metadata`, any ideas? I am altering the json query by a passed argument on the url and I want that resource to be be varied by that url argument, but it seems I should not be adding it on the query alterer now, which would be the proper way?
I am/was doing this on
function microsite_query_entity_query_alter(Drupal\Core\Database\Query\AlterableInterface $query) {
$request = \Drupal::requestStack()->getCurrentRequest();
$renderer = \Drupal::service('renderer');
if ($request->isMethodCacheable() && $renderer->hasRenderContext()) {
$build = ['#cache' => ['contexts' => ['url.query_args:microsite_site']]];
$renderer->render($build);
}
}
This stopped to work after recent upgrades to core/jsonapi.
@wimleers asked
What code path in JSON:API is triggering your code to be executed? JSON:API should have the appropriate “run entity queries in a render context so it can detect bubbled cacheability and associate it with the resulting response” logic in place. If it doesn’t, that’d be a bug.
I answered: Does this answer your question https://pastebin.com/T0RvpbX3? The first path I actually now see that it’s captured and bubbled up, however the others (one per media entity) are not. Please ignore the `microsite` controller. It’s currently a bare decorator for the jsonapi controller service to add the cache context on an overridden `buildWrappedResponse()` (PoC from yesterday), but I rather not have to do something like this.
He said yes and asked to fill in a ticket, so here it is.
In the end I removed the decorator end ended up replacing the whole jsonapi.entity_resource service with the same `buildWrappedResponse()` overridden to add my needed context but not to have to override also the constructor on the decorator.
From Slack: https://drupal.slack.com/archives/C6DJEP1EK/p1556217296004400 (likely to be lost in the backscroll noise but here for reference)
CKEditor 5 changes the HTML Structure almost immediately. This doesn't affect the pre-existing HTML structure of different pages until and unless we open those respective nodes in /edit mode.
<div class="social-media">
<span>Share</span>
<span class="icon">
<a href="#" target="_blank" rel="noopener">
<em class="fa-fw fa-twitter fab"> </em>
</a>
</span>
</div><div class="social-media">
<span>Share</span>
<a href="#" target="_blank" rel="noopener">
<em class="fa-fw fa-twitter fab">
<span class="icon"> </span>
</em>
</a>
</div>Make sure that the HTML Structure doesn't get changed.
\Drupal\workspaces\Plugin\Validation\Constraint\EntityWorkspaceConflictConstraintValidator was written in a time when we didn't have the workspace association service, which is easier to query and faster then getting the latest revision ID of an entity (and loading it afterwards).
Stop checking the latest revision of the edited entity, and check the workspace association index instead.
Review.
Nope.
Nope.
Nope.
Nope.
There are number of entries inserted in cachetags database table while user submitting the form. Currently we do not want to invalidate the cachetags on every submission as we are sending the data to thirdparty.
Is there a way to stop cachetags invalidation on webform submit ?
* The following defaults are provided:
* - label: Random string.
* - id: Random string.
* - region: 'sidebar_first'.
* - theme: The default theme.
* - visibility: Empty array.
What does an empty array mean for visilibity? Visible everywhere or nowhere? The docs should say.
Longstanding core module statistics is being deprecated and removed from core, following #3413917: Deprecate the Statistics module, #3340834: [meta] Tasks to deprecate Statistics and other related issues.
Because statistics is still used by many sites, 5% to 9% depending on which numbers you want to, that means at least 800k*5% = 40k sites, presumably smaller ones not using data-grabbing third-party SaaS, it needs at the very least to be preserved.
Because it has received comparatively little attention over the years, it also needs to be improved, and there are multiple directions for that.
Not applicable. Temporary repo until official project is created is hosted at https://github.com/fgm/statistics
TBD.
TBD, but at least a default Views page for current stats and later a default Views page for longitudinal stats.
TBD, but probably a lot.
TBD, but probably a lot. A move to the extended K/V API is likely.
TBD.
It seems that adding defaultProperties does not take effect after saving the content initially. You might notice that it shows the default values initially, but when you save or view the table, you will see that it changes its formatting, causing the content toolbar to not recognize the manually changed values.
Adding to docroot/core/modules/ckeditor5/ckeditor5.ckeditor5.yml the following
ckeditor5_table_properties:
ckeditor5:
plugins:
- table.TableProperties
config:
table:
contentToolbar: [tableProperties]
tableProperties:
defaultProperties:
borderStyle: 'double'
borderColor: 'hsl(0, 0%, 70%)'
borderWidth: '1px'
width: '500px'
height: '100%'and
ckeditor5_table_cell_properties:
ckeditor5:
plugins:
- table.TableCellProperties
config:
table:
contentToolbar: [tableCellProperties]
tableProperties:
defaultProperties:
borderStyle: 'solid'
borderColor: 'hsl(0, 0%, 75%)'
borderWidth: '1px'or using
function my_module_ckeditor5_plugin_info_alter(array &$plugin_definitions) {
if (isset($plugin_definitions['ckeditor5_table_cell_properties'])) {
$table_plugin_definition = $plugin_definitions['ckeditor5_table_cell_properties']->toArray();
$table_plugin_definition['ckeditor5']['config']['table']['tableCellProperties']['defaultProperties'] = [
'borderStyle' => 'solid',
'borderColor' => '#000',
'borderWidth' => '1px',
];
$plugin_definitions['ckeditor5_table_cell_properties'] = new CKEditor5PluginDefinition($table_plugin_definition);
}
}#3362276: Use position: sticky for views sticky table header introduced position: sticky to replace the JS workaround with duplicating the header.
But this technique has currently one big flaw: when placed within e.g. tabs which uses overflow it will not work, as sticky does not go well with overflow set to anything else than visible.
Check out a table within tabs
E.g.:
- install webform module
- enable webform and webform_templates submodule
- go to /admin/structure/webform/templates
- scroll down and check sticky header
Either find a workaround or remove overflow from elements like tabs
The States API won't pick up the value of a select field with #multiple = TRUE option.
Steps to reproduce:
- Create two fields in a form with the following code:
$form['dependee'] = array(
'#type' => 'select',
'#options' => array(
'a' => 'Option A',
'b' => 'Option B',
'c' => 'Option C',
),
'#multiple' => TRUE,
);
$form['dependent'] = array(
'#type' => 'textfield',
'#states' => array(
'visible' => array(
'select[name="dependee[]"]' => array('value' => array('a')),
),
),
);
The dependent field will stay hidden regardless of the value of the dependee. This happens because the value of a multiple select field is an array, and States tries to compare it with the reference with a === operator, which returns always false.
Add a handler for arrays in states.Dependent.comparisons. This works with ANDed values:
'select[name="dependee[]"]' => array('value' => array('a', 'b')),
and with ORs as well (following the syntax proposed in #735528: FAPI #states: Fix conditionals to allow OR and XOR constructions):
'select[name="dependee[]"]' => array(array('value' => array('a')), array('value' => array('c')))
This feature finally works as intended:
N/A
N/A
TBD.
This is a list of issues to convert various core components to use Single Directory Components
field ui settings has 1 property path that is not yet validatable:
./vendor/bin/drush config:inspect --filter-keys=field_ui.settings --detail --list-constraints --fields=key,validatability,constraints
➜ 🤖 Analyzing…
---------------------------------------------- ------------- ------------------------------------------
Key Validatable Validation constraints
---------------------------------------------- ------------- ------------------------------------------
field_ui.settings 75% ValidKeys: '<infer>'
field_ui.settings: Validatable ValidKeys: '<infer>'
field_ui.settings:_core Validatable ValidKeys:
- default_config_hash
field_ui.settings:_core.default_config_hash Validatable NotNull: { }
Regex: '/^[a-zA-Z0-9\-_]+$/'
Length: 43
↣ PrimitiveType: { }
field_ui.settings:field_prefix NOT ⚠️ @todo Add validation constraints here
---------------------------------------------- ------------- ------------------------------------------
11.x.composer require drupal/config_inspector— or manually install https://www.drupal.org/project/config_inspector/releases/2.1.5 or newer (which supports Drupal 11!)composer require drush/drushvendor/bin/drush config:inspect --filter-keys=field_ui.settings --detail --list-constraintsAdd validation constraints to:
field_ui.settings:field_prefixThis requires looking at the existing code and admin UI (if any) to understand which values could be considered valid. Eventually this needs to be reviewed by the relevant subsystem maintainer.
For examples, search *.schema.yml files for the string constraints:😊
Reach out to @borisson_ or @wimleers in the #distributions-and-recipes.
field_ui.settings:field_prefixNone.
More validation 🚀
None.
As mentioned in the parent issue #3238306: [META] Where possible, refactor existing jQuery uses to vanillaJS to reduce jQuery footprint, we are working towards reducing our jQuery footprint. One of the ways to accomplish this is to reduce the number of jQuery features used in Drupal core. We have added eslint rules that identify specific features and fail tests when those features are in use.
There are (or will be) individual issues for each jQuery-use eslint rule. This one is specific to jquery/no-prop, which targets the jQuery prop function.
In core/.eslintrc.jquery.json Change "jquery/no-prop": 0, to "jquery/no-prop": 2, to enable eslint checks for uses of jQuery prop(). With this change, you'll be able to see uses of the undesirable jQuery feature by running yarn lint:core-js-passing from the core directory.
Replace usage of jQuery.prop with vanilla js alternatives.
N/A
N/A
N/A
N/A
As mentioned in the parent issue #3238306: [META] Where possible, refactor existing jQuery uses to vanillaJS to reduce jQuery footprint, we are working towards reducing our jQuery footprint. One of the ways to accomplish this is to reduce the number of jQuery features used in Drupal core. We have added eslint rules that identify specific features and fail tests when those features are in use.
There are (or will be) individual issues for each jQuery-use eslint rule. This one is specific to jquery/no-ajax, which targets the jQuery ajax function.
core/.eslintrc.jquery.json Change "jquery/no-ajax": 0, to "jquery/no-ajax": 2, to enable eslint checks for uses of jQuery ajax(). With this change, you'll be able to see uses of the undesirable jQuery feature by running yarn lint:core-js-passing from the core directorycore/scripts/dev/commit-code-check.sh so the DrupalCI testing script can catch this jQuery usage on all files, not just those which have changed# @todo Remove the next chunk of lines before committing. This script only lints
# JavaScript files that have changed, so we add this to check all files for
# jQuery-specific lint errors.
cd "$TOP_LEVEL/core"
node ./node_modules/eslint/bin/eslint.js --quiet --config=.eslintrc.passing.json .
CORRECTJQS=$?
if [ "$CORRECTJQS" -ne "0" ]; then
# No need to write any output the node command will do this for us.
printf "${red}FAILURE ${reset}: unsupported jQuery usage. See errors above."
STATUS=1
FINAL_STATUS=1
fi
cd $TOP_LEVEL
# @todo end lines to remove
Add the block about 10 lines before the end of the file, just before if [[ "$FINAL_STATUS" == "1" ]] && [[ "$DRUPALCI" == "1" ]]; then, then remove it once all the jQuery uses have been refactored.
ajax() to use Vanilla (native) JavaScript instead.