Quantcast
Channel: Issues for Drupal core
Viewing all 291621 articles
Browse latest View live

Navigation: Fix LB placeholder label on navigation block page

$
0
0

Problem/Motivation

The font size of the placeholder label is large and breaks the UI.

Steps to reproduce

1. Go on /admin/config/user-interface/navigation-block page
2. Uncheck the checkbox "Show content preview"
3. See the Layout builder region in the sidebar
4. Font size is breaking the UI.

Proposed resolution

Remaining tasks

User interface changes

Before

After:

API changes

Data model changes

Release notes snippet


Include parameter doesn't work with different type of entities

$
0
0

Problem/Motivation

When returning a list of entities that are not the same, or a list of nodes with different content-types, if the "include" parameters is used, it checks for the first entity if this field can be included and if not possible, it raises an error with message:

title: "Bad Request",
status: "400",
detail: "`field_brighcove_video` is not a valid relationship field name. Possible values: node_type, uid, field_author, field_content, field_entity, field_main_publication_channel, field_other_publication_channel, field_section, field_series, field_source, field_team, field_teaser, field_topics, field_topic_entity.",

An example of module that uses JSON:API Resources is JSON:API Search API, which makes a lot of sense to return node within different content types.

Steps to reproduce

Try getting multiple type of data in a single JSON API with include parameters having fields that are not common between different entity types you are trying to fetch.

Proposed resolution

My suggestion is to receive the resource identifier as part of include path and check that before include it, something like ?include=node--video.field_brighcove_video.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Form textfield size cannot be adjusted when multiple allowed values are used

$
0
0

Problem/Motivation

When using textfield set to Unlimited (or more than one) values I cannot changed the field size in Manage Form Display. Changed from 60 to any size more or less does nothing to the field.

Steps to reproduce

Add a text field (any type) to any content and set the allowed values to anything other than one (1). Go to Manage Form Display and change the field size to any number and you'll see that it has no affect on the field.

Proposed resolution

I may have a solution, but I'm not completely convinced this is a true bug or something causing it on my end, and I don't know if the solution is sound. However, when I remove this CSS from core/theme/Claro/css/components/tables.css everything works fine and doesn't seem to have a negative impact. It doesn't even affect Paragraphs which is table based with these same CSS elements below.

Line: 214
Delete: td > .form-item > .form-element,

<del>td > .form-item > .form-element,</del>
td > .ajax-new-content > .form-item > .form-element,
td > .form-item > .claro-autocomplete,
td > .form-item > .claro-autocomplete > .form-element,
td > .ajax-new-content > .form-item > .claro-autocomplete,
td > .ajax-new-content > .form-item > .claro-autocomplete > .form-element {
  width: 100%;
}

The solution I'm temporarily using is my own custom CSS below. With this the fields can be resized normally.

td > .form-item > .form-element {
  width: auto;
}

Remaining tasks

None

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

None

Add symfony/polyfill-php84 and make use of new array functions

$
0
0

Problem/Motivation

PHP 8.4 will be released after Drupal 11, meaning we won't be able to use new features until we drop support for PHP 8.3. Fortunately symfony provides polyfills for many of these functions.

Steps to reproduce

Proposed resolution

Add symfony/polyfill-php84. Modernize some areas of core to use array_find, array_all, array_any and other related functions. \Drupal\Component\Assertion\Inspector is a good place to start because it has many related functions and has good unit test coverage

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

navigations 'expand sidebar' (title) lacks connection to flow

$
0
0

Problem/Motivation

  1. While reviewing with a small group, people were now sure what the 'Extent Sidebar' is now extending while desktop screen sizes expand/contracted during general run through. Title lacks connection to the navigation tool, users did not re-associate objects.
  2. Without javascript in 'small breakpoints' we see the 'expand sidebar' button. Without JS this does nothing. Navigation does not let user get into any Drupal admin path.

Steps to reproduce

using Drupal 11/10.3 standard profile.
enable Navigation module
with your browser, disable Javascript. make window less than 500px.
notice 'a bar at top' and bottom 'Expand sidebar'. this does nothing.

Proposed resolution

Also include 'navigation logo' in this area and breakpoint. As it serves are landmark for users and link to get into 'administration' when nojs and in this breakpoint.
- reminder: navigation has an template/svg.logo.twig -- Expand around with the custom logo use (with parent/wrapping link) then return that into the layout/navigation.html.twig so that it can be reused here.

Remaining tasks

choices:
- should this link to go /admin/index. (currently goes LOGO goes to Frontpage.
- should the logo link to 'return to site' type functionality.
ie 'admin/index'->front->user_setting->return-to-side/(last known page?)
- should we add a setting for user to set their choice. default/none will be (front or admin/index).

User interface changes

enhance JS degrade of Navigation 'bar at top/mobile trigger'

API changes

Data model changes

Release notes snippet

Contextual Links Style Update

$
0
0

Originally submitted on Github

Problem/Motivation

The admin UI theme is being redesigned and Contextual links need to be integrated with the new design system.

Proposed resolution

Specs to follow for the contextual link icon: https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/Drupal-Design-system...
The contextual links should not be styled as they are currently shown in the figma link. Instead, for consistency, the styling should match the existing dropbutton tray styling.

Remaining tasks

Testing instructions

    Enable Claro and set as the admin theme
  • If the profile used is Umami, access any existing content like /recipes/watercress-soup.
  • If the profile is Standard, go to the homepage and hover the "No front page content has been created yet." message.
  • Contextual links should be styled by Claro in the default theme, even if that default theme isn't Claro

Migrate Toolbar button to SDC

$
0
0

Problem/Motivation

SDC is part of core now, so we can migrate the existing code to take advantage of SDC.

Create Toolbar button into a SDC

Move the component Toolbar button into its own SDC.

Remaining tasks

User interface changes

None

API changes

Data model changes

upgrade 10.3.0

$
0
0

Hello, sorry for my English langage.

Context :
Site : https://aacm-france.fr
Host: PlanetHoster
CSV /Drupal version installed D10.3.0 managed with composer
Modules :
- drupal/ctools:^4.0
- drupal/imce:^3.0
- drupal/colorbox:^2.0
- drupal/media_gallery:^2.1
- drupal/admin_toolbar:^3.4
- drupal/vapn:^3.0@alpha
- drupal/ckeditor_font:^2.0@beta
PHP : 8.2.5
Database: 10.5.21-MariaDB

Bug: since update D10.2.7 to D10.3.0
Bug description: Modified display for creating or modifying an article, page or gallery with disappearance of areas of the writing body or summary (screenshots 1 -2 -3 ). In some cases semi-possible with simple HTML (screenshots 4 -5)
I tried to recreate the base of the site (core + modules + theme) several times directly with D10.3.0 same problem for each try.
In the reports: recent log messages: very many messages system. (screenshots 6 as 7 -8 -9).
Searches in the Drupal bug report: Issues for Drupal core: I couldn't find anything that resembled my problem.
Question: I don't understand why no one has the same problem. Is there a solution that I missed?


Allow textarea widgets to be used for text (formatted) fields

$
0
0

Problem/Motivation

I would like to use a Text (formatted) field to create a "Description" field appropriate for an og:description meta tag, since we typically want to limit those to 100-300 characters max, and also want it to allow HTML tags since it could be used for display. It is not possible to use a textarea/CKEditor widget for these fields without https://www.drupal.org/project/textarea_widget_for_text

Steps to reproduce

  • Create a new "Text (formatted)" field to a node type
  • Move to the "Manage Display" tab and observe you can only use the "Text field" widget

Proposed resolution

Allow the use of the "Text area (multiple rows)" widget

Remaining tasks

  • Are there any issues with validation? Can we make the user experience better for CKEditor where there is a #maxlength on the textarea source field? Maybe something like https://www.drupal.org/project/ckwordcount or propose CKEditor shows something if #maxlength is reached in the WYSIWYG?

User interface changes

The new widget is available in the "Manage Display" form.

API changes

None

Data model changes

None

Release notes snippet

Replace usage of generateString with generate in Media module

Since 10.3 upgrade I am seeing PHP 'assertion' errors

$
0
0

Problem/Motivation

Since updating to Drupal 8.3, I am seeing the following messages in the (PHP) error_log file on my hosting provider...

[04-Jul-2024 05:33:22 UTC] PHP Warning:  Invalid "output_buffering" setting. Invalid quantity "Off": no valid leading digits, interpreting as "0" for backwards compatibility in Unknown on line 0

[04-Jul-2024 05:33:22 UTC] PHP Deprecated:  PHP Request Shutdown: assert.active INI setting is deprecated in Unknown on line 0

[04-Jul-2024 05:33:50 UTC] PHP Warning:  Invalid "output_buffering" setting. Invalid quantity "Off": no valid leading digits, interpreting as "0" for backwards compatibility in Unknown on line 0

[04-Jul-2024 05:33:50 UTC] PHP Deprecated:  PHP Request Shutdown: assert.active INI setting is deprecated in Unknown on line 0

[04-Jul-2024 05:33:50 UTC] PHP Warning:  Invalid "output_buffering" setting. Invalid quantity "Off": no valid leading digits, interpreting as "0" for backwards compatibility in Unknown on line 0

[04-Jul-2024 05:33:50 UTC] PHP Deprecated:  PHP Request Shutdown: assert.active INI setting is deprecated in Unknown on line 0

[04-Jul-2024 05:33:57 UTC] PHP Warning:  Invalid "output_buffering" setting. Invalid quantity "Off": no valid leading digits, interpreting as "0" for backwards compatibility in Unknown on line 0

[04-Jul-2024 05:33:57 UTC] PHP Deprecated:  PHP Request Shutdown: assert.active INI setting is deprecated in Unknown on line 0

[04-Jul-2024 05:37:15 UTC] PHP Warning:  Invalid "output_buffering" setting. Invalid quantity "Off": no valid leading digits, interpreting as "0" for backwards compatibility in Unknown on line 0

[04-Jul-2024 05:37:15 UTC] PHP Deprecated:  PHP Request Shutdown: assert.active INI setting is deprecated in Unknown on line 0

[04-Jul-2024 05:37:26 UTC] PHP Warning:  Invalid "output_buffering" setting. Invalid quantity "Off": no valid leading digits, interpreting as "0" for backwards compatibility in Unknown on line 0

[04-Jul-2024 05:37:26 UTC] PHP Deprecated:  PHP Request Shutdown: assert.active INI setting is deprecated in Unknown on line 0

[04-Jul-2024 05:37:34 UTC] PHP Warning:  Invalid "output_buffering" setting. Invalid quantity "Off": no valid leading digits, interpreting as "0" for backwards compatibility in Unknown on line 0

[04-Jul-2024 05:37:34 UTC] PHP Deprecated:  PHP Request Shutdown: assert.active INI setting is deprecated in Unknown on line 0

[04-Jul-2024 05:37:36 UTC] PHP Warning:  Invalid "output_buffering" setting. Invalid quantity "Off": no valid leading digits, interpreting as "0" for backwards compatibility in Unknown on line 0

[04-Jul-2024 05:37:36 UTC] PHP Deprecated:  PHP Request Shutdown: assert.active INI setting is deprecated in Unknown on line 0

As a result of this (I think, given that it says 'PHP Request Shutdown') I cannot any longer get to the Modules page (http://drupal10.local/admin/modules) and see a 500 error.

My settings.php and my settings.local.php have been a round a while, is there something that I need to change there that relates to assertions?

Oddly, I CAN get to the Modules page on my local (Windows) development version which is allegedly using exactly the same version of Drupal (10.3) and PHP 8.3.x

Thank you

Add validation constraints to user.mail

$
0
0

Problem/Motivation

user.mail is fully validatable

./vendor/bin/drush config:inspect --filter-keys=user.mail --detail --list-constraints  --fields=key,validatability,constraints
➜  🤖 Analyzing…

 ---------------------------------------------------- ------------- ---------------------------------------------------------
  Key                                                  Validatable   Validation constraints
 ---------------------------------------------------- ------------- ---------------------------------------------------------
  user.mail                                            100%          ValidKeys: '<infer>'
                                                                     LangcodeRequiredIfTranslatableValues: null
   user.mail:                                          Validatable   ValidKeys: '<infer>'
                                                                     LangcodeRequiredIfTranslatableValues: null
   user.mail:_core                                     Validatable   ValidKeys:
                                                                       - default_config_hash
   user.mail:_core.default_config_hash                 Validatable   NotNull: {  }
                                                                     Regex: '/^[a-zA-Z0-9\-_]+$/'
                                                                     Length: 43
                                                                     ↣ PrimitiveType: {  }
   user.mail:cancel_confirm                            Validatable   ValidKeys: '<infer>'
   user.mail:cancel_confirm.body                       Validatable   Regex:
                                                                       pattern: '/([^\PC\x09\x0a\x0d])/u'
                                                                       match: false
                                                                       message: 'Text is not allowed to contain control
                                                                     characters, only visible characters.'↣ PrimitiveType: {  }
   user.mail:cancel_confirm.subject                    Validatable   Regex:
                                                                       pattern: '/([^\PC])/u'
                                                                       match: false
                                                                       message: 'Labels are not allowed to span multiple
                                                                     lines or contain control characters.'
                                                                     NotBlank: {  }
                                                                     ↣ PrimitiveType: {  }
   user.mail:langcode                                  Validatable   NotNull: {  }
                                                                     Choice:
                                                                       callback:
                                   'Drupal\Core\TypedData\Plugin\DataType\LanguageReferenc
                                                                     e::getAllValidLangcodes'↣ PrimitiveType: {  }
   user.mail:password_reset                            Validatable   ValidKeys: '<infer>'
   user.mail:password_reset.body                       Validatable   Regex:
                                                                       pattern: '/([^\PC\x09\x0a\x0d])/u'
                                                                       match: false
                                                                       message: 'Text is not allowed to contain control
                                                                     characters, only visible characters.'↣ PrimitiveType: {  }
   user.mail:password_reset.subject                    Validatable   Regex:
                                                                       pattern: '/([^\PC])/u'
                                                                       match: false
                                                                       message: 'Labels are not allowed to span multiple
                                                                     lines or contain control characters.'
                                                                     NotBlank: {  }
                                                                     ↣ PrimitiveType: {  }
   user.mail:register_admin_created                    Validatable   ValidKeys: '<infer>'
   user.mail:register_admin_created.body               Validatable   Regex:
                                                                       pattern: '/([^\PC\x09\x0a\x0d])/u'
                                                                       match: false
                                                                       message: 'Text is not allowed to contain control
                                                                     characters, only visible characters.'↣ PrimitiveType: {  }
   user.mail:register_admin_created.subject            Validatable   Regex:
                                                                       pattern: '/([^\PC])/u'
                                                                       match: false
                                                                       message: 'Labels are not allowed to span multiple
                                                                     lines or contain control characters.'
                                                                     NotBlank: {  }
                                                                     ↣ PrimitiveType: {  }
   user.mail:register_no_approval_required             Validatable   ValidKeys: '<infer>'
   user.mail:register_no_approval_required.body        Validatable   Regex:
                                                                       pattern: '/([^\PC\x09\x0a\x0d])/u'
                                                                       match: false
                                                                       message: 'Text is not allowed to contain control
                                                                     characters, only visible characters.'↣ PrimitiveType: {  }
   user.mail:register_no_approval_required.subject     Validatable   Regex:
                                                                       pattern: '/([^\PC])/u'
                                                                       match: false
                                                                       message: 'Labels are not allowed to span multiple
                                                                     lines or contain control characters.'
                                                                     NotBlank: {  }
                                                                     ↣ PrimitiveType: {  }
   user.mail:register_pending_approval                 Validatable   ValidKeys: '<infer>'
   user.mail:register_pending_approval.body            Validatable   Regex:
                                                                       pattern: '/([^\PC\x09\x0a\x0d])/u'
                                                                       match: false
                                                                       message: 'Text is not allowed to contain control
                                                                     characters, only visible characters.'↣ PrimitiveType: {  }
   user.mail:register_pending_approval.subject         Validatable   Regex:
                                                                       pattern: '/([^\PC])/u'
                                                                       match: false
                                                                       message: 'Labels are not allowed to span multiple
                                                                     lines or contain control characters.'
                                                                     NotBlank: {  }
                                                                     ↣ PrimitiveType: {  }
   user.mail:register_pending_approval_admin           Validatable   ValidKeys: '<infer>'
   user.mail:register_pending_approval_admin.body      Validatable   Regex:
                                                                       pattern: '/([^\PC\x09\x0a\x0d])/u'
                                                                       match: false
                                                                       message: 'Text is not allowed to contain control
                                                                     characters, only visible characters.'↣ PrimitiveType: {  }
   user.mail:register_pending_approval_admin.subject   Validatable   Regex:
                                                                       pattern: '/([^\PC])/u'
                                                                       match: false
                                                                       message: 'Labels are not allowed to span multiple
                                                                     lines or contain control characters.'
                                                                     NotBlank: {  }
                                                                     ↣ PrimitiveType: {  }
   user.mail:status_activated                          Validatable   ValidKeys: '<infer>'
   user.mail:status_activated.body                     Validatable   Regex:
                                                                       pattern: '/([^\PC\x09\x0a\x0d])/u'
                                                                       match: false
                                                                       message: 'Text is not allowed to contain control
                                                                     characters, only visible characters.'↣ PrimitiveType: {  }
   user.mail:status_activated.subject                  Validatable   Regex:
                                                                       pattern: '/([^\PC])/u'
                                                                       match: false
                                                                       message: 'Labels are not allowed to span multiple
                                                                     lines or contain control characters.'
                                                                     NotBlank: {  }
                                                                     ↣ PrimitiveType: {  }
   user.mail:status_blocked                            Validatable   ValidKeys: '<infer>'
   user.mail:status_blocked.body                       Validatable   Regex:
                                                                       pattern: '/([^\PC\x09\x0a\x0d])/u'
                                                                       match: false
                                                                       message: 'Text is not allowed to contain control
                                                                     characters, only visible characters.'↣ PrimitiveType: {  }
   user.mail:status_blocked.subject                    Validatable   Regex:
                                                                       pattern: '/([^\PC])/u'
                                                                       match: false
                                                                       message: 'Labels are not allowed to span multiple
                                                                     lines or contain control characters.'
                                                                     NotBlank: {  }
                                                                     ↣ PrimitiveType: {  }
   user.mail:status_canceled                           Validatable   ValidKeys: '<infer>'
   user.mail:status_canceled.body                      Validatable   Regex:
                                                                       pattern: '/([^\PC\x09\x0a\x0d])/u'
                                                                       match: false
                                                                       message: 'Text is not allowed to contain control
                                                                     characters, only visible characters.'↣ PrimitiveType: {  }
   user.mail:status_canceled.subject                   Validatable   Regex:
                                                                       pattern: '/([^\PC])/u'
                                                                       match: false
                                                                       message: 'Labels are not allowed to span multiple
                                                                     lines or contain control characters.'
                                                                     NotBlank: {  }
                                                                     ↣ PrimitiveType: {  }
 ---------------------------------------------------- ------------- ---------------------------------------------------------

Steps to reproduce

  1. Get a local git clone of Drupal core 11.x.
  2. composer require drupal/config_inspector— or manually install https://www.drupal.org/project/config_inspector/releases/2.1.5 or newer (which supports Drupal 11!)
  3. composer require drush/drush
  4. vendor/bin/drush config:inspect --filter-keys=user.mail --detail --list-constraints

Proposed resolution

Add validation constraints to:

  1. user.mail

Remaining tasks

None

User interface changes

None.

API changes

None.

Data model changes

More validation 🚀

Release notes snippet

None.

Correct the punctuation on the description for \Drupal\Tests\UnitTestCase

$
0
0

The long description for \Drupal\Tests\UnitTestCase is the following one.

Using Symfony's dump() function() in Unit tests will produce output on the command line.

The parentheses after function must be removed.

Add validation constraints to system.site

$
0
0

Problem/Motivation

system.site has 5 property path that are not yet validatable:

vendor/bin/drush config:inspect --filter-keys=system.site --detail --list-constraints
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 ---------------------------------------- --------- ------------- ------ --------------------------------------------------------------------------------------------- 
  Key                                      Status    Validatable   Data   Validation constraints                                                                       
 ---------------------------------------- --------- ------------- ------ --------------------------------------------------------------------------------------------- 
  system.site                              Correct   69%           ✅❓   ValidKeys: '<infer>'                                                                         
                                                                          LangcodeRequiredIfTranslatableValues: null                                                   
   system.site:                            Correct   Validatable   ✅✅   ValidKeys: '<infer>'                                                                         
                                                                          LangcodeRequiredIfTranslatableValues: null                                                   
   system.site:_core                       Correct   Validatable   ✅✅   ValidKeys:                                                                                   
                                                                            - default_config_hash                                                                      
   system.site:_core.default_config_hash   Correct   Validatable   ✅✅   NotNull: {  }                                                                                
                                                                          Regex: '/^[a-zA-Z0-9\-_]+$/'                                                                 
                                                                          Length: 43                                                                                   
                                                                          ↣ PrimitiveType: {  }                                                                        
   system.site:admin_compact_mode          Correct   Validatable   ✅✅   ↣ PrimitiveType: {  }                                                                        
   system.site:default_langcode            Correct   Validatable   ✅✅   NotNull: {  }                                                                                
                                                                          Choice:                                                                                      
                                                                            callback: 'Drupal\Core\TypedData\Plugin\DataType\LanguageReference::getAllValidLangcodes'↣ PrimitiveType: {  }                                                                        
   system.site:langcode                    Correct   Validatable   ✅✅   NotNull: {  }                                                                                
                                                                          Choice:                                                                                      
                                                                            callback: 'Drupal\Core\TypedData\Plugin\DataType\LanguageReference::getAllValidLangcodes'↣ PrimitiveType: {  }                                                                        
   system.site:mail                        Correct   Validatable   ✅✅   Email:                                                                                       
                                                                            message: '%value is not a valid email address.'↣ PrimitiveType: {  }                                                                        
   system.site:mail_notification           Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here                                                    
   system.site:name                        Correct   Validatable   ✅✅   Regex:                                                                                       
                                                                            pattern: '/([^\PC])/u'                                                                     
                                                                            match: false                                                                               
                                                                            message: 'Labels are not allowed to span multiple lines or contain control characters.'↣ PrimitiveType: {  }                                                                        
   system.site:page                        Correct   Validatable   ✅✅   ValidKeys: '<infer>'                                                                         
   system.site:page.403                    Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here                                                    
   system.site:page.404                    Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here                                                    
   system.site:page.front                  Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here                                                    
   system.site:slogan                      Correct   Validatable   ✅✅   Regex:                                                                                       
                                                                            pattern: '/([^\PC])/u'                                                                     
                                                                            match: false                                                                               
                                                                            message: 'Labels are not allowed to span multiple lines or contain control characters.'↣ PrimitiveType: {  }                                                                        
   system.site:uuid                        Correct   Validatable   ✅✅   Uuid: {  }                                                                                   
                                                                          NotNull: {  }                                                                                
                                                                          ↣ PrimitiveType: {  }                                                                        
   system.site:weight_select_max           Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here                                                    
 ---------------------------------------- --------- ------------- ------ --------------------------------------------------------------------------------------------- 

Steps to reproduce

  1. Get a local git clone of Drupal core 11.x.
  2. composer require drupal/config_inspector— or manually install https://www.drupal.org/project/config_inspector/releases/2.1.5 or newer (which supports Drupal 11!)
  3. composer require drush/drush
  4. vendor/bin/drush config:inspect --filter-keys=system.site --detail --list-constraints

Proposed resolution

Add validation constraints to:

  1. system.site:mail_notification
  2. system.site:page.403
  3. system.site:page.404
  4. system.site:page.front
  5. system.site:weight_select_max

For examples, search *.schema.yml files for the string constraints:😊

Reach out to @borisson_ or @wimleers in the #distributions-and-recipes.

Remaining tasks

User interface changes

None.

API changes

Data model changes

More validation 🚀

Release notes snippet

None.

Add validation constraints to core.menu.schema.yml

$
0
0

Problem/Motivation

core.menu.static_menu_link_overrides has 3 property path that are not yet validatable:

./vendor/bin/drush config:inspect --filter-keys=core.menu.static_menu_link_overrides --detail --list-constraints
➜  🤖 Analyzing…

 Legend for Data: 
  ✅❓  → Correct primitive type, detailed validation impossible.
  ✅✅  → Correct primitive type, passed all validation constraints.
 -------------------------------------------------------------------------------- --------- ------------- ------ -------------------------------------------- 
  Key                                                                              Status    Validatable   Data   Validation constraints                      
 -------------------------------------------------------------------------------- --------- ------------- ------ -------------------------------------------- 
  core.menu.static_menu_link_overrides                                             Correct   70%           ✅❓   ValidKeys: '<infer>'                        
                                                                                                                  LangcodeRequiredIfTranslatableValues: null  
   core.menu.static_menu_link_overrides:                                           Correct   Validatable   ✅✅   ValidKeys: '<infer>'                        
                                                                                                                  LangcodeRequiredIfTranslatableValues: null  
   core.menu.static_menu_link_overrides:_core                                      Correct   Validatable   ✅✅   ValidKeys:                                  
                                                                                                                    - default_config_hash                     
   core.menu.static_menu_link_overrides:_core.default_config_hash                  Correct   Validatable   ✅✅   NotNull: {  }                               
                                                                                                                  Regex: '/^[a-zA-Z0-9\-_]+$/'                
                                                                                                                  Length: 43                                  
                                                                                                                  ↣ PrimitiveType: {  }                       
   core.menu.static_menu_link_overrides:definitions                                Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here   
   core.menu.static_menu_link_overrides:definitions.contact__site_page             Correct   Validatable   ✅✅   ValidKeys: '<infer>'                        
   core.menu.static_menu_link_overrides:definitions.contact__site_page.enabled     Correct   Validatable   ✅✅   ↣ PrimitiveType: {  }                       
   core.menu.static_menu_link_overrides:definitions.contact__site_page.expanded    Correct   Validatable   ✅✅   ↣ PrimitiveType: {  }                       
   core.menu.static_menu_link_overrides:definitions.contact__site_page.menu_name   Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here   
   core.menu.static_menu_link_overrides:definitions.contact__site_page.parent      Correct   NOT           ✅❓   ⚠️  @todo Add validation constraints here   
   core.menu.static_menu_link_overrides:definitions.contact__site_page.weight      Correct   Validatable   ✅✅   Range:                                      
                                                                                                                    min: -2147483648                          
                                                                                                                    max: 2147483647                           
                                                                                                                  FullyValidatable: null                      
                                                                                                                  ↣ PrimitiveType: {  }                       
 -------------------------------------------------------------------------------- --------- ------------- ------ -------------------------------------------- 

Steps to reproduce

  1. Get a local git clone of Drupal core 11.x.
  2. composer require drupal/config_inspector— or manually install https://www.drupal.org/project/config_inspector/releases/2.1.5 or newer (which supports Drupal 11!)
  3. composer require drush/drush
  4. vendor/bin/drush config:inspect --filter-keys=core.menu.static_menu_link_overrides --detail --list-constraints

Proposed resolution

Add validation constraints to:

  1. definitions
  2. menu_name
  3. parent

For examples, search *.schema.yml files for the string constraints:😊

Reach out to @borisson_ or @wimleers in the #distributions-and-recipes.

Remaining tasks

User interface changes

None.

API changes

Data model changes

More validation 🚀

Release notes snippet

None.


Postrges implementation of introspectIndexSchema is incorrect

$
0
0

Problem/Motivation

The postgres implementation of introspectIndexSchema returns columns in the order of column name rather than in the order that columns are in the index. This makes writing tests that run on multiple dbs harder than it should be and also makes postgres tests that use it less of a proper test because the order of columns is significant.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Visibility control not working for navigation blocks

$
0
0

Problem/Motivation

With drupal 10.3 and the Patch/MR from #2916876: Add visibility control conditions to blocks within Layout Builder I am able to add visibilty conditions in layout_builder. This works fine for non-navigation layout builder. From this I assume, it also should work with navigation blocks.

Patches/MR tested:

When I add a condition to a navigation block, I get a WSOD on any page with the navigation:

Drupal\Component\Plugin\Exception\ContextException: Assigned contexts were not satisfied: user in Drupal\Core\Plugin\Context\ContextHandler->applyContextMapping() (line 145 of /home/andi/git/site-h4d-greenopolis/web/core/lib/Drupal/Core/Plugin/Context/ContextHandler.php).

Steps to reproduce

  1. Add patch
  2. Add visibility condition e.g. on user menu block in /admin/config/user-interface/navigation-block
  3. See WSOD on pages with navigation

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

GenerateThemeTest::testContribStarterkitDevSnapshotWithGitNotInstalled fails on sqlite

$
0
0

Problem/Motivation

Build test, Command/GenerateThemeTest.php is failing on SQLite and 10.3.x. The test estContribStarterkitDevSnapshotWithGitNotInstalled

Drupal\BuildTests\Command\GenerateThemeTest::testContribStarterkitDevSnapshotWithGitNotInstalled
Fake git used by process.
Failed asserting that 0 matches expected 127.

core/tests/Drupal/BuildTests/Command/GenerateThemeTest.php:291

https://git.drupalcode.org/project/drupal/-/pipelines/215476/test_report...

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

logic exception in Drupal\Core\Config\Schema\Mapp

$
0
0

Problem/Motivation

php      Error      LogicException: The mapping definition at
                                               `ckeditor5.plugin.ckeditor5_list:properties` is invalid: its `label`
                                               key contains a string. It must be an array. in
                                               Drupal\Core\Config\Schema\Mapp

Steps to reproduce

Since 10.3 upgrade

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Grey button's background color has a too low contrast ratio against page background

$
0
0

Problem/Motivation

Across the admin interface there are several pages with buttons with a grey background color, regular buttons as well as drop buttons. all with a background-color of #C1C2C7 on either on a white backgroud #FEFFFE (1.8:1) or light blueish table headers #f3f4f9 (1.6:1). In each case that fails WCAG21 SC 1.4.11 which requires a contrast ratio of 3:1.
I've asked @mgifford for feedback and advice about the buttons cuz I was uncertain if I was overcautious or if it is a necessary step. But he confirmed that the grey buttons either need an outline with more contrast or more contrast for the background color. Either should be fine and he doesn't have a strong preference and he doesn't know which would be best for the design. I'll add aside the Accessibility tag also the needs design tag since aside the change of color there also needs to be some design decision.

Steps to reproduce

- go for example to admin/structure/views/view/content or admin/content
- check the background color of the grey buttons

Only local images are allowed.

Viewing all 291621 articles
Browse latest View live


<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>