Error was introduced in the 10.3.6 release of Drupal.
Fatal error: Uncaught TypeError: Drupal\Core\Extension\ThemeHandler::addTheme(): Argument #1 ($theme) must be of type Drupal\Core\Extension\Extension, null given, called in /var/www/html/core/lib/Drupal/Core/Extension/ThemeHandler.php on line 74 and defined in /var/www/html/core/lib/Drupal/Core/Extension/ThemeHandler.php:84
Update drupal to version 10.3.6 using compser
Run drush updb
Hi, I'm running into a problem that the `entity_reference_label` formatter does not check the URL access to the entity, but only relies on checking the access to the 'view label' operation and I'm getting invalid links.
This can be reproduced by displaying a link to the user. The user always returns AccessResultAllowed for the 'view label' operation, but the direct view link (the 'view' operation) requires additional permissions.
I suggest adding an additional access check to the generated URL and if it is not available, output the label as plain text.
See #9.
Code review
Request from @alexpott in Drupal Slack
Move
to a trait and use it in:
This problem occurs for plugin types with YAML discovery.
In Core, there is layout.
In contrib, at least the following modules have the problem in their plugin types:
Have two themes, one is a parent, the other is a child.
Ensure the machine name of the child is alphabetically before the machine name of the parent.
Declare a layout in the parent theme.
Override the layout in the child theme.
Result: the plugin is not overridden.
Found a solution.
Having installed Drupal 10 via composer and migrated content, I attempted to set up ckeditor5.
I have set up 3 text formats (Filtered HTML, Full HTML & Plain Text)
After saving all Formats I noticed that I had forgotten to include the 'align text'-button in the active toolbar.
So I went back to add it. Upon saving I received the following error:
The website encountered an unexpected error. Please try again later.
The Error log shows the following:
RuntimeException: Adding non-existent permissions to a role is not allowed.
The incorrect permissions are "use text format php_code". in Drupal\user\Entity\Role->calculateDependencies() (line 207 of core/modules/user/src/Entity/Role.php).
Drupal\Core\Config\Entity\ConfigEntityBase->preSave(Object) (Line: 179)
Drupal\user\Entity\Role->preSave(Object) (Line: 528)
Drupal\Core\Entity\EntityStorageBase->doPreSave(Object) (Line: 483)
Drupal\Core\Entity\EntityStorageBase->save(Object) (Line: 253)
Drupal\Core\Config\Entity\ConfigEntityStorage->save(Object) (Line: 339)
Drupal\Core\Entity\EntityBase->save() (Line: 608)
Drupal\Core\Config\Entity\ConfigEntityBase->save() (Line: 97)
Drupal\user\Form\RoleSettingsForm->submitForm(Array, Object)
call_user_func_array(Array, Array) (Line: 114)
Drupal\Core\Form\FormSubmitter->executeSubmitHandlers(Array, Object) (Line: 52)
Drupal\Core\Form\FormSubmitter->doSubmitForm(Array, Object) (Line: 597)
Drupal\Core\Form\FormBuilder->processForm('role_settings', Array, Object) (Line: 325)
Drupal\Core\Form\FormBuilder->buildForm(Object, Object) (Line: 73)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 580)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 163)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 74)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 58)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 106)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 85)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 50)
Drupal\ban\BanMiddleware->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 686)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)
1. In Drupal Version 10.0.9's ckeditor5 delete all Formats except Plain Text, Filtered HTML and Full HTML
2. Change the Toolbar configuration under "Full HTML" format.
3. Click Save
(If "Style"-button was moved to the active tool bar, you will get an error - no idea why. Move it back to the Available section and save.)
4. Change the content of an existing Basic Page
5. Back in the Text Forms & Editor configuration, add the 'text alignment' button to the active toolbar.
6. Click save
It's currently impossible to access an overridden view block's title from within the view.
Create a "Text area" footer item on a view that contains the "[view:title]" token. Observe that the title from the view's configuration is displayed instead of the overridden title from the block configuration.
Inject the overridden block title into the view using ViewExecutable::setTitle() in ViewBlock.
Make the change.
View blocks will now make use of the overridden title, falling back to the title found in the view's configuration as needed.
None.
None.
TBD.
Attending: per issue credit
Explanation: Some full and provisional members of the Drupal Security Team meet fortnightly to triage and discuss private core security issues. These meetings are essential to core security process and should be credited like other contribution meetings.
Attending: per issue credit
Explanation: Some full and provisional members of the Drupal Security Team meet fortnightly to triage and discuss private core security issues. These meetings are essential to core security process and should be credited like other contribution meetings.
Navigation settings schema is providing all the settings in the format logo_xxx format.
As part of the last module changes, new settings have been added and the number is growing.
Following other similar config schemas like system.theme.global, we are proposing to move it to a mapping where logo is the name and the specific properties are nested there.
Use logo.xxx instead of logo_xxx for navigation settings schema.
after upgrade to php 8.1 with core 9.3.7
i've got the following error due to deprecated null input value
Deprecated function: dirname(): Passing null to parameter #1 ($path) of type string is deprecated in Drupal\Core\Extension\ExtensionPathResolver->getPath() (line 85 of /var/www/subsite/web/core/lib/Drupal/Core/Extension/ExtensionPathResolver.php)
#0 /var/www/subsite/web/core/includes/bootstrap.inc(346): _drupal_error_handler_real()
#1 [internal function]: _drupal_error_handler()
#2 /var/www/subsite/web/core/lib/Drupal/Core/Extension/ExtensionPathResolver.php(85): dirname()
#3 /var/www/subsite/web/core/lib/Drupal/Core/Asset/LibraryDiscoveryParser.php(123): Drupal\Core\Extension\ExtensionPathResolver->getPath()
#4 /var/www/subsite/web/core/lib/Drupal/Core/Asset/LibraryDiscoveryCollector.php(87): Drupal\Core\Asset\LibraryDiscoveryParser->buildByExtension()
#5 /var/www/subsite/web/core/lib/Drupal/Core/Asset/LibraryDiscoveryCollector.php(66): Drupal\Core\Asset\LibraryDiscoveryCollector->getLibraryDefinitions()
#6 /var/www/subsite/web/core/lib/Drupal/Core/Cache/CacheCollector.php(149): Drupal\Core\Asset\LibraryDiscoveryCollector->resolveCacheMiss()
#7 /var/www/subsite/web/core/lib/Drupal/Core/Asset/LibraryDiscovery.php(44): Drupal\Core\Cache\CacheCollector->get()
#8 /var/www/subsite/web/core/lib/Drupal/Core/Asset/LibraryDiscovery.php(58): Drupal\Core\Asset\LibraryDiscovery->getLibrariesByExtension()
#9 /var/www/subsite/web/core/lib/Drupal/Core/Asset/LibraryDependencyResolver.php(68): Drupal\Core\Asset\LibraryDiscovery->getLibraryByName()
#10 /var/www/subsite/web/core/lib/Drupal/Core/Asset/LibraryDependencyResolver.php(70): Drupal\Core\Asset\LibraryDependencyResolver->doGetDependencies()
#11 /var/www/subsite/web/core/lib/Drupal/Core/Asset/LibraryDependencyResolver.php(41): Drupal\Core\Asset\LibraryDependencyResolver->doGetDependencies()
#12 /var/www/subsite/web/core/lib/Drupal/Core/Asset/AssetResolver.php(104): Drupal\Core\Asset\LibraryDependencyResolver->getLibrariesWithDependencies()
#13 /var/www/subsite/web/core/lib/Drupal/Core/Asset/AssetResolver.php(116): Drupal\Core\Asset\AssetResolver->getLibrariesToLoad()
#14 /var/www/subsite/web/core/lib/Drupal/Core/Render/HtmlResponseAttachmentsProcessor.php(312): Drupal\Core\Asset\AssetResolver->getCssAssets()
#15 /var/www/subsite/web/core/lib/Drupal/Core/Render/HtmlResponseAttachmentsProcessor.php(158): Drupal\Core\Render\HtmlResponseAttachmentsProcessor->processAssetLibraries()
#16 /var/www/subsite/web/core/lib/Drupal/Core/EventSubscriber/HtmlResponseSubscriber.php(45): Drupal\Core\Render\HtmlResponseAttachmentsProcessor->processAttachments()
#17 [internal function]: Drupal\Core\EventSubscriber\HtmlResponseSubscriber->onRespond()
#18 /var/www/subsite/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(142): call_user_func()
#19 /var/www/subsite/vendor/symfony/http-kernel/HttpKernel.php(191): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch()
#20 /var/www/subsite/vendor/symfony/http-kernel/HttpKernel.php(179): Symfony\Component\HttpKernel\HttpKernel->filterResponse()
#21 /var/www/subsite/vendor/symfony/http-kernel/HttpKernel.php(80): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#22 /var/www/subsite/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle()
#23 /var/www/subsite/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#24 /var/www/subsite/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#25 /var/www/subsite/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
#26 /var/www/subsite/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\page_cache\StackMiddleware\PageCache->handle()
#27 /var/www/subsite/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#28 /var/www/subsite/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#29 /var/www/subsite/web/core/lib/Drupal/Core/DrupalKernel.php(708): Stack\StackedHttpKernel->handle()
#30 /var/www/subsite/web/index.php(19): Drupal\Core\DrupalKernel->handle()
#31 {main}
upgrade to php 8.1 with core 9.3.7
handling dirname function to accept null value or replace null with empty string
PHPStan baseline is currently skipping multiple Call to an undefined method errors in the migration system
Fix the errors in the following
This meeting takes place every Friday at 14:00 UTC (currently 7:00am PT, 10:00am ET). See Time.is to see what that is in your timezone.
The meetings are held using Zoom, and a link is posted in the #ux Slack channel 10 minutes before the meeting. Agenda is first come, first serve and set by attendees. Use the Needs usability review issue tag for issues that need review and/or suggest issues in comments here.
List of Slack users to ping 10 minutes before the meeting:
@worldlinemine, @lauriii, @AaronMcHale, @anmolgoyal74, @Ravi, @shaal, @ckrina, @simohell, @gauravvv, @Quynh, @yoroy, @andrei.zvonkov, @Regu.pl, @amazingrando
This list gets copied to the issue for the next meeting. If that has already happened, then go to that issue to add/remove yourself to/from the list.
Recording of this week's meeting: TODO
Rough transcript of this week's meeting: Drupal Usability Meeting - 2024-09-27.txt
We discussed the following issue:
NR and RTBC issues marked Needs usability review.
The group is actively tracking progress on these issues:
%Since twig/twig 3.12: Twig Filter "spaceless" is deprecated%
We can remove it without any problems and get better perfomance
https://github.com/twigphp/Twig/pull/4236
https://github.com/twigphp/Twig/pull/4308
In some situations the translations directory (where downloaded translation files get stored; e.g. sites/default/files/translations) is missing. This may happen for example in a development process, where a site is re-created on a dev machine from git and a live DB but without populating the files directory (as you use StageFileProxy).
Simplified steps to reproduce in a normally working site (translations directory = sites/default/files/translations)
$ rm -r sites/default/files/translations
$ drush locale-update
or on browser at admin/config/regional/translate/import and trying to import the .po file.
Example error messages:
[notice] File temporary://filejmiMlj could not be moved/copied because the destination directory translations:// is not configured correctly.
[error] Unable to download translation file https://ftp.drupal.org/files/translations/8.x/admin_toolbar/admin_toolbar-8.x-1.24.de.po.
[warning] fopen(translations://admin_toolbar-8.x-1.24.de.po): failed to open stream: "Drupal\locale\StreamWrapper\TranslationsStream::stream_open" call failed PoStreamReader.php:154
[warning] fgets() expects parameter 1 to be resource, boolean given PoStreamReader.php:248
[notice] Unable to import translations file: translations://admin_toolbar-8.x-1.24.de.po
Screenshot of error message on translation import form:
Processes that will profit from a fix:
Find other other processes where the translation directory is yet not auto-created.
none
none
none
This is a follow-up to #3478332: Recipes' imported config is validated too strictly by default.
That issue made it possible for recipes to opt out of the strict comparison between the recipe's shipped config, and the active config. This is a good thing, because it allows an entire class of bugs to be eliminated/sidestepped. However, it's not yet the default behavior -- we still use the strict checking by default.
Should we change the default behavior to be lenient, and allow recipes to opt into the strict checks?
We currently have hard-coded hacks like this in MenuForm:
elseif (($url = $link->getUrlObject()) && $url->isRouted() && $url->getRouteName() == 'user.page') {
$form[$id]['title']['#suffix'] = ' (' . $this->t('logged in users only') . ')';
}
This means contrib/custom menu links aren't able to do this without some heaving form altering.
See #2503755-86: Switch from user login block to login menu link and search block in standard profile and #2503755-87: Switch from user login block to login menu link and search block in standard profile.2.
Allow menu link plugins to specify admin labels.
TBD
None.
API addition.
None.
Drupal has documentation on maintainership, security policies and release and support cycles of its dependencies. However, development dependencies are largely missing on that documentation.
Since this issue was created much of the dependency information is in composer meta data but not all.
Change the current text
Issue contributors should update either Current JavaScript dependencies or Current PHP dependencies when a dependency is added or when one is removed.
To
Dependency information links
It is important to know information such as who to contact in a dependency project, it's release cycle and how to file an issue for the dependency. This type information may be provided by the package meta data but not always. So, we keep track of that in the Current JavaScript dependencies and Current PHP dependencies for some dependencies.
The dependencies that this extra information is kept for are those that have a large security or API surface. Others may be added at the discretion of the release managers.
There are three times when the page is altered for a dependency. They are when it is added, when it is deprecated and when it is removed.
- When a dependency is added, add a new listing
- When a dependency is deprecated, update the listing to include that it is to be remove in the next major version.
- When the last Drupal version to require it reaches End of Life (EOL), remove the listing.
The dependency information pages can be updated at any time.
On the Javascript dependency page
Only keep: CKEditor, jQuery, jQuery UI
On the PHP dependency page
Only keep: Symfony, Twig, Autoupdates(TBD)
dependency evaluation - For issue that include dependency evaluation and contact information.
Use of the new tag is added to Criteria for adding dependencies
Add link to issues with the new tag on the policy page
Discuss the future of these pages
Are they still needed?
What dependencies (dev and production) should be listed and why?
Add a new tag to find issue with the dependency information for dependencies that are not maintained on these pages.
Update documentation as required
I think it's high time we bring the essential parts of Linkit into Drupal core: no configuration required (but possible! think: which entity types and bundles to provide suggestions for), just linking:
Add the essence of Linkit to Drupal core:
entity_links filter to be enabled, which is conceptually exactly like \Drupal\editor\Plugin\Filter\EditorFileReference (which handles HTML elements with data-entity-type="file" data-entity-uuid="*" src), but this will instead handle HTML elements with data-entity-type="*" data-entity-uuid="*" href) — this ensures links are always pointing to the latest URL alias 👍\Drupal\ckeditor5\Controller\CKEditor5MediaController::mediaEntityMetadata() and \Drupal\media\Controller\MediaFilterController::preview().🤔 What does https://www.drupal.org/project/linkit have that this merge request does not?
\Drupal\linkit\SubstitutionInterface (introduced in #2786049: Make entity URL substitutions pluggable to support a wider variety of use cases. and the accompanying data-substitution attribute — I don't think it's necessary in 99% of cases — if you need this advanced feature, just use contrib Linkit 🤓\Drupal\linkit\MatcherInterface, \Drupal\linkit\ConfigurableMatcherInterface, etc. — just using an entity query to match the entity label is sufficient for ~90% of cases — if you need this advanced feature, just use contrib Linkit 🤓title attribute on links based on the linked entity's label — if you need this advanced feature, just use contrib Linkit 🤓 → furthermore, on this issue this was reported to be problematic for accessibility in #51, #55 and #56🫣 Which contrib modules does this partially or completely replace?
(Usage stats on March 30, 2023.)
And if this functionality is adopted by a site, then arguably most of the functionality in the following modules becomes obsolete:
editor_file_reference filter in core
editor_file_reference filter in core
🙏 I want to use this but I'm currently using Linkit, how do I switch?
Glad you asked!
https://www.drupal.org/project/linkit used the same data-entity-type and data-entity-uuid that \Drupal\editor\Plugin\Filter\EditorFileReference introduced >8 years ago. It's specifically designed for portability. And it makes the transition from the contrib module to this core feature trivial:
linkit filter
entity_links filter
TBD
The CKEditor 5 linking experience becomes vastly better!
entity_links filter pluginEntityLinkSuggester config entity typeckeditor5_link_entity_suggestions CKEditor 5 plugin#type => radios's #options array no longer must be an array of strings, but an array of arrays is accepted too — this allows setting a #description per radio button for exampleNone.
TBD
When the TwigExtension service is overridden, #3270148: Provide a mechanism for deprecation of variables used in twig templates uses the wrong class and throws an exception:
The website encountered an unexpected error. Try again later.
Twig\Error\RuntimeError: The "Drupal\Core\Template\TwigExtension" extension is not enabled in "__string_template__d7d7f1a462505651fc222178924da388" at line 1. in Twig\ExtensionSet->getExtension() (line 73 of /var/www/html/vendor/twig/twig/src/ExtensionSet.php).
Twig\Environment->getExtension('\Drupal\Core\Template\TwigExtension') (Line: 40)Override the class in a custom module service provider class. Then visit any page that uses twig.
/**
* Modifies the date_formatter service.
*/
class MyModuleServiceProvider extends ServiceProviderBase {
/**
* {@inheritdoc}
*/
public function alter(ContainerBuilder $container) {
if ($container->hasDefinition('twig.extension')) {
$container->getDefinition('twig.extension')
->setClass('Drupal\my_module\Template\TwigExtension');
}
}
}The overridden class can be simply defined.
<?php
namespace Drupal\my_module\Template;
use Drupal\Core\Template\TwigExtension as CoreTwigExtension;
/**
* class TwigExtension.
*/
class TwigExtension extends CoreTwigExtension {
}
Class can be simply defined
Review/Commit
None.
None.
None.
This is spun off from https://git.drupalcode.org/project/drupal/-/merge_requests/9734#note_386087. We could use a dedicated validation constraint to ensure that a string is a valid config object name (doesn't necessarily have to exist in active config, just needs to have the proper format).