Quantcast
Channel: Issues for Drupal core
Viewing all 298117 articles
Browse latest View live

Individual admin pages no longer accessible after update to 10.4

$
0
0

Problem/Motivation

After updating from Drupal core 10.3.10 to 10.4.0, I get an error message for the following three admin pages:

/admin/appearance
Notification: Symfony\Component\Routing\Exception\RouteNotFoundException: Route "update.theme_install" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 211 of /web/core/lib/Drupal/Core/Routing/RouteProvider.php).

/admin/modules
Notification: Symfony\Component\Routing\Exception\RouteNotFoundException: Route "update.module_install" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 211 of /web/core/lib/Drupal/Core/Routing/RouteProvider.php).

/reports/updates
Notification: Symfony\Component\Routing\Exception\RouteNotFoundException: Route "update.report_install" does not exist. in Drupal\Core\Routing\RouteProvider->getRouteByName() (line 211 of /web/core/lib/Drupal/Core/Routing/RouteProvider.php).

Steps to reproduce

I did the update manually, i.e. without composer. (The website is completely installed without composer.)
The subsequent database update ran without errors.

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet


Add weekly granularity to views date sort

$
0
0

Problem/Motivation

It would be great to have a date sorting system that allows filtering by weeks

Mark Media and Media Library modules' procedural hooks as converted

$
0
0

Problem/Motivation

Follow-up from #3494908: Mark several more modules as hooks converted from procedural to OOP. Let's make the changes we need to make to mark the remaining modules.
Modules that implement hooks that cannot be converted we use the #[StopProceduralScan] Attribute.
This is for media and media library.

Steps to reproduce

N/A

Proposed resolution

Add #[StopProceduralScan] Attribute to modules that have hook_requirements, hook_hook_info or hook_module_implements_alter
Move procedural hooks to top of files that must remain

If there is not already a services file create it

Remaining tasks

N/A

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

[meta] Release preparation steps for 11.2.0 and 10.5.0

$
0
0

Release preparation worksheet

11.2.0 and 10.5.0 release prep spreadsheet

Committer Google Drive folder (restricted access)

11.2 and 10.5 preparation

Release note drafts

[#TBA]

Frontpage post draft

[#TBA]

Remaining tasks

Both branches

  • Use the equivalent updates to prevent updated from 10.5.0 to 11.2.0
  • TBD

For 11.2.0

  • Symfony update
  • Composer updates
  • Frontend updates
  • jQuery update

For 10.5.0.0

  • Composer updates
  • Frontend updates

Priority issues

These issues may change and there is no guarantee that they will be in the release.

Done

  • None yet.

[meta] 11.2.0 and 10.5.0 release notes

$
0
0

Background information

Release notes

Instructions

  1. Read over the release notes draft. The section at the top is the initial outline for the release notes. The sections at the bottom need to be completed.
  2. Make sure that all issues tagged '11.2.0 release notes' and '10.5.0 release notes' are included in the respective drafts.
  3. If an issue is tagged for the 11.2.0 notes but not for the 10.5.0 notes, check whether it was backported and correct the tagging.
  4. If an issue is tagged for the 10.5.0 release notes, ensure something was actually backported. Also ensure that the 10.4 version of the release note is accurate.
  5. Review the format of the release notes, and leave comments on the Google doc where something seems incorrect:
    • Ensure that every release note describes a disruptive change. Additions without any disruptive changes belong in the release highlights post, not the release notes.
    • Ensure that every release note follows the release note snippet best practices.
    • Ensure that every release note (save those about a dependency update) includes a link to a change record.
    • Ensure that release notes are formatted correctly in bulleted lists, and that each list item has a blank newline between the tag and the list item text. For example:
      <li>
                              A disruptive change is described here. For more information, review <a href="">the change record about what-and-such</a>.
                          </li>
                      
    • Follow the rough organization suggested by committers. If you think something belongs in a different section, leave a comment.
  6. Use the Google Docs "suggestion" feature to suggest corrections, readability improvements, etc.
  7. Comment on this issue to receive credit for working on the release notes.

Remove remaining uses of FormattableMarkup in kernel test assertions

$
0
0

Problem/Motivation

There is no need to use FormattableMarkup to produce message strings in PHPUnit assertions; it is cleaner and easier in almost all cases to use simple string interpolation instead.

Steps to reproduce

Proposed resolution

Replace all uses of FormattableMarkup in kernel test assertions with either plain string interpolation, or remove the assertion message entirely when the assertion is obvious and the message does not add any context.

Keep FormattableMarkup at:

  • tests/Drupal/KernelTests/Core/Routing/ExceptionHandlingTest.php (single comment)
  • tests/Drupal/KernelTests/Core/Theme/TwigMarkupInterfaceTest.php (markup tests)
  • tests/Drupal/KernelTests/Core/Test/Comparator/MarkupInterfaceComparatorTest.php (markup tests)
  • tests/Drupal/KernelTests/Component/Render/FormattableMarkupKernelTest.php (test FormattableMarkup)

Remaining tasks

1) Command to search code base

grep FormattableMarkup -r -l | grep Kernel

2) There are 2 child issue:

  1. #3494631: Remove FormattableMarkup from SmartDefaultSettingsTest
  2. #3494633: Remove FormattableMarkup from assertFileHookCalled()

3) Decide if FormattableMarkup should be removed from:

  • tests/Drupal/KernelTests/AssertContentTrait.php
  • modules/system/tests/src/Kernel/Theme/FunctionsTest.php

User interface changes

API changes

Data model changes

Release notes snippet

Branch 11.2.x shortly before 11.2.0-alpha1

$
0
0

This is a stub issue for a release management task.

Branch 10.6..x shortly before 10.5.0-alpha1

$
0
0

This is a stub issue for a release management task.


Requirements for tagging 11.2.0-beta1 and 10.5.0-beta1

$
0
0

Requirements prior to beta for both branches

  • TBA

For 11.2.0

  • Symfony update
  • Composer updates
  • Frontend updates
  • jQuery update

For 10.5.0.0

  • Composer updates
  • Frontend updates

11.2.0 and 10.5.0 release schedule announcement

11.2.0 front page post

11.2.0-alpha1 release notes

11.2.0-beta1 release notes

11.2.0-rc1 release notes

11.2.0 release notes


10.5.0-alpha1 release notes

10.5.0-beta1 release notes

10.5.0-rc1 release notes

10.5.0 release notes

[random test failure] EditorSecurityTest::testEditorXssFilterOverride

$
0
0

Problem/Motivation

    Editor Security (Drupal\Tests\editor\Functional\EditorSecurity)
     ✔ Initial security
     ✔ Switching security
     ✘ Editor xss filter override
       ┐
       ├ Behat\Mink\Exception\ExpectationException: The field "edit-body-0-value" value is "Hello, Dumbo Octopus!alert(0)", but "Hello, Dumbo Octopus!alert(0)" expected.
       │
       │ /builds/issue/drupal-3069442/vendor/behat/mink/src/WebAssert.php:888
       │ /builds/issue/drupal-3069442/vendor/behat/mink/src/WebAssert.php:781
       │ /builds/issue/drupal-3069442/core/tests/Drupal/Tests/WebAssert.php:991
       │ /builds/issue/drupal-3069442/core/modules/editor/tests/src/Functional/EditorSecurityTest.php:454
       ┴
    
    FAILURES!
    Tests: 3, Assertions: 131, Failures: 1.

Steps to reproduce

Example: https://git.drupalcode.org/issue/drupal-3069442/-/jobs/3468066#L1429

Proposed resolution

Replace calls to State with calls to KeyValue.

The root cause of this issue is discussed in #3496257: Race conditions in CacheCollector/State (again)

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Viewing all 298117 articles
Browse latest View live


<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>